apollo-link-dedup - npm Package Compare versions

Comparing version 1.0.9 to 1.1.0-alpha.0

lib/bundle.umd.js

@@ -34,2 +34,8 @@ (function (global, factory) {
             }
+            // Do not dedup deferred queries - it gets tricky when we have to keep track
+            // of the stream of patches to replay it for deduped subscribers. Perhaps
+            // it is better to set watchQuery on the cache directly to get those updates
+            if (operation.getContext().isDeferred) {
+                return forward(operation);
+            }
             var key = operation.toKey();
@@ -64,3 +70,3 @@ var cleanup = function (key) {
                                     prev.next.forEach(function (next) { return next(result); });
-                                    prev.complete.forEach(function (complete) { return complete(); });
+                                    prev.complete.forEach(function (complete) { return complete(result); });
                                 }
@@ -67,0 +73,0 @@ },

lib/dedupLink.js

@@ -29,2 +29,8 @@ var __extends = (this && this.__extends) || (function () {
         }
+        // Do not dedup deferred queries - it gets tricky when we have to keep track
+        // of the stream of patches to replay it for deduped subscribers. Perhaps
+        // it is better to set watchQuery on the cache directly to get those updates
+        if (operation.getContext().isDeferred) {
+            return forward(operation);
+        }
         var key = operation.toKey();
@@ -59,3 +65,3 @@ var cleanup = function (key) {
                                 prev.next.forEach(function (next) { return next(result); });
-                                prev.complete.forEach(function (complete) { return complete(); });
+                                prev.complete.forEach(function (complete) { return complete(result); });
                             }
@@ -62,0 +68,0 @@ },

package.json

 {
   "name": "apollo-link-dedup",
-  "version": "1.0.9",
+  "version": "1.1.0-alpha.0",
   "description": "Deduplicates queries that are currently on the wire",
@@ -45,13 +45,13 @@ "author": "Evans Hauser <[e-mail]>",
     "@types/graphql": "0.12.6",
-    "@types/jest": "22.2.2",
-    "browserify": "16.1.1",
+    "@types/jest": "22.2.3",
+    "browserify": "16.2.2",
     "graphql": "0.13.2",
-    "graphql-tag": "2.8.0",
-    "jest": "22.4.3",
+    "graphql-tag": "2.9.2",
+    "jest": "22.4.4",
     "rimraf": "2.6.1",
-    "rollup": "0.57.1",
-    "ts-jest": "21.2.4",
-    "tslint": "5.9.1",
-    "typescript": "2.7.2",
-    "uglify-js": "3.3.16"
+    "rollup": "0.62.0",
+    "ts-jest": "22.4.6",
+    "tslint": "5.11.0",
+    "typescript": "2.9.2",
+    "uglify-js": "3.4.5"
   },
@@ -58,0 +58,0 @@ "jest": {

src/__tests__/dedupLink.ts

@@ -183,2 +183,3 @@ import {
           observer.next({ data: { test: 1 } });
+          observer.complete();
         });
@@ -185,0 +186,0 @@ }),

src/dedupLink.ts

@@ -28,2 +28,9 @@ import {
 
+    // Do not dedup deferred queries - it gets tricky when we have to keep track
+    // of the stream of patches to replay it for deduped subscribers. Perhaps
+    // it is better to set watchQuery on the cache directly to get those updates
+    if (operation.getContext().isDeferred) {
+      return forward(operation);
+    }
+
     const key = operation.toKey();
@@ -62,3 +69,3 @@
                 prev.next.forEach(next => next(result));
-                prev.complete.forEach(complete => complete());
+                prev.complete.forEach(complete => complete(result));
               }
@@ -65,0 +72,0 @@ },

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

38447

decreased by-25.26%

Number of package files

21

decreased by-22.22%

Lines of code

530

decreased by-32.14%

Number of low quality alerts

1

increased byInfinity%

No dependency changes