appsflyer - npm Package Compare versions

Comparing version 4.2.8 to 4.2.9

package.json

 {
   "name": "appsflyer",
-  "version": "4.2.8",
-  "description": "Cordova AppsFlyer Plugin",
+  "version": "4.2.9",
+  "description": "Cordova AppsFlyer SDK Plugin",
   "cordova": {
-    "id": "com.appsflyer.phonegap.plugins.appsflyer",
+    "id": "cordova-plugin-appsflyer-sdk",
     "platforms": [
@@ -14,3 +14,3 @@ "android",
     "type": "git",
-    "url": "git+https://github.com/AppsFlyerSDK/PhoneGap.git"
+    "url": "git+https://github.com/AppsFlyerSDK/cordova-plugin-appsflyer-sdk.git"
   },
@@ -31,10 +31,19 @@ "keywords": [
   "author": "Appsflyer",
-  "license": "MIT License",
+  "license": {
+    "type": "MIT",
+    "url": "https://github.com/AppsFlyerSDK/nativescript-plugin-appsflyer/blob/master/LICENSE"
+  },
   "bugs": {
-    "url": "https://github.com/AppsFlyerSDK/PhoneGap/issues"
+    "url": "https://github.com/AppsFlyerSDK/cordova-plugin-appsflyer-sdk/issues"
   },
-  "homepage": "https://github.com/AppsFlyerSDK/PhoneGap#readme",
+  "homepage": "https://github.com/AppsFlyerSDK/cordova-plugin-appsflyer-sdk#readme",
   "scripts": {
     "test": "npm run jshint",
-    "jshint": "node node_modules/jshint/bin/jshint www && node node_modules/jshint/bin/jshint src && node node_modules/jshint/bin/jshint tests"
+    "jshint": "node node_modules/jshint/bin/jshint www && node node_modules/jshint/bin/jshint src && node node_modules/jshint/bin/jshint tests",
+    "preparedemo": "cd examples/demoA; cordova plugin rm cordova-plugin-appsflyer-sdk --save; cordova plugin add ../.. --save",
+    "setup": "cd examples/demoA; npm install; cd ../..; npm run preparedemo;",
+    "demo.ra": "cd examples/demoA; ionic run android",
+    "demo.ba": "cd examples/demoA; ionic build android",
+    "demo.ri": "cd examples/demoA; ionic run ios",
+    "demo.bi": "cd examples/demoA; ionic build ios"
   },
@@ -41,0 +50,0 @@ "devDependencies": {

README.md

 <img src="https://www.appsflyer.com/wp-content/themes/ohav-child/images/logo.svg"  width="200">
 
-# Cordova/PhoneGap AppsFlyer plugin for Android and iOS. [![npm version](https://badge.fury.io/js/appsflyer.svg)](https://badge.fury.io/js/appsflyer) [![Build Status](https://travis-ci.org/AppsFlyerSDK/PhoneGap.svg?branch=master)](https://travis-ci.org/AppsFlyerSDK/PhoneGap)
+# Cordova AppsFlyer plugin for Android and iOS. [![npm version](https://badge.fury.io/js/cordova-plugin-appsflyer-sdk.svg)](https://badge.fury.io/js/cordova-plugin-appsflyer-sdk) [![Build Status](https://travis-ci.org/AppsFlyerSDK/cordova-plugin-appsflyer-sdk.svg?branch=master)](https://travis-ci.org/AppsFlyerSDK/cordova-plugin-appsflyer-sdk)
 
@@ -25,3 +25,2 @@
  - [getAppsFlyerUID](#getAppsFlyerUID)
- - [onInstallConversionDataLoaded](#onInstallConversionDataLoaded)
 - [Deep linking Tracking](#deep-linking-tracking) 
@@ -37,3 +36,2 @@ - [Android](#dl-android)
 
- `Cordova >= 4.3.x.`
 
@@ -50,3 +48,3 @@
 ```
-$ cordova plugin add appsflyer
+$ cordova plugin add cordova-plugin-appsflyer-sdk
 ```
@@ -56,3 +54,3 @@ or directly from git:
 ```
-$ cordova plugin add https://github.com/AppsFlyerSDK/PhoneGap.git
+$ cordova plugin add https://github.com/AppsFlyerSDK/cordova-plugin-appsflyer-sdk.git
 ```
@@ -166,2 +164,3 @@
 | `isDebug`  |`boolean`| `false` | debug mode (optional)|
+| `onInstallConversionDataListener`  |`boolean`| `false` | Accessing AppsFlyer Attribution / Conversion Data from the SDK (Deferred Deeplinking). Read more: [Android](http://support.appsflyer.com/entries/69796693-Accessing-AppsFlyer-Attribution-Conversion-Data-from-the-SDK-Deferred-Deep-linking-), [iOS](http://support.appsflyer.com/entries/22904293-Testing-AppsFlyer-iOS-SDK-Integration-Before-Submitting-to-the-App-Store-) AppsFlyer plugin will fire `onInstallConversionData` event with attribution data. 
 
@@ -181,3 +180,4 @@ *Example:*
                appId: '123456789',
-               isDebug: false
+               isDebug: false,
+               onInstallConversionDataLoaded: true
              };
@@ -200,3 +200,3 @@ window.plugins.appsFlyer.initSdk(options, onSuccess, onError);
 | ----------- |-----------------------------|--------------|
-| `eventName` | `String`                    | custom event name, is presented in your dashboard.  See the Event list [HERE](https://github.com/AppsFlyerSDK/PhoneGap/blob/master/platform/ios/AppsFlyerTracker.h)  |
+| `eventName` | `String`                    | custom event name, is presented in your dashboard.  See the Event list [HERE](https://github.com/AppsFlyerSDK/cordova-plugin-appsflyer-sdk/blob/master/platform/ios/AppsFlyerTracker.h)  |
 | `eventValue` | `Object`                    | event details |
@@ -235,3 +235,3 @@
 
-#####** <a id="setAppUserId"> `setAppUserId(customerUserId): void`**
+##### <a id="setAppUserId"> **`setAppUserId(customerUserId): void`**
 
@@ -256,3 +256,3 @@
 
-#####** <a id="setGCMProjectID"> `setGCMProjectID(GCMProjectID): void`**
+##### <a id="setGCMProjectID"> **`setGCMProjectID(GCMProjectID): void`**
 
@@ -265,2 +265,5 @@ Set the GCM API key. AppsFlyer requires a Google Project Number and GCM API Key to enable uninstall tracking.
 
+
+//TBD should be from delegate
+
 ##### <a id="registerUninstall"> **`registerUninstall(token): void`** 
@@ -302,26 +305,2 @@
 
-
-##### <a id="onInstallConversionDataLoaded"> **`onInstallConversionDataLoaded(conversionData): void`** 
-
-Accessing AppsFlyer Attribution / Conversion Data from the SDK (Deferred Deeplinking). 
- Read more: [Android](http://support.appsflyer.com/entries/69796693-Accessing-AppsFlyer-Attribution-Conversion-Data-from-the-SDK-Deferred-Deep-linking-), [iOS](http://support.appsflyer.com/entries/22904293-Testing-AppsFlyer-iOS-SDK-Integration-Before-Submitting-to-the-App-Store-)  
-**Note:** AppsFlyer plugin will fire `onInstallConversionDataLoaded` event with attribution data. You must implement `onInstallConversionDataLoaded` listener to receive the data.
-
-
-| parameter   | type                        | description |
-| ----------- |-----------------------------|--------------|
-| `conversionData` | `Object`                    |  |
-
- 
-
-*Example:*
-
-```javascript
-document.addEventListener('onInstallConversionDataLoaded', function(e){
-    var attributionData = (JSON.stringify(e.detail));
-    alert(attributionData);
-}, false);
-```
-
-
 ### <a id="deep-linking-tracking"> Deep linking Tracking
@@ -352,3 +331,16 @@
 
-## <a id="sample-app"> Sample app:
-We have posted [af-cordova-ionic-demo](https://github.com/af-fess/af-cordova-ionic-demo) as s separate repo in github, you can download and run it.
+##Demo
+
+This plugin has a `examples` folder with `demoA` (Angular 1) project bundled with it. To give it a try , clone this repo and from root a.e. `cordova-plugin-appsflyer-sdk` execute the following:
+
+```sh
+npm run setup
+```
+
+  -  `npm run demo.ra` - runs Android
+  -  `npm run demo.ba` - builds Android
+  -  `npm run demo.ri` - runs iOS
+  -  `npm run demo.bi` - builds iOS
+  
+
+![demo printscreen](examples/demo_example.png?raw=true)

RELEASENOTES.md

 # Release Notes
+### 4.2.9 (Nov 25, 2016)
+* moved from PhoneGap to cordova-plugin-appsflyer-sdk
+* onInstallConversionDataListener added to `initSdk`
+* DOCs fixes
+
+# Release Notes
 ### 4.2.7 (Nov 14, 2016)
@@ -3,0 +9,0 @@ * changed isDebug to default false

www/appsflyer.js

@@ -7,2 +7,4 @@
 
+    //var eventsMap = {};    
+
     if (!window.CustomEvent) {
@@ -33,2 +35,3 @@ window.CustomEvent = function (type, config) {
 
+//             args.onInstallConversionDataListener = (eventsMap['onInstallConversionData']) ? true: false;
              exec(successCB, errorCB, "AppsFlyerPlugin", "initSdk", [args]);    
@@ -38,2 +41,45 @@ }
 
+
+        // AppsFlyer.prototype.onInstallConversionDataN = function(callback) {
+
+        //      console.log("onInstallConversionDataN is called" );
+
+        //     const listener = NativeAppEventEmitter.addListener('onInstallConversionData',
+        //         function(_data){
+        //             if(callback && typeof(callback) === typeof(Function)){
+        //                 try{
+        //                     let data = JSON.parse(_data);
+        //                     callback(data);
+        //                 }
+        //                 catch(_error){
+        //                     callback(new AFParseJSONException("Invalid data structure", _data));
+        //                 }
+        //             }
+        //         }
+        //     );            
+        // };
+
+
+        //  AppsFlyer.prototype.onInstallConversionData = function (conversionData) {
+
+        //   console.log("onInstallConversionData is called" );
+
+        //     var data = conversionData,event;
+
+        //     if (typeof data === "string") {
+        //         data = JSON.parse(conversionData);
+        //     }
+            
+        //     event = new CustomEvent('onInstallConversionData', {'detail': data});
+        //     global.document.dispatchEvent(event);
+
+        //      eventsMap['onInstallConversionData'] = listener;
+
+        //      // unregister listener
+        //     return function remove() {
+        //          console.log("onInstallConversionData listener.remove()" );
+        //         listener.remove();
+        //     };
+        // };
+
         AppsFlyer.prototype.setCurrencyCode = function (currencyId) {
@@ -71,12 +117,7 @@ argscheck.checkArgs('S', 'AppsFlyer.setCurrencyCode', arguments);
 
-        AppsFlyer.prototype.onInstallConversionDataLoaded = function (conversionData) {
-            var data = conversionData,
-                    event;
-            if (typeof data === "string") {
-                data = JSON.parse(conversionData);
-            }
-            event = new CustomEvent('onInstallConversionDataLoaded', {'detail': data});
-            global.document.dispatchEvent(event);
-        };
+        
 
+
+
+
         global.cordova.addConstructor(function () {
@@ -95,2 +136,9 @@ if (!global.Cordova) {
 
+
+function AFParseJSONException(_message, _data) {
+    this.message = _message;
+    this.data = _data;
+    this.name = "AFParseJSONException";
+}
+
     

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

No website

Quality

Package does not have a website.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2093245

increased by1.18%

Number of package files

21

increased by16.67%

Lines of code

312

increased by10.25%

Number of low maintenance alerts

1

decreased by-50%

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Number of lines in readme file

334

decreased by-2.34%

No dependency changes