arcnearby - npm Package Compare versions

Comparing version 0.0.4 to 0.0.5

arcnearby.js

 var config = require("./config")
     ,_ = require("underscore")
-    ,request = require("request");
+    ,request = require("request")
+    ,Promise = require("node-promise").Promise;
 
-(function(app, config, _, request) {
+(function(app, config, _, request, Promise) {
     
@@ -63,39 +64,33 @@ /**
     /**
-     * Basic serialize helper function, converts object to querystring
-     * @param {Object} obj Object of params
-     * @returns {String} Querystring of params
-     */
-    app.serialize = function(obj) {
-        var str = [];
-        for(var p in obj)
-            str.push(encodeURIComponent(p) + "=" + encodeURIComponent(obj[p]));
-        return str.join("&");
-    };
-    
-    /**
      * Main wrapper for library
      * Generates bounding box, executes HTTP request to ArcGIS REST API, sorts by distance
-     * @param {String} service Which ArcGIS service to query
+     * @param {String} service Which ArcGIS service to query. Use either a full service URL or a reference to the config.js services
      * @param {Array} coords Lat/lng of the center point to look around
      * @param {Number} radius Radius to look within in square miles
      * @param {Object} [overrideParams] Optional ArcGIS REST API parameters to override the query with (see config.js for params)
-     * @param {Function} successCallback
-     * @param {Function} errorCallback
+     * @param {Function} [successCallback]
+     * @param {Function} [errorCallback]
+     * @returns {Promise}
      */
     app.getNearby = function(service, coords, radius, overrideParams, successCallback, errorCallback) {
-        var url = config.apiHost + config.apiPath + (config.services[service] || "")
+        var promise = new Promise()
+            ,url = service.indexOf("http://") !== -1 ? service : config.apiHost + config.apiPath + (config.services[service] || "")
             ,params = ( ! _.isEmpty(overrideParams)) ? _.defaults(overrideParams, config.params) : _.clone(config.params);
-        params.geometry = app.getBoundingBox(coords, radius); // Get bounding box
-        url += "?" + app.serialize(params);
-        //console.log(url);
-        request(url, function(error, response, body) { // Query REST service
-            if(error) {
-                errorCallback(response, body);
-            } else {
-                var data = JSON.parse(body);
-                successCallback((data.features !== undefined) ? app.sortByDistance(data.features, coords) : {}); // Sort by distance
+        params.geometry = app.getBoundingBox(coords, radius).join(","); // Get bounding box
+        request({url: url, qs: params}, function(error, response, body) { // Query REST service
+            if(error || response.statusCode !== 200) {
+                promise.reject(response, body);
+                if(errorCallback) errorCallback(response, body);
             }
+            var data = JSON.parse(body)
+                ,sortedData = {};
+            if(data.features !== undefined) {
+                sortedData = app.sortByDistance(data.features, coords); // Sort by distance
+            }
+            promise.resolve(sortedData);
+            if(successCallback) successCallback(sortedData);
         });
+        return promise;
     };
 
-})(module.exports, config, _, request);
+})(module.exports, config, _, request, Promise);

main.js

 /**
- * Example usage of arcnearby
+ * Example usage of arcnearby using callback. Alternatively, the method returns a promise
  */
@@ -4,0 +4,0 @@ var arcnearby = require("./arcnearby")

package.json

 {
   "name": "arcnearby",
   "description": "Generate bounding box around center point and search ArcGIS REST service for features within it, sorted by distance",
-  "version": "0.0.4",
-  "homepage": "https://github.com/timwis/ArcNearby",
-  "author": "Tim Wisniewski, Sarah Cordivano, David Walk",
+  "version": "0.0.5",
+  "homepage": "https://github.com/timwis/arcnearby",
+  "author": "Tim Wisniewski, Sarah Cordivano",
   "main": "arcnearby",
   "repository": {
     "type": "git",
-    "url": "[e-mail]:timwis/ArcNearby.git"
+    "url": "[e-mail]:timwis/arcnearby.git"
   },
   "dependencies": {
     "underscore": "*",
-    "request": "*"
+    "request": "*",
+    "node-promise": "*"
   },
@@ -16,0 +17,0 @@ "devDependencies": {},

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Wildcard dependency

Quality

Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

7529

increased by3.29%

Worsened metrics

Dependency count

3

increased by50%

Lines of code

120

decreased by-3.23%

Number of medium quality alerts

4

increased by33.33%

Dependency changes

• + Addednode-promise@*

• + Addednode-promise@0.5.14(transitive)