atom-keymap - npm Package Compare versions

Comparing version 2.0.5 to 2.0.6

api.json

@@ -6,3 +6,3 @@ {
       "filename": "src/keymap-manager.coffee",
-      "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L92",
+      "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L92",
       "sections": [],
@@ -13,3 +13,3 @@ "classMethods": [
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L107",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L107",
           "visibility": "Public",
@@ -76,3 +76,3 @@ "summary": "Create a keydown DOM event for testing purposes.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L124",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L124",
           "visibility": "Public",
@@ -101,3 +101,3 @@ "summary": "Create a new KeymapManager.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L132",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L132",
           "visibility": "Public",
@@ -110,3 +110,3 @@ "summary": "Unwatch all watched paths. ",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L140",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L140",
           "visibility": "Public",
@@ -125,3 +125,3 @@ "summary": "Get all current key bindings.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L149",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L149",
           "visibility": "Public",
@@ -148,3 +148,3 @@ "summary": "Add sets of key bindings grouped by CSS selector.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L173",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L173",
           "visibility": "Public",
@@ -179,3 +179,3 @@ "summary": "Load the key bindings from the given path.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L190",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L190",
           "visibility": "Public",
@@ -188,3 +188,3 @@ "summary": "Cause the keymap to reload the key bindings file at the given path\nwhenever it changes.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L202",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L202",
           "visibility": "Public",
@@ -205,3 +205,3 @@ "summary": "Remove the key bindings added with {::add} or {::loadKeymap}.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L225",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L225",
           "visibility": "Public",
@@ -214,3 +214,3 @@ "summary": "Dispatch a custom event associated with the matching key binding for\nthe given `KeyboardEvent` if one can be found.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L304",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L304",
           "visibility": "Public",
@@ -257,3 +257,3 @@ "summary": "Get the key bindings for a given command and optional target.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L475",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L475",
           "visibility": "Public",
@@ -283,3 +283,3 @@ "summary": "Translate a keydown event to a keystroke string.",
           "sectionName": null,
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.5/src/keymap-manager.coffee#L111",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v2.0.6/src/keymap-manager.coffee#L111",
           "visibility": "Public",
@@ -286,0 +286,0 @@ "summary": "The number of milliseconds allowed before pending states caused\nby partial matches of multi-keystroke bindings are terminated. ",

lib/key-binding.js

 (function() {
-  var Grim, KeyBinding, calculateSpecificity;
+  var Grim, KeyBinding, PropertyAccessors, calculateSpecificity;
 
   Grim = require('grim');
 
+  PropertyAccessors = require('property-accessors');
+
   calculateSpecificity = require('./helpers').calculateSpecificity;
 
   module.exports = KeyBinding = (function() {
+    PropertyAccessors.includeInto(KeyBinding);
+
     KeyBinding.currentIndex = 1;
 
+    KeyBinding.prototype.accessor('keystroke', {
+      get: function() {
+        Grim.deprecate('Use KeyBinding.keystrokes instead');
+        return this.keystrokes;
+      },
+      set: function(value) {
+        Grim.deprecate('Use KeyBinding.keystrokes instead');
+        return this.keystrokes = value;
+      }
+    });
+
     KeyBinding.prototype.enabled = true;
@@ -17,14 +32,2 @@
       this.keystrokes = keystrokes;
-      this.__defineGetter__('keystroke', (function(_this) {
-        return function() {
-          Grim.deprecate("Use KeyBinding.keystrokes instead");
-          return _this.keystrokes;
-        };
-      })(this));
-      this.__defineSetter__('keystroke', (function(_this) {
-        return function(value) {
-          Grim.deprecate("Use KeyBinding.keystrokes instead");
-          return _this.keystrokes = value;
-        };
-      })(this));
       this.keystrokeCount = this.keystrokes.split(' ').length;
@@ -31,0 +34,0 @@ this.selector = selector.replace(/!important/g, '');

package.json

 {
   "name": "atom-keymap",
-  "version": "2.0.5",
+  "version": "2.0.6",
   "description": "Atom's DOM-aware keymap module",
@@ -32,3 +32,4 @@ "main": "./lib/keymap-manager",
     "emissary": "^1.1.0",
-    "underscore-plus": "^1.0.0"
+    "underscore-plus": "^1.0.0",
+    "property-accessors": "^1"
   },
@@ -35,0 +36,0 @@ "devDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

60230

increased by0.06%

Worsened metrics

Dependency count

10

increased by11.11%

Dependency changes

• + Addedproperty-accessors@^1