atom-keymap - npm Package Compare versions

Comparing version 5.1.7 to 5.1.8

api.json

@@ -6,3 +6,3 @@ {
       "filename": "src/keymap-manager.coffee",
-      "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L66",
+      "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L66",
       "sections": [
@@ -42,3 +42,3 @@ {
           "sectionName": "Class Methods",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L83",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L83",
           "visibility": "Public",
@@ -105,3 +105,3 @@ "summary": "Create a keydown DOM event for testing purposes.",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L107",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L107",
           "visibility": "Public",
@@ -130,3 +130,3 @@ "summary": "Create a new KeymapManager.",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L117",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L117",
           "visibility": "Public",
@@ -139,3 +139,3 @@ "summary": "Unwatch all watched paths. ",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L143",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L143",
           "visibility": "Public",
@@ -190,3 +190,3 @@ "summary": "Invoke the given callback when one or more keystrokes completely\nmatch a key binding.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L159",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L159",
           "visibility": "Public",
@@ -241,3 +241,3 @@ "summary": "Invoke the given callback when one or more keystrokes partially\nmatch a binding.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L173",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L173",
           "visibility": "Public",
@@ -286,3 +286,3 @@ "summary": "Invoke the given callback when one or more keystrokes fail to match\nany bindings.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L204",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L204",
           "visibility": "Public",
@@ -331,3 +331,3 @@ "summary": "Invoke the given callback when a keymap file not able to be loaded.",
           "sectionName": "Adding and Removing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L217",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L217",
           "visibility": "Public",
@@ -354,3 +354,3 @@ "summary": "Add sets of key bindings grouped by CSS selector.",
           "sectionName": "Accessing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L250",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L250",
           "visibility": "Public",
@@ -369,3 +369,3 @@ "summary": "Get all current key bindings.",
           "sectionName": "Accessing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L265",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L265",
           "visibility": "Public",
@@ -412,3 +412,3 @@ "summary": "Get the key bindings for a given command and optional target.",
           "sectionName": "Managing Keymap Files",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L300",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L300",
           "visibility": "Public",
@@ -443,3 +443,3 @@ "summary": "Load the key bindings from the given path.",
           "sectionName": "Managing Keymap Files",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L320",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L320",
           "visibility": "Public",
@@ -460,3 +460,3 @@ "summary": "Cause the keymap to reload the key bindings file at the given path\nwhenever it changes.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L392",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L392",
           "visibility": "Public",
@@ -477,3 +477,3 @@ "summary": "Dispatch a custom event associated with the matching key binding for\nthe given `KeyboardEvent` if one can be found.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L490",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L490",
           "visibility": "Public",
@@ -500,3 +500,3 @@ "summary": "Translate a keydown event to a keystroke string.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.7/src/keymap-manager.coffee#L497",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v5.1.8/src/keymap-manager.coffee#L497",
           "visibility": "Public",
@@ -503,0 +503,0 @@ "summary": "Get the number of milliseconds allowed before pending states caused\nby partial matches of multi-keystroke bindings are terminated.",

lib/keymap-manager.js

@@ -436,7 +436,10 @@ (function() {
       ignoreKeystrokes = new Set;
+      partialMatchCandidates.forEach(function(binding) {
+        if (binding.command === 'unset!') {
+          return ignoreKeystrokes.add(binding.keystrokes);
+        }
+      });
       while (partialMatchCandidates.length > 0 && (target != null) && target !== document) {
         partialMatchCandidates = partialMatchCandidates.filter(function(binding) {
-          if (binding.command === 'unset!') {
-            return ignoreKeystrokes.add(binding.keystrokes);
-          } else if (!ignoreKeystrokes.has(binding.keystrokes) && target.webkitMatchesSelector(binding.selector)) {
+          if (!ignoreKeystrokes.has(binding.keystrokes) && target.webkitMatchesSelector(binding.selector)) {
             partialMatches.push(binding);
@@ -443,0 +446,0 @@ return false;

package.json

 {
   "name": "atom-keymap",
-  "version": "5.1.7",
+  "version": "5.1.8",
   "description": "Atom's DOM-aware keymap module",
@@ -5,0 +5,0 @@ "main": "./lib/keymap-manager",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

59805

increased by0.11%

Lines of code

1481

increased by0.2%

No dependency changes