atom-keymap - npm Package Compare versions

Comparing version 6.1.0 to 6.1.1

api.json

@@ -6,3 +6,3 @@ {
       "filename": "src/keymap-manager.coffee",
-      "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L66",
+      "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L66",
       "sections": [
@@ -42,3 +42,3 @@ {
           "sectionName": "Class Methods",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L83",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L83",
           "visibility": "Public",
@@ -105,3 +105,3 @@ "summary": "Create a keydown DOM event for testing purposes.",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L107",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L107",
           "visibility": "Public",
@@ -130,3 +130,3 @@ "summary": "Create a new KeymapManager.",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L115",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L115",
           "visibility": "Public",
@@ -139,3 +139,3 @@ "summary": "Clear all registered key bindings and enqueued keystrokes. For use\nin tests. ",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L122",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L122",
           "visibility": "Public",
@@ -148,3 +148,3 @@ "summary": "Unwatch all watched paths. ",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L148",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L148",
           "visibility": "Public",
@@ -199,3 +199,3 @@ "summary": "Invoke the given callback when one or more keystrokes completely\nmatch a key binding.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L164",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L164",
           "visibility": "Public",
@@ -250,3 +250,3 @@ "summary": "Invoke the given callback when one or more keystrokes partially\nmatch a binding.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L178",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L178",
           "visibility": "Public",
@@ -295,3 +295,3 @@ "summary": "Invoke the given callback when one or more keystrokes fail to match\nany bindings.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L209",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L209",
           "visibility": "Public",
@@ -340,3 +340,3 @@ "summary": "Invoke the given callback when a keymap file not able to be loaded.",
           "sectionName": "Adding and Removing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L222",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L222",
           "visibility": "Public",
@@ -363,3 +363,3 @@ "summary": "Add sets of key bindings grouped by CSS selector.",
           "sectionName": "Accessing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L255",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L261",
           "visibility": "Public",
@@ -378,3 +378,3 @@ "summary": "Get all current key bindings.",
           "sectionName": "Accessing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L270",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L276",
           "visibility": "Public",
@@ -421,3 +421,3 @@ "summary": "Get the key bindings for a given command and optional target.",
           "sectionName": "Managing Keymap Files",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L305",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L311",
           "visibility": "Public",
@@ -452,3 +452,3 @@ "summary": "Load the key bindings from the given path.",
           "sectionName": "Managing Keymap Files",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L325",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L331",
           "visibility": "Public",
@@ -469,3 +469,3 @@ "summary": "Cause the keymap to reload the key bindings file at the given path\nwhenever it changes.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L397",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L403",
           "visibility": "Public",
@@ -486,3 +486,3 @@ "summary": "Dispatch a custom event associated with the matching key binding for\nthe given `KeyboardEvent` if one can be found.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L495",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L501",
           "visibility": "Public",
@@ -509,3 +509,3 @@ "summary": "Translate a keydown event to a keystroke string.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.0/src/keymap-manager.coffee#L502",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v6.1.1/src/keymap-manager.coffee#L508",
           "visibility": "Public",
@@ -512,0 +512,0 @@ "summary": "Get the number of milliseconds allowed before pending states caused\nby partial matches of multi-keystroke bindings are terminated.",

lib/keymap-manager.js

@@ -134,3 +134,3 @@ (function() {
     KeymapManager.prototype.add = function(source, keyBindingsBySelector) {
-      var addedKeyBindings, command, keyBinding, keyBindings, keystrokes, normalizedKeystrokes, selector;
+      var addedKeyBindings, command, keyBinding, keyBindings, keystrokes, normalizedKeystrokes, selector, _ref2;
       addedKeyBindings = [];
@@ -145,2 +145,7 @@ for (selector in keyBindingsBySelector) {
           command = keyBindings[keystrokes];
+          command = (_ref2 = command != null ? typeof command.toString === "function" ? command.toString() : void 0 : void 0) != null ? _ref2 : '';
+          if (command.length === 0) {
+            console.warn("Empty command for binding: `" + selector + "` `" + keystrokes + "` in " + source);
+            return;
+          }
           if (normalizedKeystrokes = normalizeKeystrokes(keystrokes)) {
@@ -147,0 +152,0 @@ keyBinding = new KeyBinding(source, command, normalizedKeystrokes, selector);

package.json

 {
   "name": "atom-keymap",
-  "version": "6.1.0",
+  "version": "6.1.1",
   "description": "Atom's DOM-aware keymap module",
@@ -18,8 +18,3 @@ "main": "./lib/keymap-manager",
   },
-  "licenses": [
-    {
-      "type": "MIT",
-      "url": "http://github.com/atom/atom-keymap/raw/master/LICENSE.md"
-    }
-  ],
+  "license": "MIT",
   "dependencies": {
@@ -26,0 +21,0 @@ "clear-cut": "^2",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

61366

increased by0.37%

Lines of code

1497

increased by0.34%

No dependency changes