atom-keymap - npm Package Compare versions

Comparing version 7.0.4-beta0 to 7.0.4

api.json

@@ -6,3 +6,3 @@ {
       "filename": "src/keymap-manager.coffee",
-      "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L66",
+      "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L66",
       "sections": [
@@ -42,3 +42,3 @@ {
           "sectionName": "Class Methods",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L83",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L83",
           "visibility": "Public",
@@ -105,3 +105,3 @@ "summary": "Create a keydown DOM event for testing purposes.",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L109",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L109",
           "visibility": "Public",
@@ -130,3 +130,3 @@ "summary": "Create a new KeymapManager.",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L117",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L117",
           "visibility": "Public",
@@ -139,3 +139,3 @@ "summary": "Clear all registered key bindings and enqueued keystrokes. For use\nin tests. ",
           "sectionName": "Construction and Destruction",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L125",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L125",
           "visibility": "Public",
@@ -148,3 +148,3 @@ "summary": "Unwatch all watched paths. ",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L151",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L151",
           "visibility": "Public",
@@ -199,3 +199,3 @@ "summary": "Invoke the given callback when one or more keystrokes completely\nmatch a key binding.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L167",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L167",
           "visibility": "Public",
@@ -250,3 +250,3 @@ "summary": "Invoke the given callback when one or more keystrokes partially\nmatch a binding.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L181",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L181",
           "visibility": "Public",
@@ -295,3 +295,3 @@ "summary": "Invoke the given callback when one or more keystrokes fail to match\nany bindings.",
           "sectionName": "Event Subscription",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L212",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L212",
           "visibility": "Public",
@@ -340,3 +340,3 @@ "summary": "Invoke the given callback when a keymap file not able to be loaded.",
           "sectionName": "Adding and Removing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L227",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L227",
           "visibility": "Public",
@@ -369,3 +369,3 @@ "summary": "Add sets of key bindings grouped by CSS selector.",
           "sectionName": "Accessing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L266",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L266",
           "visibility": "Public",
@@ -384,3 +384,3 @@ "summary": "Get all current key bindings.",
           "sectionName": "Accessing Bindings",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L281",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L281",
           "visibility": "Public",
@@ -427,3 +427,3 @@ "summary": "Get the key bindings for a given command and optional target.",
           "sectionName": "Managing Keymap Files",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L318",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L318",
           "visibility": "Public",
@@ -464,3 +464,3 @@ "summary": "Load the key bindings from the given path.",
           "sectionName": "Managing Keymap Files",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L341",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L341",
           "visibility": "Public",
@@ -495,3 +495,3 @@ "summary": "Cause the keymap to reload the key bindings file at the given path\nwhenever it changes.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L413",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L413",
           "visibility": "Public",
@@ -512,3 +512,3 @@ "summary": "Dispatch a custom event associated with the matching key binding for\nthe given `KeyboardEvent` if one can be found.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L625",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L625",
           "visibility": "Public",
@@ -535,3 +535,3 @@ "summary": "Translate a keydown event to a keystroke string.",
           "sectionName": "Managing Keyboard Events",
-          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4-beta0/src/keymap-manager.coffee#L632",
+          "srcUrl": "https://github.com/atom/atom-keymap/blob/v7.0.4/src/keymap-manager.coffee#L632",
           "visibility": "Public",
@@ -538,0 +538,0 @@ "summary": "Get the number of milliseconds allowed before pending states caused\nby partial matches of multi-keystroke bindings are terminated.",

lib/helpers.js

@@ -156,3 +156,3 @@ (function() {
   exports.keystrokeForKeyboardEvent = function(event) {
-    var altKey, characters, code, ctrlKey, isNonCharacterKey, key, keystroke, metaKey, nonAltModifiedKey, shiftKey, _ref, _ref1;
+    var altKey, characters, code, ctrlKey, isNonCharacterKey, key, keystroke, metaKey, nonAltModifiedKey, shiftKey, _ref;
     key = event.key, code = event.code, ctrlKey = event.ctrlKey, altKey = event.altKey, shiftKey = event.shiftKey, metaKey = event.metaKey;
@@ -181,12 +181,3 @@ if (key === 'Dead') {
     } else {
-      if (process.platform === 'linux' && ctrlKey) {
-        if (event.code && (characters = (_ref1 = KeyboardLayout.getCurrentKeymap()) != null ? _ref1[event.code] : void 0)) {
-          if (event.shiftKey && (characters.withShift != null)) {
-            key = characters.withShift;
-          } else if (characters.unmodified != null) {
-            key = characters.unmodified;
-          }
-        }
-      }
-      if (event.getModifierState('AltGraph')) {
+      if (altKey) {
         if (process.platform === 'darwin' && event.code) {
@@ -199,3 +190,3 @@ nonAltModifiedKey = nonAltModifiedKeyForKeyboardEvent(event);
           }
-        } else if (process.platform === 'win32' && event.code) {
+        } else if (process.platform === 'win32' && ctrlKey && event.code) {
           nonAltModifiedKey = nonAltModifiedKeyForKeyboardEvent(event);
@@ -209,9 +200,10 @@ if (metaKey) {
         } else if (process.platform === 'linux') {
-          nonAltModifiedKey = nonAltModifiedKeyForKeyboardEvent(event);
-          if ((ctrlKey || altKey || metaKey) && nonAltModifiedKey) {
-            key = nonAltModifiedKey;
-            altKey = event.getModifierState('AltGraph');
+          if (event.getModifierState('AltGraph')) {
+            altKey = false;
           }
         }
       }
+      if (!shiftKey) {
+        key = key.toLowerCase();
+      }
     }
@@ -218,0 +210,0 @@ if ((key.length === 1 && !isLatinCharacter(key)) || (metaKey && KeyboardLayout.getCurrentKeyboardLayout() === 'com.apple.keylayout.DVORAK-QWERTYCMD')) {

package.json

 {
   "name": "atom-keymap",
-  "version": "7.0.4-beta0",
+  "version": "7.0.4",
   "description": "Atom's DOM-aware keymap module",
@@ -30,3 +30,3 @@ "main": "./lib/keymap-manager",
     "grim": "^1.2.1",
-    "keyboard-layout": "^1.3.0",
+    "keyboard-layout": "1.2.2",
     "pathwatcher": "^6.2",
@@ -33,0 +33,0 @@ "property-accessors": "^1",

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

1

decreased by-50%

Worsened metrics

Total package byte prevSize

72672

decreased by-0.86%

Lines of code

1768

decreased by-0.45%

Dependency changes

• + Addedkeyboard-layout@1.2.2(transitive)

• - Removedkeyboard-layout@1.3.1(transitive)

• Updatedkeyboard-layout@1.2.2