aws2js - npm Package Compare versions

Comparing version 0.6.12 to 0.6.14

CHANGELOG.md

@@ -0,1 +1,8 @@
+## v0.6.14
+ * Fixes global variables leak [#33](https://github.com/SaltwaterC/aws2js/pull/33).
+
+## v0.6.13
+ * Fixes The DynamoDB JSON conversion that did not support UTF-8 chars [#30](https://github.com/SaltwaterC/aws2js/issues/30).
+ * Only strings and numbers are allowed to be a x-amz header value for the S3 API [#31](https://github.com/SaltwaterC/aws2js/pull/31). Prints a warning when things are unexpected. Most probably that's broken user input.
+
 ## v0.6.12
@@ -2,0 +9,0 @@ * Corrected URL module's alias from 'url' to 'u' [#28](https://github.com/SaltwaterC/aws2js/pull/28).

CONTRIBUTORS.md

@@ -13,1 +13,2 @@ ## aws2js contributors, in order of first contribution
  * [ske](https://github.com/ske) - corrected URL module's alias from 'url' to 'u'
+ * [Joe Roberts](https://github.com/zefer) - global variables leak fix

lib/aws.js

@@ -182,2 +182,4 @@ /* core modules */
 						var clientBody = JSON.stringify(query);
+						// unescapes the UTF-8 chars, see #30
+						clientBody = unescape(clientBody.replace(/\\u/g, '%u'));
 						var responseBodyHandler = 'json';
@@ -184,0 +186,0 @@ var signature = internals.signHeaders(config, clientHeaders, clientBody, now.toUTCString());

lib/internals.js

@@ -468,3 +468,8 @@ /* 3rd party module */
 		if (amzPrefix == 'x-amz') {
-			keys.push(key);
+			var type = typeof headers[key];
+			if (type === 'string' || type === 'number') {
+				keys.push(key);
+			} else {
+				console.error('Warning: the header %s has the %s value with the type %s. This may have unintended side effects.', key, headers[key], type);
+			}
 		}
@@ -475,3 +480,3 @@ }
 		var key = keys[n];
-		sorted[key] = headers[key].trim();
+		sorted[key] = String(headers[key]).trim();
 	}
@@ -478,0 +483,0 @@ for (var key in sorted) {

lib/tools.js

@@ -9,11 +9,8 @@ /**
 	var obj3 = {};
-
-	for(attrname in obj1) {
+	for (var attrname in obj1) {
 		obj3[attrname] = obj1[attrname];
 	}
-
-	for(attrname in obj2) {
+	for (var attrname in obj2) {
 		obj3[attrname] = obj2[attrname];
 	}
-
 	return obj3;
@@ -66,4 +63,4 @@ };
 var isEmpty = function (obj) {
-	for(var prop in obj) {
-		if(obj.hasOwnProperty(prop)) {
+	for (var prop in obj) {
+		if (obj.hasOwnProperty(prop)) {
 			return false;
@@ -70,0 +67,0 @@ }

package.json

 {
 	"name": "aws2js",
 	"main": "./lib/aws.js",
-	"version": "0.6.12",
+	"version": "0.6.14",
 	"description": "AWS (Amazon Web Services) APIs client implementation for node.js",
@@ -50,2 +50,6 @@ "dependencies": {
 			"url": "https://github.com/ske"
+		},
+		{
+			"name": "Joe Roberts",
+			"url": "https://github.com/zefer"
 		}
@@ -52,0 +56,0 @@ ],

README.md

@@ -1,2 +0,2 @@
-## About ![still maintained](http://stillmaintained.com/SaltwaterC/aws2js.png)
+## About
 
@@ -3,0 +3,0 @@ Amazon Web Services node.js module. Originally a fork of [aws-lib](https://github.com/livelycode/aws-lib/).

No alert changes

Improved metrics

Total package byte prevSize

107009

increased by0.85%

Lines of code

2814

increased by0.25%

No dependency changes