backbone-db - npm Package Compare versions

Comparing version 0.4.8 to 0.4.9

lib/db.js

@@ -134,3 +134,2 @@ var Backbone = require('backbone');
       this.createId(model, options, function (err, id) {
-        model.set(model.idAttribute, id);
         store(model);
@@ -234,8 +233,16 @@ });
 
-  createId: (function (id) {
-    return function (model, options, cb) {
-      debug('createId: ' + id);
-      cb(null, id++);
+ _createDefaultId: (function(id) {
+    return function(callback) {
+      debug('_createDefaultId');
+      callback(null, id++);
     };
   })(1),
+  createId: function (model, options, callback) {
+    debug('createId');
+    var createIdFn = model.createId ? model.createId : this._createDefaultId;
+    createIdFn(function (err, id) {
+      model.set(model.idAttribute, id);
+      callback(err);
+    });
+  },
 
@@ -242,0 +249,0 @@ inc: function (model, options, cb) {

package.json

 {
   "name": "backbone-db",
-  "version": "0.4.8",
+  "version": "0.4.9",
   "description": "Key-Value database storage interface, localStorage and in-process implementations",
@@ -5,0 +5,0 @@ "main": "index.js",

test/test.model.js

@@ -155,2 +155,15 @@ var assert = require('assert');
   });
+
+  it('should support custom createId function', function(t) {
+    var NM = this.Model.extend({
+      createId: function(cb) {
+        cb(null, 'test_id');
+      }
+    });
+    var m = new NM();
+    m.save(null, {success: function() {
+      assert.equal(m.id, 'test_id');
+      t();
+    }});
+  });
 };

No alert changes

Improved metrics

Total package byte prevSize

161042

increased by468.77%

Number of package files

23

increased by76.92%

Lines of code

859

increased by14.23%

No dependency changes