balena-request - npm Package Compare versions

Comparing version 11.0.3 to 11.0.4-node-fix-body-overwrite-432ee302c8c55e629f4915146d4d1c7388d6b01b

build/request.js

@@ -174,3 +174,9 @@ "use strict";
                 const body = yield utils.getBody(response, options.responseFormat);
-                response = Object.assign(Object.assign({}, response), { body });
+                // We have to use Object.defineProperty in order to overwrite the body property
+                // for node-fetch without losing all the other properties/methods
+                Object.defineProperty(response, 'body', {
+                    get() {
+                        return body;
+                    },
+                });
                 if (utils.isErrorCode(response.statusCode)) {
@@ -177,0 +183,0 @@ const responseError = utils.getErrorMessageFromResponse(response);

CHANGELOG.md

@@ -7,2 +7,7 @@ # Change Log
 
+# v11.0.4
+## (2020-07-14)
+
+* Fix body overwriting on nodejs [Pagan Gazzard]
+
 # v11.0.3
@@ -9,0 +14,0 @@ ## (2020-07-13)

lib/request.js

@@ -202,3 +202,9 @@ /*
 				const body = await utils.getBody(response, options.responseFormat);
-				response = { ...response, body };
+				// We have to use Object.defineProperty in order to overwrite the body property
+				// for node-fetch without losing all the other properties/methods
+				Object.defineProperty(response, 'body', {
+					get() {
+						return body;
+					},
+				});
 
@@ -205,0 +211,0 @@ if (utils.isErrorCode(response.statusCode)) {

package.json

 {
   "name": "balena-request",
-  "version": "11.0.3",
+  "version": "11.0.4-node-fix-body-overwrite-432ee302c8c55e629f4915146d4d1c7388d6b01b",
   "description": "Balena HTTP client",
@@ -5,0 +5,0 @@ "main": "build/request.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

166571

increased by0.54%

Lines of code

1870

increased by0.65%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

No dependency changes