beachball - npm Package Compare versions

Comparing version 1.12.1 to 1.12.2

CHANGELOG.json

@@ -5,3 +5,17 @@ {
     {
-      "date": "Tue, 27 Aug 2019 03:11:41 GMT",
+      "date": "Tue, 27 Aug 2019 17:44:26 GMT",
+      "tag": "beachball_v1.12.2",
+      "version": "1.12.2",
+      "comments": {
+        "patch": [
+          {
+            "comment": "make sure to bump the deps of monorepo packages of other packages even if the packages are private",
+            "author": "[e-mail]",
+            "commit": "f44c276e8e1d1dc350dd184d88f73f0ab31904f8"
+          }
+        ]
+      }
+    },
+    {
+      "date": "Tue, 27 Aug 2019 03:11:47 GMT",
       "tag": "beachball_v1.12.1",
@@ -8,0 +22,0 @@ "version": "1.12.1",

CHANGELOG.md

 # Change Log - beachball
 
-This log was last generated on Tue, 27 Aug 2019 03:11:41 GMT and should not be manually modified.
+This log was last generated on Tue, 27 Aug 2019 17:44:26 GMT and should not be manually modified.
 
+## 1.12.2
+Tue, 27 Aug 2019 17:44:26 GMT
+
+### Patches
+
+- make sure to bump the deps of monorepo packages of other packages even if the packages are private ([e-mail])
 ## 1.12.1
-Tue, 27 Aug 2019 03:11:41 GMT
+Tue, 27 Aug 2019 03:11:47 GMT
 
@@ -8,0 +14,0 @@ ### Patches

lib/__tests__/changelog.test.js

@@ -50,4 +50,4 @@ "use strict";
                     packageName: 'foo',
-                    type: 'patch'
-                }
+                    type: 'patch',
+                },
             }, repository.rootPath);
@@ -62,7 +62,7 @@ yield repository.commitChange('bar');
                     packageName: 'foo',
-                    type: 'patch'
-                }
+                    type: 'patch',
+                },
             }, repository.rootPath);
             // Gather all package info from package.json
-            const packageInfos = monorepo_1.getPublicPackageInfos(repository.rootPath);
+            const packageInfos = monorepo_1.getPackageInfos(repository.rootPath);
             changelog_1.writeChangelog(packageInfos, repository.rootPath);
@@ -69,0 +69,0 @@ const changelogFile = path_1.default.join(repository.rootPath, 'CHANGELOG.md');

lib/bump.js

@@ -18,3 +18,3 @@ "use strict";
     // Gather all package info from package.json
-    const packageInfos = monorepo_1.getPublicPackageInfos(cwd);
+    const packageInfos = monorepo_1.getPackageInfos(cwd);
     // Apply package.json version updates
@@ -24,3 +24,3 @@ Object.keys(packageChangeTypes).forEach(pkgName => {
         if (!info) {
-            console.log(`Unknown public package named "${pkgName}" detected from change files, skipping!`);
+            console.log(`Unknown package named "${pkgName}" detected from change files, skipping!`);
             return;
@@ -31,3 +31,4 @@ }
         const packageJson = JSON.parse(fs_1.default.readFileSync(packageJsonPath).toString());
-        if (changeType !== 'none') {
+        // Don't bump 'none' type or private packages
+        if (changeType !== 'none' && !packageJson.private) {
             packageJson.version = semver_1.default.inc(packageJson.version, changeType);
@@ -60,3 +61,3 @@ info.version = packageJson.version;
         packageChangeTypes,
-        packageInfos
+        packageInfos,
     };
@@ -63,0 +64,0 @@ }

lib/changefile.js

@@ -32,3 +32,3 @@ "use strict";
         const packageChangeInfo = {};
-        const packageInfos = monorepo_1.getPublicPackageInfos(cwd);
+        const packageInfos = monorepo_1.getPackageInfos(cwd);
         for (let pkg of changedPackages) {
@@ -35,0 +35,0 @@ console.log('');

lib/monorepo.d.ts

@@ -15,5 +15,5 @@ export interface PackageInfo {
 export declare function getAllPackages(cwd: string): string[];
-export declare function getPublicPackageInfos(cwd: string): {
+export declare function getPackageInfos(cwd: string): {
     [pkgName: string]: PackageInfo;
 };
 //# sourceMappingURL=monorepo.d.ts.map

lib/monorepo.js

@@ -11,3 +11,3 @@ "use strict";
 function getAllPackages(cwd) {
-    const infos = getPublicPackageInfos(cwd);
+    const infos = getPackageInfos(cwd);
     return Object.keys(infos);
@@ -23,7 +23,9 @@ }
         devDependencies: packageJson.devDependencies,
-        disallowedChangeTypes: packageJson.beachball && packageJson.beachball.disallowedChangeTypes ? packageJson.beachball.disallowedChangeTypes : [],
-        private: packageJson.private !== undefined ? packageJson.private : false
+        disallowedChangeTypes: packageJson.beachball && packageJson.beachball.disallowedChangeTypes
+            ? packageJson.beachball.disallowedChangeTypes
+            : [],
+        private: packageJson.private !== undefined ? packageJson.private : false,
     };
 }
-function getPublicPackageInfos(cwd) {
+function getPackageInfos(cwd) {
     const trackedFiles = git_1.listAllTrackedFiles(cwd);
@@ -36,6 +38,3 @@ const packageJsonFiles = trackedFiles.filter(file => path_1.default.basename(file) === 'package.json');
                 const packageJson = JSON.parse(fs_1.default.readFileSync(path_1.default.join(cwd, packageJsonPath), 'utf-8'));
-                let packageInfo = infoFromPackageJson(packageJson, packageJsonPath);
-                if (!packageInfo.private) {
-                    packageInfos[packageJson.name] = packageInfo;
-                }
+                packageInfos[packageJson.name] = infoFromPackageJson(packageJson, packageJsonPath);
             }
@@ -55,2 +54,2 @@ catch (e) {
 }
-exports.getPublicPackageInfos = getPublicPackageInfos;
+exports.getPackageInfos = getPackageInfos;

package.json

 {
   "name": "beachball",
-  "version": "1.12.1",
+  "version": "1.12.2",
   "repository": {
@@ -5,0 +5,0 @@ "type": "git",

src/__tests__/changelog.test.ts

@@ -10,3 +10,3 @@ import path from 'path';
 import { writeChangeFiles } from '../changefile';
-import { getPublicPackageInfos } from '../monorepo';
+import { getPackageInfos } from '../monorepo';
 
@@ -49,4 +49,4 @@ import unified from 'unified';
             packageName: 'foo',
-            type: 'patch'
-          }
+            type: 'patch',
+          },
         },
@@ -65,4 +65,4 @@ repository.rootPath
             packageName: 'foo',
-            type: 'patch'
-          }
+            type: 'patch',
+          },
         },
@@ -73,3 +73,3 @@ repository.rootPath
       // Gather all package info from package.json
-      const packageInfos = getPublicPackageInfos(repository.rootPath);
+      const packageInfos = getPackageInfos(repository.rootPath);
 
@@ -76,0 +76,0 @@ writeChangelog(packageInfos, repository.rootPath);

src/bump.ts

 import { findGitRoot } from './paths';
 import { getPackageChangeTypes } from './changefile';
-import { getPublicPackageInfos, PackageInfo } from './monorepo';
+import { getPackageInfos, PackageInfo } from './monorepo';
 import { writeChangelog } from './changelog';
@@ -20,3 +20,3 @@ import fs from 'fs';
   // Gather all package info from package.json
-  const packageInfos = getPublicPackageInfos(cwd);
+  const packageInfos = getPackageInfos(cwd);
 
@@ -28,3 +28,3 @@ // Apply package.json version updates
     if (!info) {
-      console.log(`Unknown public package named "${pkgName}" detected from change files, skipping!`);
+      console.log(`Unknown package named "${pkgName}" detected from change files, skipping!`);
       return;
@@ -37,3 +37,4 @@ }
 
-    if (changeType !== 'none') {
+    // Don't bump 'none' type or private packages
+    if (changeType !== 'none' && !packageJson.private) {
       packageJson.version = semver.inc(packageJson.version, changeType);
@@ -73,3 +74,3 @@ info.version = packageJson.version;
     packageChangeTypes,
-    packageInfos
+    packageInfos,
   };
@@ -76,0 +77,0 @@ }

src/changefile.ts

@@ -8,3 +8,3 @@ import { ChangeInfo, ChangeType } from './ChangeInfo';
 import prompts from 'prompts';
-import { getPublicPackageInfos } from './monorepo';
+import { getPackageInfos } from './monorepo';
 import { prerelease } from 'semver';
@@ -24,3 +24,3 @@ import { CliOptions } from './CliOptions';
 
-  const packageInfos = getPublicPackageInfos(cwd);
+  const packageInfos = getPackageInfos(cwd);
 
@@ -27,0 +27,0 @@ for (let pkg of changedPackages) {

src/monorepo.ts

@@ -21,3 +21,3 @@ import { findPackageRoot } from './paths';
 export function getAllPackages(cwd: string): string[] {
-  const infos = getPublicPackageInfos(cwd);
+  const infos = getPackageInfos(cwd);
   return Object.keys(infos);
@@ -44,8 +44,10 @@ }
     disallowedChangeTypes:
-      packageJson.beachball && packageJson.beachball.disallowedChangeTypes ? packageJson.beachball.disallowedChangeTypes : [],
-    private: packageJson.private !== undefined ? packageJson.private : false
+      packageJson.beachball && packageJson.beachball.disallowedChangeTypes
+        ? packageJson.beachball.disallowedChangeTypes
+        : [],
+    private: packageJson.private !== undefined ? packageJson.private : false,
   };
 }
 
-export function getPublicPackageInfos(cwd: string) {
+export function getPackageInfos(cwd: string) {
   const trackedFiles = listAllTrackedFiles(cwd);
@@ -60,7 +62,3 @@ const packageJsonFiles = trackedFiles.filter(file => path.basename(file) === 'package.json');
 
-        let packageInfo: PackageInfo = infoFromPackageJson(packageJson, packageJsonPath);
-
-        if (!packageInfo.private) {
-          packageInfos[packageJson.name] = packageInfo;
-        }
+        packageInfos[packageJson.name] = infoFromPackageJson(packageJson, packageJsonPath);
       } catch (e) {
@@ -67,0 +65,0 @@ // Pass, the package.json is invalid

No alert changes

Improved metrics

Total package byte prevSize

142376

increased by0.35%

Lines of code

3458

increased by0.41%

No dependency changes