bigkoa - npm Package Compare versions

Comparing version 0.1.9 to 0.1.10

package.json

 {
   "name": "bigkoa",
-  "version": "0.1.9",
+  "version": "0.1.10",
   "description": "",
@@ -20,2 +20,3 @@ "main": "src/index.js",
     "ejs": "^2.3.4",
+    "eslint": "^4.19.1",
     "ghooks": "^1.2.4",
@@ -33,3 +34,3 @@ "husky": "^0.14.3",
     "nunjucks": "^3.0.1",
-    "nyc": "^10.0.0",
+    "nyc": "^10.3.2",
     "open": "0.0.5",
@@ -36,0 +37,0 @@ "selenium-server": "^2.53.1",

src/BigViewBase.js

@@ -123,14 +123,16 @@ 'use strict'
     if (this.done) {
-      throw new Error(' Write data to Browser after bigview.dong = true.')
+      console.log(' Write data to Browser after bigview.dong = true.')
+      return
     }
     if (text && text.length > 0) {
       // write to Browser;
-      if (this.gzip) {
-        this.output.write(text, () => {
-          debug(`bigview gzip, text size is: ${text.length}`)
-          this.output.flush()
-        })
-      } else {
-        this.res.write(text)
-      }
+      this.res.write(text)
+      // if (this.gzip) {
+      //   this.output.write(text, () => {
+      //     debug(`bigview gzip, text size is: ${text.length}`)
+      //     this.output.flush()
+      //   })
+      // } else {
+      //   this.res.write(text)
+      // }
     }
@@ -137,0 +139,0 @@ }

src/index.js

@@ -94,7 +94,3 @@ 'use strict'
     // start with render error pagelet
-    this.renderPagelets()
-            .then(this.end.bind(this))
-            .catch(this.processError.bind(this))
-
-    return Promise.reject(new Error('interrupt， no need to continue!'))
+    return PROMISE_RESOLVE
   }
@@ -295,8 +291,8 @@
     debug('BigView end')
-    let self = this
+    const self = this
 
     // lifecycle self.after before res.end
-    return self.after().then(function () {
-      if (self.layout) {
-        self.res.end(Utils.end() + (self.endTagString || '\n</body>\n</html>'))
+    return this.after().then(() => {
+      if (this.layout) {
+        this.res.end(Utils.end() + (this.endTagString || '\n</body>\n</html>'))
       }
@@ -303,0 +299,0 @@ self.done = true

No alert changes

Improved metrics

Total package byte prevSize

255030

increased by0.36%

Worsened metrics

Dev dependency count

27

increased by3.85%

Lines of code

3027

decreased by-0.03%

No dependency changes