bitcoin - npm Package Compare versions

Comparing version 1.1.6 to 1.2.0

Changelog.md

 # node-bitcoin changelog
 
+## v1.2.0 (2012/04/25)
+* Submoduled testnet-box for running tests
+* err objects should all now be an instance of Error
+
 ## v1.1.6 (2012/04/11)
@@ -4,0 +8,0 @@ * New commands for bitcoin v0.6.0

lib/jsonrpc.js

@@ -62,2 +62,4 @@ var util = require('util');
       response.on('end', function() {
+        var err;
+        
         try {
@@ -67,25 +69,35 @@ var decoded = JSON.parse(buffer);
           if (response.statusCode !== 200) {
-            errback({
-              code: -32602, 
-              message: 'Invalid params, response status code: ' + response.statusCode
-            });
+            err = new Error('Invalid params, response status code: ' + response.statusCode);
+            err.code = -32602;
+            errback(err);
           } else {
-            errback({
-              code: -32603,
-              message: 'Problem parsing JSON response from server'
-            });
+            err = new Error('Problem parsing JSON response from server');
+            err.code = -32603;
+            errback(err);
           }
           return;
         }
-        if(decoded.hasOwnProperty('error') && decoded.error != null) {
-          if (errback)
-            errback(decoded.error);
-        } else if(decoded.hasOwnProperty('result')) {
-          if (callback)
+        
+        if (decoded.hasOwnProperty('error') && decoded.error != null) {
+          if (errback) {
+            err = new Error(decoded.error.message || '');
+            if (decoded.error.code) {
+              err.code = decoded.error.code;
+            }
+            errback(err);
+          }
+        } else if (decoded.hasOwnProperty('result')) {
+          if (callback) {
             callback(decoded.result);
+          }
+        } else {
+          if (errback) {
+            err = new Error(decoded.error.message || '');
+            if (decoded.error.code) {
+              err.code = decoded.error.code;
+            }
+            errback(err);
+          }
         }
-        else {
-          if (errback)
-            errback(decoded.error);
-        }
+        
       });
@@ -92,0 +104,0 @@ });

package.json

 {
   "name": "bitcoin",
   "description": "Communicate with bitcoind via JSON-RPC",
-  "version": "1.1.6",
+  "version": "1.2.0",
   "main": "./lib/bitcoin",
@@ -25,5 +25,5 @@ "keywords": [
   "scripts": {
-    "test": "node test/api.js"
+    "test": "make test"
   },
   "optionalDependencies": {}
 }

test/api.js

@@ -146,7 +146,6 @@ var path = require('path');
       },
-      'should create non-null err in callback': function(err, expectedValue) {
-        assert.deepEqual(err, {
-          code: -32601,
-          message: 'Method not found'
-        });
+      'should pass Error object in callback': function(err, expectedValue) {
+        assert.instanceOf(err, Error);
+        assert.equal(err.message, 'Method not found');
+        assert.equal(err.code, -32601);
         assert.equal(expectedValue, undefined);
@@ -172,4 +171,5 @@ },
       'and should be able to handle it': function(err, difficulty) {
-        assert.isNotNull(err);
-        assert.isObject(err);
+        assert.instanceOf(err, Error);
+        assert.equal(err.message, 'Invalid params, response status code: 401');
+        assert.equal(err.code, -32602);
         assert.equal(difficulty, undefined);
@@ -176,0 +176,0 @@ },

test/config.example.js

 module.exports = {
   host: 'localhost',
   port: 8332,
-  user: 'jb55',
-  pass: 'thisisthepassword'
+  user: 'admin1',
+  pass: '123'
 };

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

23774

increased by17.84%

Number of package files

22

increased by69.23%

Lines of code

522

increased by1.36%

Worsened metrics

Number of medium supply chain risk alerts

2

increased by100%

No dependency changes