bitmovin-player-ui - npm Package Compare versions

Comparing version 3.0.0 to 3.0.1

CHANGELOG.md

@@ -7,2 +7,8 @@ # Change Log
 
+## [3.0.1]
+
+### Fixed
+- Positioning of `SeekBar`/`VolumeSlider` markers improved
+- Crash of `UIManager.release` when player instance was already destroyed
+
 ## [3.0.0]
@@ -430,2 +436,3 @@
 
+[3.0.1]: https://github.com/bitmovin/bitmovin-player-ui/compare/v3.0.0...v3.0.1
 [3.0.0]: https://github.com/bitmovin/bitmovin-player-ui/compare/v2.18.0...v3.0.0
@@ -432,0 +439,0 @@ [2.18.0]: https://github.com/bitmovin/bitmovin-player-ui/compare/v2.17.1...v2.18.0

dist/js/framework/components/togglebutton.js

@@ -39,2 +39,3 @@ "use strict";
     ToggleButton.prototype.configure = function (player, uimanager) {
+        _super.prototype.configure.call(this, player, uimanager);
         var config = this.getConfig();
@@ -41,0 +42,0 @@ this.getDomElement().addClass(this.prefixCss(config.offClass));

dist/js/framework/components/volumeslider.js

@@ -72,2 +72,8 @@ "use strict";
         });
+        uimanager.onComponentShow.subscribe(function () {
+            _this.refreshPlaybackPosition();
+        });
+        uimanager.onComponentHide.subscribe(function () {
+            _this.refreshPlaybackPosition();
+        });
         // Init volume bar
@@ -74,0 +80,0 @@ volumeChangeHandler();

dist/js/framework/main.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.version = '3.0.0';
+exports.version = '3.0.1';
 // Management
@@ -5,0 +5,0 @@ var uimanager_1 = require("./uimanager");

dist/js/framework/uiconfig.d.ts

@@ -40,3 +40,3 @@ import { ErrorMessageMap, ErrorMessageTranslator } from './components/errormessageoverlay';
      * Specifies the container in the DOM into which the UI will be added. Can be a CSS selector string or a
-     * HTMLElement object. By default, the player figure will be used ({@link PlayerAPI#getFigure}).
+     * HTMLElement object. By default, the player container will be used ({@link PlayerAPI#getContainer}).
      */
@@ -43,0 +43,0 @@ container?: string | HTMLElement;

dist/js/framework/uimanager.js

@@ -690,2 +690,14 @@ "use strict";
     PlayerWrapper.prototype.clearEventHandlers = function () {
+        try {
+            // Call the player API to check if the instance is still valid or already destroyed.
+            // This can be any call throwing the PlayerAPINotAvailableError when the player instance is destroyed.
+            this.player.getSource();
+        }
+        catch (error) {
+            if (error instanceof this.player.exports.PlayerAPINotAvailableError) {
+                // We have detected that the player instance is already destroyed, so we clear the event handlers to avoid
+                // event handler unsubscription attempts (which would result in PlayerAPINotAvailableError errors).
+                this.eventHandlers = {};
+            }
+        }
         for (var eventType in this.eventHandlers) {
@@ -692,0 +704,0 @@ for (var _i = 0, _a = this.eventHandlers[eventType]; _i < _a.length; _i++) {

package.json

 {
   "name": "bitmovin-player-ui",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "description": "Bitmovin Player UI Framework",
@@ -5,0 +5,0 @@ "main": "./dist/js/framework/main.js",

src/ts/components/seekbar.ts

@@ -768,2 +768,3 @@ import {Component, ComponentConfig} from './component';
     }
+
     let style = this.config.vertical ?
@@ -770,0 +771,0 @@ // -ms-transform required for IE9

src/ts/components/togglebutton.ts

@@ -50,2 +50,3 @@ import {Button, ButtonConfig} from './button';
   configure(player: PlayerAPI, uimanager: UIInstanceManager): void {
+    super.configure(player, uimanager);
     const config = this.getConfig() as ToggleButtonConfig;
@@ -52,0 +53,0 @@ this.getDomElement().addClass(this.prefixCss(config.offClass));

src/ts/components/volumeslider.ts

@@ -81,2 +81,9 @@ import {SeekBar, SeekBarConfig} from './seekbar';
 
+    uimanager.onComponentShow.subscribe(() => {
+      this.refreshPlaybackPosition();
+    });
+    uimanager.onComponentHide.subscribe(() => {
+      this.refreshPlaybackPosition();
+    });
+
     // Init volume bar
@@ -83,0 +90,0 @@ volumeChangeHandler();

src/ts/uiconfig.ts

@@ -43,3 +43,3 @@ import { ErrorMessageMap, ErrorMessageTranslator } from './components/errormessageoverlay';
    * Specifies the container in the DOM into which the UI will be added. Can be a CSS selector string or a
-   * HTMLElement object. By default, the player figure will be used ({@link PlayerAPI#getFigure}).
+   * HTMLElement object. By default, the player container will be used ({@link PlayerAPI#getContainer}).
    */
@@ -46,0 +46,0 @@ container?: string | HTMLElement;

src/ts/uimanager.ts

@@ -821,2 +821,14 @@ import {UIContainer} from './components/uicontainer';
   clearEventHandlers(): void {
+    try {
+      // Call the player API to check if the instance is still valid or already destroyed.
+      // This can be any call throwing the PlayerAPINotAvailableError when the player instance is destroyed.
+      this.player.getSource();
+    } catch (error) {
+      if (error instanceof this.player.exports.PlayerAPINotAvailableError) {
+        // We have detected that the player instance is already destroyed, so we clear the event handlers to avoid
+        // event handler unsubscription attempts (which would result in PlayerAPINotAvailableError errors).
+        this.eventHandlers = {};
+      }
+    }
+
     for (let eventType in this.eventHandlers) {
@@ -823,0 +835,0 @@ for (let callback of this.eventHandlers[eventType]) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3572714

increased by0.18%

Lines of code

38421

increased by0.17%

No dependency changes