botbuilder-dialogs - npm Package Compare versions

Comparing version 4.9.2 to 4.9.3

lib/prompts/oauthPrompt.d.ts

@@ -150,3 +150,4 @@ /**
     private channelSupportsOAuthCard;
+    private channelRequiresSignInLink;
 }
 //# sourceMappingURL=oauthPrompt.d.ts.map

lib/prompts/oauthPrompt.js

@@ -253,3 +253,3 @@ "use strict";
                     }
-                    else {
+                    else if (!this.channelRequiresSignInLink(context.activity.channelId)) {
                         link = undefined;
@@ -346,3 +346,3 @@ }
                     if (!tokenExchangeResponse || !tokenExchangeResponse.token) {
-                        yield context.sendActivity(this.getTokenExchangeInvokeResponse(botbuilder_core_1.StatusCodes.CONFLICT, 'The bot is unable to exchange token. Proceed with regular login.'));
+                        yield context.sendActivity(this.getTokenExchangeInvokeResponse(botbuilder_core_1.StatusCodes.PRECONDITION_FAILED, 'The bot is unable to exchange token. Proceed with regular login.'));
                     }
@@ -428,3 +428,2 @@ else {
         switch (channelId) {
-            case botbuilder_core_1.Channels.Msteams:
             case botbuilder_core_1.Channels.Cortana:
@@ -438,4 +437,12 @@ case botbuilder_core_1.Channels.Skype:
     }
+    channelRequiresSignInLink(channelId) {
+        switch (channelId) {
+            case botbuilder_core_1.Channels.Msteams:
+                return true;
+            default:
+        }
+        return false;
+    }
 }
 exports.OAuthPrompt = OAuthPrompt;
 //# sourceMappingURL=oauthPrompt.js.map

package.json

@@ -5,3 +5,3 @@ {
   "description": "A dialog stack based conversation manager for Microsoft BotBuilder.",
-  "version": "4.9.2",
+  "version": "4.9.3",
   "license": "MIT",
@@ -29,3 +29,3 @@ "keywords": [
     "@types/node": "^10.12.18",
-    "botbuilder-core": "4.9.2",
+    "botbuilder-core": "4.9.3",
     "globalize": "^1.4.2"
@@ -48,3 +48,3 @@ },
     "clean": "erase /q /s .\\lib",
-    "set-version": "npm version --allow-same-version 4.9.2",
+    "set-version": "npm version --allow-same-version 4.9.3",
     "test": "tsc && nyc mocha tests/",
@@ -51,0 +51,0 @@ "test:compat": "api-extractor run --verbose"

src/prompts/oauthPrompt.ts

@@ -286,3 +286,3 @@ /**
                 }
-                else {
+                else if (!this.channelRequiresSignInLink(context.activity.channelId)){
                     link = undefined;
@@ -403,3 +403,3 @@ }
                     await context.sendActivity(this.getTokenExchangeInvokeResponse(
-                        StatusCodes.CONFLICT, 
+                        StatusCodes.PRECONDITION_FAILED, 
                         'The bot is unable to exchange token. Proceed with regular login.'));
@@ -497,3 +497,2 @@ } else {
         switch (channelId) {
-            case Channels.Msteams:
             case Channels.Cortana:
@@ -508,2 +507,12 @@ case Channels.Skype:
     }
+    
+    private channelRequiresSignInLink(channelId: string): boolean {
+        switch (channelId) {
+            case Channels.Msteams:
+                return true;
+            default:
+        }
+
+        return false;
+    }
 }
@@ -510,0 +519,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

938422

increased by0.08%

Lines of code

19233

increased by0.08%

Dependency changes

• + Addedbotbuilder-core@4.9.3(transitive)

• + Addedbotframework-schema@4.9.3(transitive)

• - Removedbotbuilder-core@4.9.2(transitive)

• - Removedbotframework-schema@4.9.2(transitive)

• Updatedbotbuilder-core@4.9.3