botframework-streaming - npm Package Compare versions

Comparing version 4.11.0-dev.20200902.4a95911 to 4.11.0-dev.20200902.edd2bfe

browser/index-browser.d.ts

@@ -15,3 +15,3 @@ /**
 export { SubscribableStream } from './subscribableStream';
-export { BrowserWebSocket, WebSocketClient, WebSocketServer } from './webSocket/index-browser';
+export { BrowserWebSocket, WebSocketClient } from './webSocket/index-browser';
 //# sourceMappingURL=index-browser.d.ts.map

browser/index-browser.js

@@ -25,3 +25,2 @@ "use strict";
 exports.WebSocketClient = index_browser_1.WebSocketClient;
-exports.WebSocketServer = index_browser_1.WebSocketServer;
 //# sourceMappingURL=index-browser.js.map

browser/utilities/index.d.ts

@@ -8,5 +8,3 @@ /**
  */
-export * from './doesGlobalFileReaderExist';
-export * from './doesGlobalWebSocketExist';
 export * from './protocol-base';
 //# sourceMappingURL=index.d.ts.map

browser/utilities/index.js

@@ -13,5 +13,3 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-__export(require("./doesGlobalFileReaderExist"));
-__export(require("./doesGlobalWebSocketExist"));
 __export(require("./protocol-base"));
 //# sourceMappingURL=index.js.map

browser/webSocket/browserWebSocket.js

@@ -38,18 +38,2 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-var utilities_1 = require("../utilities");
-var createWebSocket = function (url) {
-    if (!url) {
-        throw new TypeError('Unable to create WebSocket without url.');
-    }
-    if (utilities_1.doesGlobalWebSocketExist()) {
-        return new Function("return new WebSocket('" + url + "');")();
-    }
-    throw new ReferenceError('Unable to find global.WebSocket which is required for constructing a BrowserWebSocket.');
-};
-var createFileReader = function () {
-    if (utilities_1.doesGlobalFileReaderExist()) {
-        return new Function("return new FileReader();")();
-    }
-    throw new ReferenceError('Unable to find global.FileReader. Unable to create FileReader for BrowserWebSocket.');
-};
 var BrowserWebSocket = /** @class */ (function () {
@@ -76,3 +60,3 @@ /**
                 if (!this.webSocket) {
-                    this.webSocket = createWebSocket(serverAddress);
+                    this.webSocket = new WebSocket(serverAddress);
                 }
@@ -123,3 +107,3 @@ this.webSocket.onerror = function (e) {
         this.webSocket.onmessage = function (evt) {
-            var fileReader = createFileReader();
+            var fileReader = new FileReader();
             var queueEntry = { buffer: null };
@@ -126,0 +110,0 @@ packets.push(queueEntry);

browser/webSocket/index-browser.d.ts

@@ -9,5 +9,5 @@ /**
 export { BrowserWebSocket } from './browserWebSocket';
-export { WebSocketClient } from './webSocketClient';
-export { WebSocketServer } from './webSocketServer';
+export { WebSocketClient } from './browserWebSocketClient';
+/** @internal */
 export { WebSocketTransport } from './webSocketTransport';
 //# sourceMappingURL=index-browser.d.ts.map

browser/webSocket/index-browser.js

@@ -12,8 +12,7 @@ "use strict";
 exports.BrowserWebSocket = browserWebSocket_1.BrowserWebSocket;
-var webSocketClient_1 = require("./webSocketClient");
-exports.WebSocketClient = webSocketClient_1.WebSocketClient;
-var webSocketServer_1 = require("./webSocketServer");
-exports.WebSocketServer = webSocketServer_1.WebSocketServer;
+var browserWebSocketClient_1 = require("./browserWebSocketClient");
+exports.WebSocketClient = browserWebSocketClient_1.WebSocketClient;
+/** @internal */
 var webSocketTransport_1 = require("./webSocketTransport");
 exports.WebSocketTransport = webSocketTransport_1.WebSocketTransport;
 //# sourceMappingURL=index-browser.js.map

lib/index.d.ts

@@ -16,3 +16,3 @@ /**
 export { SubscribableStream } from './subscribableStream';
-export { BrowserWebSocket, NodeWebSocket, NodeWebSocketFactory, NodeWebSocketFactoryBase, WebSocketClient, WebSocketServer } from './webSocket';
+export { NodeWebSocket, NodeWebSocketFactory, NodeWebSocketFactoryBase, WebSocketClient, WebSocketServer } from './webSocket';
 //# sourceMappingURL=index.d.ts.map

lib/index.js

@@ -26,3 +26,2 @@ "use strict";
 var webSocket_1 = require("./webSocket");
-exports.BrowserWebSocket = webSocket_1.BrowserWebSocket;
 exports.NodeWebSocket = webSocket_1.NodeWebSocket;
@@ -29,0 +28,0 @@ exports.NodeWebSocketFactory = webSocket_1.NodeWebSocketFactory;

lib/utilities/index.d.ts

@@ -8,5 +8,3 @@ /**
  */
-export * from './doesGlobalFileReaderExist';
-export * from './doesGlobalWebSocketExist';
 export * from './protocol-base';
 //# sourceMappingURL=index.d.ts.map

lib/utilities/index.js

@@ -13,5 +13,3 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-__export(require("./doesGlobalFileReaderExist"));
-__export(require("./doesGlobalWebSocketExist"));
 __export(require("./protocol-base"));
 //# sourceMappingURL=index.js.map

lib/webSocket/index.d.ts

@@ -8,8 +8,8 @@ /**
  */
-export * from './browserWebSocket';
-export * from './factories';
-export * from './nodeWebSocket';
-export * from './webSocketClient';
-export * from './webSocketServer';
-export * from './webSocketTransport';
+export { NodeWebSocketFactory, NodeWebSocketFactoryBase } from './factories';
+export { NodeWebSocket } from './nodeWebSocket';
+export { WebSocketClient } from './nodeWebSocketClient';
+export { WebSocketServer } from './webSocketServer';
+/** @internal */
+export { WebSocketTransport } from './webSocketTransport';
 //# sourceMappingURL=index.d.ts.map

lib/webSocket/index.js

@@ -9,12 +9,15 @@ "use strict";
  */
-function __export(m) {
-    for (var p in m) if (!exports.hasOwnProperty(p)) exports[p] = m[p];
-}
 Object.defineProperty(exports, "__esModule", { value: true });
-__export(require("./browserWebSocket"));
-__export(require("./factories"));
-__export(require("./nodeWebSocket"));
-__export(require("./webSocketClient"));
-__export(require("./webSocketServer"));
-__export(require("./webSocketTransport"));
+var factories_1 = require("./factories");
+exports.NodeWebSocketFactory = factories_1.NodeWebSocketFactory;
+exports.NodeWebSocketFactoryBase = factories_1.NodeWebSocketFactoryBase;
+var nodeWebSocket_1 = require("./nodeWebSocket");
+exports.NodeWebSocket = nodeWebSocket_1.NodeWebSocket;
+var nodeWebSocketClient_1 = require("./nodeWebSocketClient");
+exports.WebSocketClient = nodeWebSocketClient_1.WebSocketClient;
+var webSocketServer_1 = require("./webSocketServer");
+exports.WebSocketServer = webSocketServer_1.WebSocketServer;
+/** @internal */
+var webSocketTransport_1 = require("./webSocketTransport");
+exports.WebSocketTransport = webSocketTransport_1.WebSocketTransport;
 //# sourceMappingURL=index.js.map

package.json

@@ -5,3 +5,3 @@ {
   "description": "Streaming library for the Microsoft Bot Framework",
-  "version": "4.11.0-dev.20200902.4a95911",
+  "version": "4.11.0-dev.20200902.edd2bfe",
   "license": "MIT",
@@ -49,6 +49,6 @@ "keywords": [
     "build:rollup": "npm run clean && npm run build && api-extractor run --verbose --local",
-    "clean": "erase /q /s .\\lib .\\browser",
+    "clean": "rmdir /q /s lib browser",
     "eslint": "eslint  ./src/*.ts ./src/**/*.ts",
     "eslint-fix": "eslint  ./src/*.ts ./src/**/*.ts --fix",
-    "set-version": "npm version --allow-same-version 4.11.0-dev.20200902.4a95911",
+    "set-version": "npm version --allow-same-version 4.11.0-dev.20200902.edd2bfe",
     "test": "npm run build && nyc mocha tests/",
@@ -55,0 +55,0 @@ "test:compat": "api-extractor run --verbose"

src/index-browser.ts

@@ -27,4 +27,3 @@ /**
     BrowserWebSocket,
-    WebSocketClient,
-    WebSocketServer
+    WebSocketClient
 } from './webSocket/index-browser';

src/index.ts

@@ -27,3 +27,2 @@ /**
 export {
-    BrowserWebSocket,
     NodeWebSocket,
@@ -30,0 +29,0 @@ NodeWebSocketFactory,

src/utilities/index.ts

@@ -9,4 +9,2 @@ /**
 
-export * from './doesGlobalFileReaderExist';
-export * from './doesGlobalWebSocketExist';
 export * from './protocol-base';

src/webSocket/browserWebSocket.ts

@@ -9,21 +9,3 @@ /**
 import { IBrowserFileReader, IBrowserWebSocket, ISocket, INodeBuffer } from '../interfaces';
-import { doesGlobalFileReaderExist, doesGlobalWebSocketExist } from '../utilities';
 
-const createWebSocket = function(url: string): IBrowserWebSocket {
-    if (!url) {
-        throw new TypeError('Unable to create WebSocket without url.');
-    }
-    if (doesGlobalWebSocketExist()) {
-        return new Function(`return new WebSocket('${ url }');`)();
-    }
-    throw new ReferenceError('Unable to find global.WebSocket which is required for constructing a BrowserWebSocket.');
-};
-
-const createFileReader = function(): IBrowserFileReader {
-    if (doesGlobalFileReaderExist()) {
-        return new Function(`return new FileReader();`)();
-    }
-    throw new ReferenceError('Unable to find global.FileReader. Unable to create FileReader for BrowserWebSocket.');
-};
-
 export class BrowserWebSocket implements ISocket {
@@ -53,3 +35,3 @@ private webSocket: IBrowserWebSocket;
         if (!this.webSocket) {
-            this.webSocket = createWebSocket(serverAddress);
+            this.webSocket = new WebSocket(serverAddress);
         }
@@ -100,9 +82,9 @@
         const bufferKey: string = 'buffer';
-        let packets = [];
+        const packets = [];
         this.webSocket.onmessage = (evt): void => {
-            let fileReader = createFileReader();
-            let queueEntry = {buffer: null};
+            const fileReader = new FileReader();
+            const queueEntry = { buffer: null };
             packets.push(queueEntry);
             fileReader.onload = (e): void => {
-                let t = e.target as IBrowserFileReader;
+                const t = e.target as unknown as IBrowserFileReader;
                 queueEntry[bufferKey] = t.result;
@@ -109,0 +91,0 @@ if (packets[0] === queueEntry) {

src/webSocket/index-browser.ts

@@ -10,4 +10,4 @@ /**
 export { BrowserWebSocket } from './browserWebSocket';
-export { WebSocketClient } from './webSocketClient';
-export { WebSocketServer } from './webSocketServer';
+export { WebSocketClient } from './browserWebSocketClient';
+/** @internal */
 export { WebSocketTransport } from './webSocketTransport';

src/webSocket/index.ts

@@ -9,7 +9,7 @@ /**
 
-export * from './browserWebSocket';
-export * from './factories';
-export * from './nodeWebSocket';
-export * from './webSocketClient';
-export * from './webSocketServer';
-export * from './webSocketTransport';
+export { NodeWebSocketFactory, NodeWebSocketFactoryBase } from './factories';
+export { NodeWebSocket } from './nodeWebSocket';
+export { WebSocketClient } from './nodeWebSocketClient';
+export { WebSocketServer } from './webSocketServer';
+/** @internal */
+export { WebSocketTransport } from './webSocketTransport';

Fixed alerts

Uses eval

Supply chain risk

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

4

decreased by-55.56%

Worsened metrics

Total package byte prevSize

650308

decreased by-5.52%

Number of package files

590

decreased by-5.9%

Lines of code

11269

decreased by-5.37%

No dependency changes