bpmux - npm Package Compare versions

Comparing version 8.0.2 to 8.0.3

index.js

@@ -396,25 +396,19 @@ /**
     }
-    this.on('finish', finish);
+    this.once('finish', finish);
 
-    function end()
+    this.once('close', function ()
     {
-        this._ended = true;
-        this._check_remove();
-    }
-    this.on('end', end);
-
-    this.on('close', function ()
-    {
-        var was_finished = this._finished;
-        this._finished = true;
-        this._ended = true;
         this.removeListener('finish', finish);
-        this.removeListener('end', end);
-        if (!was_finished)
+        if (!this._finished)
         {
+            this._finished = true;
             this._mux._send_end(this);
         }
-        // Don't call _check_remove because this may be due to a local
-        // destroy and so data may still come from peer (but be ignored
-        // because we don't push to destroyed streams).
+        if (this._ended)
+        {
+            this._check_remove();
+        }
+        // Don't call _check_remove if not ended because the close event may be
+        // due to a local destroy and so data may still come from the peer
+        // (but be ignored because we don't push to destroyed streams).
         // Duplex will be removed when TYPE_END is received.
@@ -595,2 +589,3 @@ });
             {
+                duplex._ended = true; // we won't get any more messages for it
                 duplex.destroy(new Error('carrier stream ended before end message received'));
@@ -597,0 +592,0 @@ }

package.json

 {
   "name": "bpmux",
   "description": "Node stream multiplexing with back-pressure on each stream",
-  "version": "8.0.2",
+  "version": "8.0.3",
   "homepage": "https://github.com/davedoesdev/bpmux",
@@ -6,0 +6,0 @@ "author": {

test/fixtures/nw/loader.js

@@ -23,2 +23,7 @@ const util = require('util');
 
+window.onerror = function (message, source, lineno, colno, err)
+{
+    done(err);
+};
+
 console.log = function ()
@@ -25,0 +30,0 @@ {

No alert changes

Improved metrics

Lines of code

5073

increased by0.28%

Worsened metrics

Total package byte prevSize

527054

decreased by-0.01%

No dependency changes