broccoli - npm Package Compare versions

Comparing version 1.0.0-beta.5 to 1.0.0-beta.6

CHANGELOG.md

 # master
 
+# 1.0.0-beta.6
+
+* Add `build` event to watcher
+
 # 1.0.0-beta.5
@@ -4,0 +8,0 @@

lib/builder.js

@@ -15,2 +15,7 @@ 'use strict'
 
+// For an explanation and reference of the API that we use to communicate with
+// nodes (__broccoliFeatures__ and __broccoliGetInfo__), see
+// https://github.com/broccolijs/broccoli/blob/master/docs/node-api.md
+
+
 // Build a graph of nodes, referenced by its final output node. Example:
@@ -222,5 +227,2 @@ //
 //
-// Note that feature flags are not independent; every feature flag requires
-// the earlier flags to be set as well.
-//
 // Add new features to the bottom of the list.
@@ -227,0 +229,0 @@ var augmenters = [

lib/watcher.js

@@ -59,2 +59,3 @@ 'use strict'
       this.initialBuildStarted = true
+      this.trigger('build')
       this.currentBuild = this.builder.build()
@@ -61,0 +62,0 @@ this.currentBuild

package.json

 {
   "name": "broccoli",
   "description": "Fast client-side asset builder",
-  "version": "1.0.0-beta.5",
+  "version": "1.0.0-beta.6",
   "author": "Jo Liss <[e-mail]>",
@@ -29,3 +29,3 @@ "main": "lib/index.js",
     "findup-sync": "^0.2.1",
-    "handlebars": "^3.0.1",
+    "handlebars": "^4.0.4",
     "mime": "^1.2.11",
@@ -44,3 +44,3 @@ "rimraf": "^2.4.3",
     "mocha-jshint": "^2.2.5",
-    "multidep": "^1.0.1",
+    "multidep": "^2.0.0",
     "sinon": "^1.17.1",
@@ -54,5 +54,5 @@ "sinon-chai": "^2.8.0",
   "scripts": {
-    "pretest": "multidep test/multidep.json",
+    "postinstall": "multidep test/multidep.json",
     "test": "mocha"
   }
 }

test/builder_test.js

@@ -16,6 +16,6 @@ 'use strict'
 var sinonChai = require('sinon-chai'); chai.use(sinonChai)
-var multidepPackages = require('multidep')('test/multidep.json')
+var multidepRequire = require('multidep')('test/multidep.json')
 
-var Plugin = multidepPackages['broccoli-plugin']['1.2.0']()
-var broccoliSource = multidepPackages['broccoli-source']['1.1.0']()
+var Plugin = multidepRequire('broccoli-plugin', '1.2.0')
+var broccoliSource = multidepRequire('broccoli-source', '1.1.0')
 
@@ -76,3 +76,3 @@ // Clean up left-over temporary directories on uncaught exception.
   describe('broccoli-plugin nodes (nodeType: "transform")', function() {
-    multidepPackages['broccoli-plugin'].forEachVersion(function(version, Plugin) {
+    multidepRequire.forEachVersion('broccoli-plugin', function(version, Plugin) {
       var plugins = makePlugins(Plugin)
@@ -142,3 +142,3 @@
     describe('persistentOutput flag', function() {
-      multidepPackages['broccoli-plugin'].forEachVersion(function(version, Plugin) {
+      multidepRequire.forEachVersion('broccoli-plugin', function(version, Plugin) {
         if (version === '1.0.0') return // continue
@@ -185,3 +185,3 @@
   describe('broccoli-source nodes (nodeType: "source") and strings', function() {
-    multidepPackages['broccoli-source'].forEachVersion(function(version, broccoliSource) {
+    multidepRequire.forEachVersion('broccoli-source', function(version, broccoliSource) {
       describe('broccoli-source ' + version, function() {
@@ -364,3 +364,3 @@ it('records unwatched source directories', function() {
   describe('failing node build', function() {
-    multidepPackages['broccoli-plugin'].forEachVersion(function(version, Plugin) {
+    multidepRequire.forEachVersion('broccoli-plugin', function(version, Plugin) {
       var plugins = makePlugins(Plugin)
@@ -367,0 +367,0 @@

test/watcher_test_suite.js

@@ -172,10 +172,16 @@ 'use strict'
     describe('events', function() {
-      var changeEventHasTriggered, errorEventHasTriggered
+      var buildEventHasTriggered, changeEventHasTriggered, errorEventHasTriggered
 
       function buildAndRecordEvents(errOrNull) {
-        changeEventHasTriggered = errorEventHasTriggered = false
+        buildEventHasTriggered = false
+        changeEventHasTriggered = false
+        errorEventHasTriggered = false
 
         var node = new plugins.AsyncPlugin
-        setUpBuilderAndWatcher(node)
+        builder = new Builder(node)
+        watcher = new Watcher(builder)
 
+        watcher.on('build', function() {
+          buildEventHasTriggered = true
+        })
         watcher.on('change', function() {
@@ -188,5 +194,8 @@ changeEventHasTriggered = true
 
+        watcher.watch()
+
         return node.buildStarted
           .then(sleep)
           .then(function() {
+            expect(buildEventHasTriggered).to.be.true
             expect(changeEventHasTriggered).to.be.false
@@ -193,0 +202,0 @@ expect(errorEventHasTriggered).to.be.false

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Install scripts

Supply chain risk

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

131517

increased by12.59%

Number of package files

32

increased by3.23%

Lines of code

1737

increased by0.52%

Worsened metrics

Number of high supply chain risk alerts

1

increased byInfinity%

Dependency changes

• + Addedhandlebars@4.7.8(transitive)

• + Addedneo-async@2.6.2(transitive)

• + Addedsource-map@0.6.1(transitive)

• + Addeduglify-js@3.19.3(transitive)

• + Addedwordwrap@1.0.0(transitive)

• - Removedalign-text@0.1.4(transitive)

• - Removedamdefine@1.0.1(transitive)

• - Removedcamelcase@1.2.1(transitive)

• - Removedcenter-align@0.1.3(transitive)

• - Removedcliui@2.1.0(transitive)

• - Removeddecamelize@1.2.0(transitive)

• - Removedhandlebars@3.0.8(transitive)

• - Removedis-buffer@1.1.6(transitive)

• - Removedkind-of@3.2.2(transitive)

• - Removedlazy-cache@1.0.4(transitive)

• - Removedlongest@1.0.1(transitive)

• - Removedminimist@0.0.10(transitive)

• - Removedoptimist@0.6.1(transitive)

• - Removedrepeat-string@1.6.1(transitive)

• - Removedright-align@0.1.3(transitive)

• - Removedsource-map@0.1.430.5.7(transitive)

• - Removeduglify-js@2.8.29(transitive)

• - Removeduglify-to-browserify@1.0.2(transitive)

• - Removedwindow-size@0.1.0(transitive)

• - Removedwordwrap@0.0.20.0.3(transitive)

• - Removedyargs@3.10.0(transitive)

• Updatedhandlebars@^4.0.4