browser-monkey - npm Package Compare versions

Comparing version 1.25.0 to 1.26.0

dispatchEvent.js

@@ -0,0 +0,0 @@ module.exports = function dispatchEvent(el, type){

index.js

@@ -77,17 +77,3 @@ var retry = require('trytryagain');
 
-function elementFinder(css) {
-  return {
-    find: function(element) {
-      var els = $(element).find(css);
-      if (els.length > 0) {
-        return els;
-      }
-    },
 
-    toString: function() {
-      return css;
-    }
-  };
-}
-
 function assertElementProperties(elements, expected, getProperty, exact) {
@@ -221,5 +207,46 @@ function assertion(actual, expected) {
   this.finders = finders || [];
+  this.options = options || { visibleOnly: true };
   this.handlers = [];
 }
 
+Selector.prototype.set = function(options){
+  var self = this;
+  Object.keys(options).forEach(function(key){
+    self.options[key] = options[key];
+  });
+  return this;
+}
+
+Selector.prototype.get = function(key){
+  return this.options[key];
+}
+
+function filterInvisible(index){
+  var el = this[index] || this;
+  var ignoreVisibilityOfTags = ['OPTION'];
+  if (el && ignoreVisibilityOfTags.indexOf(el.tagName) !== -1) {
+    el = el.parentNode;
+  }
+  return $(el).is(':visible');
+}
+
+Selector.prototype.elementFinder = function(css) {
+  var self = this;
+  return {
+    find: function(element) {
+      var els = $(element).find(css);
+      if (self.get('visibleOnly')) {
+        els = els.filter(filterInvisible);
+      }
+      if (els.length > 0) {
+        return els;
+      }
+    },
+
+    toString: function() {
+      return css;
+    }
+  };
+}
+
 Selector.prototype.clone = function (extension) {
@@ -262,3 +289,3 @@ var clone = new this.constructor();
   var message = JSON.stringify(options);
-  var scope = this.addFinder(elementFinder(selector));
+  var scope = this.addFinder(this.elementFinder(selector));
 
@@ -312,3 +339,3 @@ if (options) {
   var message = options && JSON.stringify(options);
-  var findElements = elementFinder(selector);
+  var findElements = this.elementFinder(selector);
   var finder;
@@ -594,4 +621,5 @@
 function inferField(component, field){
+  var ignoreActions = {constructor: true, options: true};
   for (var action in component) {
-    if (field[action] && action !== 'constructor'){
+    if (field[action] && !ignoreActions[action]){
       var newField = {
@@ -598,0 +626,0 @@ name: field[action],

karma.conf.js

@@ -0,0 +0,0 @@ // Karma configuration

package.json

 {
   "name": "browser-monkey",
-  "version": "1.25.0",
+  "version": "1.26.0",
   "description": "reliable dom testing",
@@ -5,0 +5,0 @@ "main": "index.js",

readme.md

@@ -0,0 +0,0 @@ # browser monkey

sendclick.js

@@ -0,0 +0,0 @@ var dispatchEvent = require('./dispatchEvent');

sendkeys.js

@@ -0,0 +0,0 @@ function dispatchEvent(el, type, char) {

test/browserMonkeySpec.js

@@ -93,4 +93,32 @@ require('lie/polyfill');
     });
+
+    describe('visibility', function(){
+      it('should not find an element that is visually hidden', function(){
+        insertHtml('<div class="element">hello <span style="display:none;">world</span></div>');
+
+        return browser.find('.element > span').shouldNotExist();
+      });
+
+      it('should find an element that is visually hidden when visibleOnly = false', function(){
+        insertHtml('<div class="element">hello <span style="display:none;">world</span></div>');
+
+        return browser.set({visibleOnly: false}).find('.element > span').shouldExist();
+      });
+
+      it('should find elements that are visually hidden because of how html renders them', function(){
+        insertHtml('<select><option>First</option><option>Second</option></select>');
+        return browser.find('select option').shouldHave({text: ['First', 'Second']});
+      });
+    });
   });
 
+  describe('set option', function(){
+    it('can set an option that is inerhited by components', function(){
+      var parentComponent = browser.find('div').component({});
+      parentComponent.set({myOption: 'abc'});
+      var childComponent = parentComponent.find('div').component({});
+      expect(childComponent.get('myOption')).to.equal('abc');
+    });
+  });
+
   describe('is', function () {
@@ -97,0 +125,0 @@ it('should eventually find an element if it has a class', function () {

test/createTestDiv.js

@@ -0,0 +0,0 @@ module.exports = function() {

test/sendclickSpec.js

@@ -0,0 +0,0 @@ var createTestDiv = require('./createTestDiv');

test/traceSpec.js

@@ -0,0 +0,0 @@ var trace = require('../trace');

trace.js

@@ -0,0 +0,0 @@ module.exports = function(promise) {

No alert changes

Improved metrics

Total package byte prevSize

79027

increased by6.01%

Lines of code

1632

increased by2.9%

No dependency changes