browser-monkey - npm Package Compare versions

Comparing version 1.29.0 to 1.29.1

actions.js

@@ -35,26 +35,17 @@ var debug = require('debug')('browser-monkey');
 
-    return self.element(options).then(function(element) {
-      if ($(element).is('select')) {
-        return self.find('option', selectOptions).elements().then(function(optionElements) {
-          var optionElement = optionElements[0];
-          if (optionElements.length > 1) {
-            console.warn('More than one element matched your criteria, we have selected the first match');
-          }
-          optionElement.selected = true;
-          var selectElement = optionElement.parentNode;
+    return self.is('select').find('option', selectOptions).elements(options).then(function(optionElements) {
+      var optionElement = optionElements[0];
+      optionElement.selected = true;
+      var selectElement = optionElement.parentNode;
 
-          debug('select', selectElement);
-          self.handleEvent({
-            type: 'select option',
-            value: optionElement.value,
-            element: selectElement,
-            optionElement: optionElement
-          });
+      debug('select', selectElement);
+      self.handleEvent({
+        type: 'select option',
+        value: optionElement.value,
+        element: selectElement,
+        optionElement: optionElement
+      });
 
-          blurActiveElement();
-          dispatchEvent(selectElement, 'change');
-        });
-      } else {
-        throw new Error('Cannot select from a ' + element.tagName);
-      }
+      blurActiveElement();
+      dispatchEvent(selectElement, 'change');
     });
@@ -61,0 +52,0 @@ },

package.json

 {
   "name": "browser-monkey",
-  "version": "1.29.0",
+  "version": "1.29.1",
   "description": "reliable dom testing",
@@ -5,0 +5,0 @@ "main": "index.js",

test/actionsSpec.js

@@ -89,3 +89,2 @@ var browser = require('..');
         var promise = browser.find('.element').select({text: 'Second', timeout: 100});
-        var selectedItem = undefined;
 
@@ -177,3 +176,3 @@ dom.eventuallyInsert(
         dom.eventuallyInsert('<div class="element"></div>');
-        return expect(promise).to.be.rejectedWith('Cannot select from a DIV');
+        return expect(promise).to.be.rejectedWith('to have css select');
       });
@@ -180,0 +179,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

86339

decreased by-13.99%

Number of package files

30

decreased by-6.25%

Lines of code

1851

decreased by-19.49%

No dependency changes