cache-service - npm Package Compare versions

Comparing version 0.2.7 to 0.2.8

modules/cacheModules/nodeCacheModule.js

@@ -61,3 +61,3 @@ var cacheModule = require('./cacheModule');
       	}
-      	this.db.set(key, obj[key], tempExpiration);
+      	this.db.set(key, value, tempExpiration);
       }
@@ -64,0 +64,0 @@ }

modules/cacheService.js

@@ -87,2 +87,3 @@ var cacheCollection = require('./cacheCollection');
       if(index + 1 === self.cacheCollection.preApi.length){
+        returnResponse = response;
         finish(successIndex);
@@ -89,0 +90,0 @@ }

package.json

 {
   "name": "cache-service",
-  "version": "0.2.7",
+  "version": "0.2.8",
   "description": "A tiered caching solution for node.",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -301,2 +301,2 @@ # cache-service
 * Add cache module interface documentation and examples
-* Make `.mset()` and `.mget()` provide the same callback params from both redisCacheModule and nodeCacheModule
+* ~~Make `.mset()` and `.mget()` provide the same callback params from both redisCacheModule and nodeCacheModule~~ (decided against this so standalone redisCacheModule usage is more robust)

test/server/cache-service.js

@@ -45,2 +45,72 @@ // Possible better redis mocks to use in the future
   });
+
+  it('.mset(obj), .mget(array) (exact key match)', function (done) {
+    cacheService.mset({key: value, 'key2': 'value2', 'key3': 'value3'});
+    cacheService.mget([key, 'key2', 'key3'], function (err, response){
+      expect(response.key).toBe('value');
+      expect(response.key2).toBe('value2');
+      expect(response.key3).toBe('value3');
+      done();
+    });
+  });
+
+  it('.mset(obj), .mget(array) (not exact key match)', function (done) {
+    cacheService.mset({key: value, 'key2': 'value2', 'key3': 'value3'});
+    cacheService.mget([key, 'key2', 'key3', 'key4'], function (err, response){
+      expect(response.key).toBe('value');
+      expect(response.key2).toBe('value2');
+      expect(response.key3).toBe('value3');
+      expect(response.key4).toBe(undefined);
+      done();
+    });
+  });
+
+  it('.mset(obj, exp), .mget(array)', function (done) {
+    this.timeout(5000);
+    cacheService.mset({key: value, 'key2': 'value2', 'key3': 'value3'}, 1);
+    setTimeout(function(){
+      cacheService.mget([key, 'key2', 'key3', 'key4'], function (err, response){
+        expect(response.key).toBe(undefined);
+        expect(response.key2).toBe(undefined);
+        expect(response.key3).toBe(undefined);
+        expect(response.key4).toBe(undefined);
+        done();
+      });
+    }, 2100);
+  });
+
+  it('.mset(obj with expirations, exp), .mget(array) (exact key match)', function (done) {
+    this.timeout(5000);
+    cacheService.mset({key: value, 'key2': {cacheValue: 'value2', expiration: 3}, 'key3': 'value3'}, 1);
+    setTimeout(function(){
+      cacheService.mget([key, 'key2', 'key3'], function (err, response){
+        expect(response.key).toBe(undefined);
+        expect(response.key2).toBe('value2');
+        expect(response.key3).toBe(undefined);
+        expect(response.key4).toBe(undefined);
+        done();
+      });
+    }, 2100);
+  });
+
+  it('.mset(obj with expirations, exp), .mget(array) (not exact key match)', function (done) {
+    this.timeout(5000);
+    cacheService.mset({key: value, 'key2': {cacheValue: 'value2', expiration: 3}, 'key3': 'value3'}, 1);
+    setTimeout(function(){
+      cacheService.mget([key, 'key2', 'key3', 'key4'], function (err, response){
+        expect(response.key).toBe(undefined);
+        expect(response.key2).toBe('value2');
+        expect(response.key3).toBe(undefined);
+        expect(response.key4).toBe(undefined);
+        setTimeout(function(){
+          cacheService.mget(['key2'], function (err, response){
+            expect(response.key2).toBe(undefined);
+            done();
+          });
+        }, 2100);
+      done();
+      });
+    }, 2100);
+  });
+
   it('.del(string)', function (done) {
@@ -47,0 +117,0 @@ cacheService.set(key, value);

No alert changes

Improved metrics

Total package byte prevSize

44395

increased by6.54%

Lines of code

952

increased by7.33%

No dependency changes