can-map-define - npm Package Compare versions

Comparing version 3.0.5 to 3.0.6

can-map-define_test.js

@@ -1495,1 +1495,20 @@ /* jshint asi: false */
 });
+
+test("value function not set on constructor defaults", function(){
+	var MyMap = CanMap.extend({
+		define: {
+			propA: {
+				value: function(){
+					return 1;
+				}
+			}
+		}
+	});
+
+	var map = new MyMap();
+
+	equal(MyMap.defaults.propA, undefined, 'Generator function does not result in property set on defaults');
+	notEqual(MyMap.defaultGenerators.propA, undefined, 'Generator function set on defaultGenerators');
+	equal(map.attr("propA"), 1, 'Instance value set properly'); //this is mainly so that CI doesn't complain about unused variable
+
+});

can-map-define.js

@@ -9,2 +9,3 @@ var dev = require('can-util/js/dev/dev');
 var compute = require('can-compute');
+require('can-list');
 
@@ -73,3 +74,3 @@ var define = {}; // jshint ignore:line
 CanMap.prototype._setupDefaults = function(obj) {
-	var defaults = oldSetupDefaults.call(this),
+	var defaults = extend({},oldSetupDefaults.call(this)),
 		propsCommittedToAttr = {},
@@ -76,0 +77,0 @@ Map = this.constructor,

package.json

 {
   "name": "can-map-define",
-  "version": "3.0.5",
+  "version": "3.0.6",
   "description": "Define rich attribute behavior",
@@ -40,2 +40,3 @@ "homepage": "https://canjs.com",
     "can-event": "^3.0.1",
+    "can-list": "^3.0.3",
     "can-map": "^3.0.3",
@@ -49,3 +50,2 @@ "can-util": "^3.0.13",
     "can-fixture": "^1.0.10",
-    "can-list": "^3.0.1",
     "can-model": "^3.0.0-pre.1",
@@ -52,0 +52,0 @@ "can-route": "^3.0.5",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Dev dependency count

14

decreased by-6.67%

Lines of code

1623

increased by1%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

75137

decreased by-12.74%

Dependency count

6

increased by20%

Number of package files

23

decreased by-4.17%

Dependency changes

• + Addedcan-list@^3.0.3

• + Addedcan-list@3.2.2(transitive)