can-stache-bindings - npm Package Compare versions

Comparing version 4.10.8 to 4.10.9

can-stache-bindings.js

@@ -52,3 +52,4 @@ "use strict";
 	scopeBindingStr = "scope",
-	viewModelOrAttributeBindingStr = "viewModelOrAttribute";
+	viewModelOrAttributeBindingStr = "viewModelOrAttribute",
+	viewModelSymbol = canSymbol.for("can.viewModel");
 
@@ -96,3 +97,3 @@ var throwOnlyOneTypeOfBindingError = function() {
 	var bindingCode = attributeName.substr(onMatchStr.length);
-	var viewModel = el && el[canSymbol.for('can.viewModel')];
+	var viewModel = el && el[viewModelSymbol];
 	var elUsed = startsWith.call(bindingCode, elMatchStr);
@@ -534,3 +535,3 @@ var vmUsed = startsWith.call(bindingCode, vmMatchStr);
 					!eventBindingData.bindingCode &&
-					el[canSymbol.for("can.viewModel")] &&
+					el[viewModelSymbol] &&
 					("on" + event) in el
@@ -557,3 +558,3 @@ ) {
 
-			var viewModel = canViewModel(el);
+			var viewModel = el[viewModelSymbol];
 
@@ -681,3 +682,3 @@ // expression.parse will read the attribute
 	viewModelOrAttribute: function(bindingData, bindingContext) {
-		var viewModel = bindingContext.element[canSymbol.for('can.viewModel')];
+		var viewModel = bindingContext.element[viewModelSymbol];
 
@@ -684,0 +685,0 @@ // if we have a viewModel, use it; otherwise, setup attribute binding

package.json

 {
   "name": "can-stache-bindings",
-  "version": "4.10.8",
+  "version": "4.10.9",
   "description": "Default binding syntaxes for can-stache",
@@ -5,0 +5,0 @@ "homepage": "https://canjs.com/doc/can-stache-bindings.html",

test/colon/event-test.js

@@ -732,2 +732,18 @@ var QUnit = require('steal-qunit');
 
+	QUnit.test("events should not create viewmodels (#540)", function(assert) {
+		var ta = this.fixture;
+
+		var template = stache("<div id='click-me' on:click='func()'></div>");
+		var frag = template({
+			func: function(){
+				assert.ok(true, "func ran");
+			}
+		});
+
+		ta.appendChild(frag);
+		var el = doc.getElementById("click-me");
+		domEvents.dispatch(el, "click");
+
+		assert.equal(el[canSymbol.for("can.viewModel")], undefined, "el does not have a viewmodel");
+	});
 });

No alert changes

Improved metrics

Total package byte prevSize

224322

increased by3.02%

Number of package files

31

increased by3.33%

Lines of code

4259

increased by0.33%

No dependency changes