chef-api - npm Package Compare versions

Comparing version 0.4.2 to 0.5.0

operations.js

@@ -81,22 +81,28 @@ var fs = require("fs");
                     if (response) {
-                      if(response.statusCode >= 200 && response.statusCode <= 206){
-                          try{
-                              return fn(null, JSON.parse(response.body));
-                          }
-                          catch(e){
-                              return fn(new Error("Cannot parse response body"), null);
-                          }
-                      }
-                      else{
-                          var message = ["Received status code:", response.statusCode].join(" ");
-                          try{
-                              var body = JSON.parse(response.body);
-                              if(_.has(body, "error"))
-                                  message = [message, body.error].join(" - ");
-                          }
-                          catch(e){
-                              return fn(new Error(message), null);
-                          }
-                          return fn(new Error(message), null);
-                      }
+                        if(response.statusCode >= 200 && response.statusCode <= 206){
+                            try{
+                                var err = null;
+                                var body = JSON.parse(response.body);
+                            }
+                            catch(e){
+                                var err = new Error("Cannot parse response body");
+                                var body = null;
+                            }
+                            return fn(err, body);
+                        }
+                        else{
+                            var message = ["Received status code:", response.statusCode].join(" ");
+                            try{
+                                var body = JSON.parse(response.body);
+                                if(_.has(body, "error"))
+                                    message = [message, body.error].join(" - ");
+
+                                var err = new Error(message);
+                            }
+                            catch(e){
+                                var err = new Error(message);
+                            }
+
+                            return fn(err, null)
+                        }
                     }
@@ -103,0 +109,0 @@ else {

package.json

 {
   "name": "chef-api",
-  "version": "0.4.2",
+  "version": "0.5.0",
   "description": "A simple chef server api wrapper",
@@ -5,0 +5,0 @@ "author": "Norman Joyner <[e-mail]>",

No alert changes

Worsened metrics

Total package byte prevSize

47264

decreased by-5.49%

Number of package files

18

decreased by-10%

Lines of code

603

decreased by-11.71%

No dependency changes