choo-log - npm Package Compare versions

Comparing version 6.1.2 to 7.0.0-0

index.js

 var nanologger = require('nanologger')
+var assert = require('assert')
 
+var ChooInstrument = require('./lib/instrument')
+
 module.exports = logger
@@ -7,66 +10,71 @@
   opts = opts || {}
+  var initialRender = true
 
-  var hasPerformance = typeof window !== 'undefined' &&
-    window.performance &&
-    window.performance.getEntriesByName
-  var clear = opts.clearResourceTimings === undefined ? true : opts.clearResourceTimings
-  var timing = opts.timing === undefined ? true : opts.timing
+  assert.equal(typeof opts, 'object', 'choo-log: opts should be type object')
 
-  if (hasPerformance && clear) {
-    window.performance.onresourcetimingbufferfull = function () {
-      window.performance.clearResourceTimings()
-    }
-  }
-
-  return function (state, bus) {
+  return function (state, emitter) {
+    var hook = ChooInstrument(emitter)
     var log = nanologger('choo')
 
-    bus.on('*', function (eventName, data) {
-      if (hasPerformance && timing && eventName === 'render') {
-        window.requestAnimationFrame(renderPerformance)
-      } else if (!/^log:\w{4,5}/.test(eventName)) {
-        log.info(eventName, data)
-      }
+    hook.on('log:debug', log.debug.bind(log))
+    hook.on('log:info', log.info.bind(log))
+    hook.on('log:warn', log.warn.bind(log))
+    hook.on('log:error', log.error.bind(log))
+    hook.on('log:fatal', log.fatal.bind(log))
 
-      var listeners = bus.listeners(eventName)
-      if (eventName === 'pushState') return
-      if (eventName === 'DOMContentLoaded') return
-      if (!listeners.length) {
-        log.error('No listeners for ' + eventName)
+    hook.on('event', function (eventName, data, timing) {
+      if (timing) {
+        var duration = timing.duration.toFixed()
+        var level = duration < 50 ? 'info' : 'warn'
+        if (data !== undefined) log[level](eventName, data, duration + 'ms')
+        else log[level](eventName, duration + 'ms')
+      } else {
+        if (data !== undefined) log.info(eventName, data)
+        else log.info(eventName)
       }
     })
 
-    bus.on('log:debug', function (message, data) {
-      log.debug(message, data)
+    hook.on('use', function (count, duration) {
+      log.debug('use', { count: count }, duration + 'ms')
     })
 
-    bus.on('log:info', function (message, data) {
-      log.info(message, data)
+    hook.on('unhandled', function (eventName, data) {
+      log.error('No listeners for ' + eventName)
     })
 
-    bus.on('log:warn', function (message, data) {
-      log.warn(message, data)
+    hook.on('DOMContentLoaded', function (timing) {
+      if (!timing) return log.info('DOMContentLoaded')
+      var level = timing.interactive < 1000 ? 'info' : 'warn'
+      log[level]('DOMContentLoaded', timing.interactive + 'ms to interactive')
     })
 
-    bus.on('log:error', function (message, data) {
-      log.error(message, data)
+    hook.on('render', function (timings) {
+      if (!timings) return log.info('render')
+      var duration = timings.render.duration.toFixed()
+      var msg = 'render'
+
+      if (initialRender) {
+        initialRender = false
+        msg = 'initial ' + msg
+      }
+
+      // each frame has 10ms available for userland stuff
+      var fps = Math.min((600 / duration).toFixed(), 60)
+
+      if (fps === 60) {
+        log.info(msg, fps + 'fps', duration + 'ms')
+      } else {
+        log.warn(msg, fps + 'fps', duration + 'ms', {
+          render: timings.render.duration.toFixed() + 'ms',
+          morph: timings.morph.duration.toFixed() + 'ms'
+        })
+      }
     })
 
-    bus.on('log:fatal', function (message, data) {
-      log.fatal(message, data)
+    hook.on('resource-timing-buffer-full', function () {
+      log.error("The browser's Resource Resource timing buffer is full. Cannot store any more timing information")
     })
 
-    function renderPerformance () {
-      var entries = window.performance.getEntriesByName('choo:render')
-      var index = entries.length - 1
-      if (index < 0) return log.info('render')
-      var entry = entries[index]
-      var duration = entry.duration.toFixed()
-      // each frame has 10ms available for userland stuff
-      var fps = Math.min((600 / duration).toFixed(), 60)
-      var details = fps + 'fps ' + duration + 'ms'
-      if (fps === 60) log.info('render', details)
-      else log.warn('render', details)
-    }
+    hook.start()
   }
 }

package.json

 {
   "name": "choo-log",
-  "version": "6.1.2",
+  "version": "7.0.0-0",
   "description": "Development logger for choo",
@@ -9,4 +9,3 @@ "main": "index.js",
     "test": "standard && npm run deps",
-    "test:cov": "standard && npm run deps",
-    "example": "bankai ./example.js -p 8080"
+    "test:cov": "standard && npm run deps"
   },
@@ -25,6 +24,7 @@ "repository": "yoshuawuyts/choo-log",
   "dependencies": {
-    "nanologger": "^1.0.1"
+    "nanologger": "^1.0.1",
+    "on-idle": "^3.0.2",
+    "on-performance": "^1.0.0"
   },
   "devDependencies": {
-    "bankai": "^6.1.1",
     "choo": "^5.0.0",
@@ -31,0 +31,0 @@ "dependency-check": "^2.5.2",

New alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

175748

increased by2.78%

Dev dependency count

5

decreased by-16.67%

Number of package files

8

increased by14.29%

Lines of code

184

increased by217.24%

Worsened metrics

Dependency count

3

increased by200%

Number of low quality alerts

2

increased by100%

Number of medium supply chain risk alerts

1

increased byInfinity%

Dependency changes

• + Addedon-idle@^3.0.2

• + Addedon-performance@^1.0.0

• + Addednanoassert@1.1.0(transitive)

• + Addednanoscheduler@1.0.3(transitive)

• + Addedon-idle@3.1.4(transitive)

• + Addedon-performance@1.2.2(transitive)