ciena-dagre - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

CHANGELOG.md

@@ -0,1 +1,5 @@
+# 1.0.2 (2017-04-25)
+Fixes graph layout with cycles, re-enable tests
+
+
 # 1.0.1
@@ -2,0 +6,0 @@

lib/acyclic.js

@@ -62,3 +62,3 @@ 'use strict';
     var label = g.edge(e);
-    g.removeEdge(e); // FIXME: this is breaking 4 commented out tests
+    g.removeEdge(e);
     label.forwardName = e.name;
@@ -65,0 +65,0 @@ label.reversed = true;

lib/layout.js

@@ -126,3 +126,3 @@ 'use strict';
   time('    acyclic.undo', function () {
-    (0, _acyclic.run)(g);
+    (0, _acyclic.undo)(g);
   });
@@ -129,0 +129,0 @@ }

package.json

 {
   "name": "ciena-dagre",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Graph layout for JavaScript",
@@ -5,0 +5,0 @@ "scripts": {

src/acyclic.js

@@ -49,3 +49,3 @@ import _ from 'lodash'
     var label = g.edge(e)
-    g.removeEdge(e) // FIXME: this is breaking 4 commented out tests
+    g.removeEdge(e)
     label.forwardName = e.name
@@ -52,0 +52,0 @@ label.reversed = true

src/layout.js

@@ -5,3 +5,3 @@ import _ from 'lodash'
   run as acyclicRun,
-  run as acyclicUndo
+  undo as acyclicUndo
 } from './acyclic'
@@ -8,0 +8,0 @@

tests/layout-test.js

@@ -128,4 +128,3 @@ const expect = require('chai').expect
 
-  // FIXME: get test passing
-  it.skip('can layout out a short cycle', function () {
+  it('can layout out a short cycle', function () {
     g.graph().ranksep = 200
@@ -178,4 +177,3 @@ g.setNode('a', { width: 100, height: 100 })
 
-  // FIXME: get tests passing
-  describe.skip('can layout a self loop', function () {
+  describe('can layout a self loop', function () {
     _.forEach(['TB', 'BT', 'LR', 'RL'], function (rankdir) {
@@ -182,0 +180,0 @@ it('in rankdir = ' + rankdir, function () {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

1024218

decreased by-0.14%

Lines of code

10876

decreased by-0.11%

No dependency changes