clay-dropdown - npm Package Compare versions

Comparing version 2.0.0-rc.0 to 2.0.0-rc.1

lib/ClayDropdownBase.js

@@ -169,3 +169,2 @@ 'use strict';
 			if (this.expanded && this.alignElementSelector_) {
-				// eslint-disable-next-line
 				var alignElement = this.element.querySelector(this.alignElementSelector_);
@@ -172,0 +171,0 @@ if (alignElement) {

lib/ClayDropdownBase.soy.js

@@ -269,3 +269,7 @@ 'use strict';
       var listItemsContent__soy235 = function listItemsContent__soy235() {
+        incrementalDom.elementOpenStart('ul');
+        incrementalDom.attr('class', 'list-unstyled');
+        incrementalDom.elementOpenEnd();
         soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Items.idom'), contentRenderer, false)(opt_data, null, opt_ijData);
+        incrementalDom.elementClose('ul');
       };
@@ -606,3 +610,3 @@ var captionContent__soy244 = function captionContent__soy244() {
     if (label && label != '') {
-      incrementalDom.elementOpenStart('div');
+      incrementalDom.elementOpenStart('li');
       incrementalDom.attr('class', 'dropdown-subheader');
@@ -612,3 +616,3 @@ incrementalDom.attr('role', 'presentation');
       soyIdom.print(label);
-      incrementalDom.elementClose('div');
+      incrementalDom.elementClose('li');
     }
@@ -619,3 +623,3 @@ if (items) {
     if (separator) {
-      incrementalDom.elementOpenStart('div');
+      incrementalDom.elementOpenStart('li');
       incrementalDom.attr('aria-hidden', 'true');
@@ -625,3 +629,3 @@ incrementalDom.attr('class', 'dropdown-divider');
       incrementalDom.elementOpenEnd();
-      incrementalDom.elementClose('div');
+      incrementalDom.elementClose('li');
     }
@@ -769,3 +773,3 @@ };
     if (label && label != '') {
-      incrementalDom.elementOpenStart('div');
+      incrementalDom.elementOpenStart('li');
       incrementalDom.attr('class', 'dropdown-subheader');
@@ -775,5 +779,5 @@ incrementalDom.attr('role', 'presentation');
       soyIdom.print(label);
-      incrementalDom.elementClose('div');
+      incrementalDom.elementClose('li');
     }
-    incrementalDom.elementOpenStart('div');
+    incrementalDom.elementOpenStart('li');
     incrementalDom.attr('aria-label', label);
@@ -783,7 +787,11 @@ incrementalDom.attr('role', 'radiogroup');
     if (items) {
+      incrementalDom.elementOpenStart('ul');
+      incrementalDom.attr('class', 'list-unstyled');
+      incrementalDom.elementOpenEnd();
       soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Items.idom'), '', false)({ contentRenderer: 'radio', handleItemClick_: handleItemClick_, items: items, itemsIconAlignment: itemsIconAlignment, spritemap: spritemap }, null, opt_ijData);
+      incrementalDom.elementClose('ul');
     }
-    incrementalDom.elementClose('div');
+    incrementalDom.elementClose('li');
     if (separator) {
-      incrementalDom.elementOpenStart('div');
+      incrementalDom.elementOpenStart('li');
       incrementalDom.attr('aria-hidden', 'true');
@@ -793,3 +801,3 @@ incrementalDom.attr('class', 'dropdown-divider');
       incrementalDom.elementOpenEnd();
-      incrementalDom.elementClose('div');
+      incrementalDom.elementClose('li');
     }
@@ -844,8 +852,3 @@ };
       var item564Data = item564List[item564Index];
-      if (item564Data.type != 'group' && item564Data.type != 'radiogroup' && (item564Index == 0 || items[item564Index - 1].type == 'group' || items[item564Index - 1].type == 'radiogroup')) {
-        incrementalDom.elementOpenStart('ul');
-        incrementalDom.attr('class', 'list-unstyled');
-        incrementalDom.elementOpenEnd();
-      }
-      var variant__soy584 = '';
+      var variant__soy580 = '';
       var $tmp = null;
@@ -859,7 +862,4 @@ if (contentRenderer != null && contentRenderer != '') {
       }
-      variant__soy584 += $tmp;
-      soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Item.idom'), variant__soy584, false)({ active: item564Data.active, checked: item564Data.checked, disabled: item564Data.disabled, handleItemClick_: handleItemClick_, href: item564Data.href, icon: item564Data.icon, inputName: item564Data.inputName, inputValue: item564Data.inputValue, items: item564Data.items, itemsIconAlignment: itemsIconAlignment, label: item564Data.label ? '' + item564Data.label : '', separator: item564Data.separator, spritemap: spritemap }, null, opt_ijData);
-      if (item564Data.type != 'group' && item564Data.type != 'radiogroup' && (item564Index == item564ListLen - 1 || items[item564Index + 1].type == 'group' || items[item564Index + 1].type == 'radiogroup')) {
-        incrementalDom.elementClose('ul');
-      }
+      variant__soy580 += $tmp;
+      soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Item.idom'), variant__soy580, false)({ active: item564Data.active, checked: item564Data.checked, disabled: item564Data.disabled, handleItemClick_: handleItemClick_, href: item564Data.href, icon: item564Data.icon, inputName: item564Data.inputName, inputValue: item564Data.inputValue, items: item564Data.items, itemsIconAlignment: itemsIconAlignment, label: item564Data.label ? '' + item564Data.label : '', separator: item564Data.separator, spritemap: spritemap }, null, opt_ijData);
     }
@@ -866,0 +866,0 @@ };

package.json

 {
   "name": "clay-dropdown",
-  "version": "2.0.0-rc.0",
+  "version": "2.0.0-rc.1",
   "description": "Clay Dropdown Component",
@@ -30,8 +30,8 @@ "license": "BSD",
   "dependencies": {
-    "clay-button": "^2.0.0-rc.0",
-    "clay-checkbox": "^2.0.0-rc.0",
-    "clay-icon": "^2.0.0-rc.0",
-    "clay-link": "^2.0.0-rc.0",
-    "clay-portal": "^2.0.0-rc.0",
-    "clay-radio": "^2.0.0-rc.0",
+    "clay-button": "^2.0.0-rc.1",
+    "clay-checkbox": "^2.0.0-rc.1",
+    "clay-icon": "^2.0.0-rc.1",
+    "clay-link": "^2.0.0-rc.1",
+    "clay-portal": "^2.0.0-rc.1",
+    "clay-radio": "^2.0.0-rc.1",
     "metal": "^2.16.0",
@@ -53,5 +53,5 @@ "metal-component": "^2.16.0",
     "browserslist-config-clay-components": "^1.0.0-alpha.2",
-    "clay": "^2.0.0-rc.0",
+    "clay": "^2.0.0-rc.1",
     "metal-dom": "^2.13.2",
-    "metal-tools-soy": "^5.0.0",
+    "metal-tools-soy": "^6.0.0",
     "webpack": "^3.0.0"
@@ -58,0 +58,0 @@ },

src/ClayDropdownBase.js

@@ -101,3 +101,2 @@ import 'clay-button';
 		if (this.expanded && this.alignElementSelector_) {
-			// eslint-disable-next-line
 			let alignElement = this.element.querySelector(
@@ -104,0 +103,0 @@ this.alignElementSelector_

src/ClayDropdownBase.soy.js

@@ -252,3 +252,7 @@ /* jshint ignore:start */
     var listItemsContent__soy235 = function() {
+      incrementalDom.elementOpenStart('ul');
+          incrementalDom.attr('class', 'list-unstyled');
+      incrementalDom.elementOpenEnd();
       soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Items.idom'), contentRenderer, false)(opt_data, null, opt_ijData);
+      incrementalDom.elementClose('ul');
     };
@@ -593,3 +597,3 @@ var captionContent__soy244 = function() {
   if (label && label != '') {
-    incrementalDom.elementOpenStart('div');
+    incrementalDom.elementOpenStart('li');
         incrementalDom.attr('class', 'dropdown-subheader');
@@ -599,3 +603,3 @@ incrementalDom.attr('role', 'presentation');
     soyIdom.print(label);
-    incrementalDom.elementClose('div');
+    incrementalDom.elementClose('li');
   }
@@ -606,3 +610,3 @@ if (items) {
   if (separator) {
-    incrementalDom.elementOpenStart('div');
+    incrementalDom.elementOpenStart('li');
         incrementalDom.attr('aria-hidden', 'true');
@@ -612,3 +616,3 @@ incrementalDom.attr('class', 'dropdown-divider');
     incrementalDom.elementOpenEnd();
-    incrementalDom.elementClose('div');
+    incrementalDom.elementClose('li');
   }
@@ -758,3 +762,3 @@ };
   if (label && label != '') {
-    incrementalDom.elementOpenStart('div');
+    incrementalDom.elementOpenStart('li');
         incrementalDom.attr('class', 'dropdown-subheader');
@@ -764,5 +768,5 @@ incrementalDom.attr('role', 'presentation');
     soyIdom.print(label);
-    incrementalDom.elementClose('div');
+    incrementalDom.elementClose('li');
   }
-  incrementalDom.elementOpenStart('div');
+  incrementalDom.elementOpenStart('li');
       incrementalDom.attr('aria-label', label);
@@ -772,7 +776,11 @@ incrementalDom.attr('role', 'radiogroup');
   if (items) {
+    incrementalDom.elementOpenStart('ul');
+        incrementalDom.attr('class', 'list-unstyled');
+    incrementalDom.elementOpenEnd();
     soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Items.idom'), '', false)({contentRenderer: 'radio', handleItemClick_: handleItemClick_, items: items, itemsIconAlignment: itemsIconAlignment, spritemap: spritemap}, null, opt_ijData);
+    incrementalDom.elementClose('ul');
   }
-  incrementalDom.elementClose('div');
+  incrementalDom.elementClose('li');
   if (separator) {
-    incrementalDom.elementOpenStart('div');
+    incrementalDom.elementOpenStart('li');
         incrementalDom.attr('aria-hidden', 'true');
@@ -782,3 +790,3 @@ incrementalDom.attr('class', 'dropdown-divider');
     incrementalDom.elementOpenEnd();
-    incrementalDom.elementClose('div');
+    incrementalDom.elementClose('li');
   }
@@ -834,8 +842,3 @@ };
     var item564Data = item564List[item564Index];
-    if (item564Data.type != 'group' && item564Data.type != 'radiogroup' && (item564Index == 0 || items[item564Index - 1].type == 'group' || items[item564Index - 1].type == 'radiogroup')) {
-      incrementalDom.elementOpenStart('ul');
-          incrementalDom.attr('class', 'list-unstyled');
-      incrementalDom.elementOpenEnd();
-    }
-    var variant__soy584 = '';
+    var variant__soy580 = '';
     var $tmp = null;
@@ -849,7 +852,4 @@ if ((contentRenderer != null) && contentRenderer != '') {
     }
-    variant__soy584 += $tmp;
-    soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Item.idom'), variant__soy584, false)({active: item564Data.active, checked: item564Data.checked, disabled: item564Data.disabled, handleItemClick_: handleItemClick_, href: item564Data.href, icon: item564Data.icon, inputName: item564Data.inputName, inputValue: item564Data.inputValue, items: item564Data.items, itemsIconAlignment: itemsIconAlignment, label: item564Data.label ? '' + item564Data.label : '', separator: item564Data.separator, spritemap: spritemap}, null, opt_ijData);
-    if (item564Data.type != 'group' && item564Data.type != 'radiogroup' && (item564Index == item564ListLen - 1 || items[item564Index + 1].type == 'group' || items[item564Index + 1].type == 'radiogroup')) {
-      incrementalDom.elementClose('ul');
-    }
+    variant__soy580 += $tmp;
+    soy.$$getDelegateFn(soy.$$getDelTemplateId('ClayDropdownBase.Item.idom'), variant__soy580, false)({active: item564Data.active, checked: item564Data.checked, disabled: item564Data.disabled, handleItemClick_: handleItemClick_, href: item564Data.href, icon: item564Data.icon, inputName: item564Data.inputName, inputValue: item564Data.inputValue, items: item564Data.items, itemsIconAlignment: itemsIconAlignment, label: item564Data.label ? '' + item564Data.label : '', separator: item564Data.separator, spritemap: spritemap}, null, opt_ijData);
   }
@@ -856,0 +856,0 @@ };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

434218

decreased by-0.32%

Lines of code

4442

decreased by-0.05%

Dependency changes

• Updatedclay-button@^2.0.0-rc.1

• Updatedclay-checkbox@^2.0.0-rc.1

• Updatedclay-icon@^2.0.0-rc.1

• Updatedclay-link@^2.0.0-rc.1

• Updatedclay-portal@^2.0.0-rc.1

• Updatedclay-radio@^2.0.0-rc.1