clay-icon - npm Package Compare versions

Comparing version 2.4.1 to 2.5.0

lib/ClayIcon.js

@@ -106,2 +106,3 @@ 'use strict';
   * @default undefined
+  * @deprecated since version 2.4.x
   * @instance
@@ -111,3 +112,7 @@ * @memberof ClayIcon
   */
-	title: _metalState.Config.string()
+	title: _metalState.Config.validator(function (value) {
+		if (value) {
+			console.warn('🚨 The `title` API will be deprecated and removed in the next release. See more information https://goo.gl/EycJtK');
+		}
+	})
 };
@@ -114,0 +119,0 @@

lib/ClayIcon.soy.js

@@ -63,6 +63,3 @@ 'use strict';
     var id = soy.asserts.assertType(opt_data.id == null || goog.isString(opt_data.id) || opt_data.id instanceof goog.soy.data.SanitizedContent, 'id', opt_data.id, '!goog.soy.data.SanitizedContent|null|string|undefined');
-    /** @type {!goog.soy.data.SanitizedContent|null|string|undefined} */
-    var title = soy.asserts.assertType(opt_data.title == null || goog.isString(opt_data.title) || opt_data.title instanceof goog.soy.data.SanitizedContent, 'title', opt_data.title, '!goog.soy.data.SanitizedContent|null|string|undefined');
-    var attributes__soy31 = function attributes__soy31() {
-      incrementalDom.attr('aria-hidden', 'true');
+    var attributes__soy30 = function attributes__soy30() {
       incrementalDom.attr('class', 'lexicon-icon lexicon-icon-' + symbol + (elementClasses ? ' ' + elementClasses : ''));
@@ -77,9 +74,7 @@ if (focusable) {
       }
+      incrementalDom.attr('role', 'presentation');
     };
     incrementalDom.elementOpenStart('svg');
-    attributes__soy31();
+    attributes__soy30();
     incrementalDom.elementOpenEnd();
-    incrementalDom.elementOpen('title');
-    soyIdom.print(title != null ? title : id != null ? id : symbol);
-    incrementalDom.elementClose('title');
     incrementalDom.elementOpenStart('use');
@@ -99,3 +94,2 @@ incrementalDom.attr('xlink:href', spritemap + '#' + symbol);
    *  id: (!goog.soy.data.SanitizedContent|null|string|undefined),
-   *  title: (!goog.soy.data.SanitizedContent|null|string|undefined),
    * }}
@@ -108,4 +102,4 @@ */
 
-  exports.render.params = ["spritemap", "symbol", "elementClasses", "focusable", "id", "title"];
-  exports.render.types = { "spritemap": "string", "symbol": "string", "elementClasses": "string", "focusable": "bool", "id": "string", "title": "string" };
+  exports.render.params = ["spritemap", "symbol", "elementClasses", "focusable", "id"];
+  exports.render.types = { "spritemap": "string", "symbol": "string", "elementClasses": "string", "focusable": "bool", "id": "string" };
   exports.templates = templates = exports;
@@ -112,0 +106,0 @@ return exports;

package.json

 {
   "name": "clay-icon",
-  "version": "2.4.1",
+  "version": "2.5.0",
   "description": "Clay Icon Component",
@@ -42,8 +42,8 @@ "license": "BSD",
     "babel-preset-env": "^1.6.0",
-    "browserslist-config-clay": "^2.4.1",
-    "clay-css": "^2.4.1",
+    "browserslist-config-clay": "^2.5.0",
+    "clay-css": "^2.5.0",
     "metal-dom": "^2.13.2",
     "metal-tools-soy": "^6.0.0",
     "webpack": "^3.0.0",
-    "webpack-config-clay": "^2.4.1"
+    "webpack-config-clay": "^2.5.0"
   },
@@ -53,3 +53,3 @@ "browserslist": [
   ],
-  "gitHead": "7f1cc9ab5385cf71e305693181efb52192fd95e8"
+  "gitHead": "0274003197fe979a381e7c82c5226166d54088a0"
 }

src/ClayIcon.js

@@ -68,2 +68,3 @@ import Component from 'metal-component';
 	 * @default undefined
+	 * @deprecated since version 2.4.x
 	 * @instance
@@ -73,3 +74,9 @@ * @memberof ClayIcon
 	 */
-	title: Config.string(),
+	title: Config.validator(value => {
+		if (value) {
+			console.warn(
+				'🚨 The `title` API will be deprecated and removed in the next release. See more information https://goo.gl/EycJtK'
+			);
+		}
+	}),
 };
@@ -76,0 +83,0 @@

src/ClayIcon.soy.js

@@ -44,6 +44,3 @@ /* jshint ignore:start */
   var id = soy.asserts.assertType(opt_data.id == null || (goog.isString(opt_data.id) || opt_data.id instanceof goog.soy.data.SanitizedContent), 'id', opt_data.id, '!goog.soy.data.SanitizedContent|null|string|undefined');
-  /** @type {!goog.soy.data.SanitizedContent|null|string|undefined} */
-  var title = soy.asserts.assertType(opt_data.title == null || (goog.isString(opt_data.title) || opt_data.title instanceof goog.soy.data.SanitizedContent), 'title', opt_data.title, '!goog.soy.data.SanitizedContent|null|string|undefined');
-  var attributes__soy31 = function() {
-    incrementalDom.attr('aria-hidden', 'true');
+  var attributes__soy30 = function() {
     incrementalDom.attr('class', 'lexicon-icon lexicon-icon-' + symbol + (elementClasses ? ' ' + elementClasses : ''));
@@ -58,9 +55,7 @@ if (focusable) {
     }
+    incrementalDom.attr('role', 'presentation');
   };
   incrementalDom.elementOpenStart('svg');
-      attributes__soy31();
+      attributes__soy30();
   incrementalDom.elementOpenEnd();
-  incrementalDom.elementOpen('title');
-  soyIdom.print(title != null ? title : id != null ? id : symbol);
-  incrementalDom.elementClose('title');
   incrementalDom.elementOpenStart('use');
@@ -80,3 +75,2 @@ incrementalDom.attr('xlink:href', spritemap + '#' + symbol);
  *  id: (!goog.soy.data.SanitizedContent|null|string|undefined),
- *  title: (!goog.soy.data.SanitizedContent|null|string|undefined),
  * }}
@@ -89,4 +83,4 @@ */
 
-exports.render.params = ["spritemap","symbol","elementClasses","focusable","id","title"];
-exports.render.types = {"spritemap":"string","symbol":"string","elementClasses":"string","focusable":"bool","id":"string","title":"string"};
+exports.render.params = ["spritemap","symbol","elementClasses","focusable","id"];
+exports.render.types = {"spritemap":"string","symbol":"string","elementClasses":"string","focusable":"bool","id":"string"};
 templates = exports;
@@ -93,0 +87,0 @@ return exports;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

33527

decreased by-4.45%

No dependency changes