co-busboy - npm Package Compare versions

Comparing version 1.3.0 to 1.3.1

History.md

 
+1.3.1 / 2015-09-23
+==================
+
+ * test: use codecov.io instead of coveralls
+ * fix: need read all request's datas when error happened
+ * test: add node version 1, 2, 3, 4
+
 1.3.0 / 2015-03-02
@@ -3,0 +10,0 @@ ==================

index.js

 var Busboy = require('busboy')
 var chan = require('chan')
+var BlackHoleStream = require('black-hole-stream')
 
@@ -19,2 +20,3 @@ var getDescriptor = Object.getOwnPropertyDescriptor
   var checkFile = options.checkFile
+  var lastError;
 
@@ -36,3 +38,3 @@ var busboy = new Busboy(options)
     err.status = 413
-    onEnd(err)
+    onError(err)
   })
@@ -44,3 +46,3 @@
     err.status = 413
-    onEnd(err)
+    onError(err)
   })
@@ -52,3 +54,3 @@
     err.status = 413
-    onEnd(err)
+    onError(err)
   })
@@ -71,3 +73,3 @@
       if (err) {
-        return onEnd(err)
+        return onError(err)
       }
@@ -97,3 +99,6 @@ }
       if (err) {
-        return onEnd(err)
+        // make sure request stream's data has been read
+        var blackHoleStream = new BlackHoleStream();
+        file.pipe(blackHoleStream);
+        return onError(err)
       }
@@ -110,5 +115,9 @@ }
 
-  function onEnd(err) {
+  function onError(err) {
+    lastError = err;
+  }
+
+  function onEnd() {
     cleanup()
-    ch(err)
+    ch(lastError)
   }
@@ -115,0 +124,0 @@

package.json

 {
   "name": "co-busboy",
   "description": "Busboy multipart parser as a yieldable",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "author": {
@@ -14,9 +14,10 @@ "name": "Jonathan Ong",
     "type": "git",
-    "url": "https://github.com/jonathanong/co-busboy.git"
+    "url": "https://github.com/cojs/co-busboy.git"
   },
   "bugs": {
     "mail": "[e-mail]",
-    "url": "https://github.com/jonathanong/co-busboy/issues"
+    "url": "https://github.com/cojs/co-busboy/issues"
   },
   "dependencies": {
+    "black-hole-stream": "~0.0.1",
     "busboy": "^0.2.8",
@@ -27,3 +28,4 @@ "chan": "^0.6.1"
     "co": "*",
-    "istanbul-harmony": "*",
+    "formstream": "~1.0.0",
+    "istanbul": "*",
     "mocha": "*"
@@ -30,0 +32,0 @@ },

README.md

@@ -5,3 +5,3 @@ # co busboy
 [![build status][travis-image]][travis-url]
-[![Test coverage][coveralls-image]][coveralls-url]
+[![Test coverage][codecov-image]][codecov-url]
 [![David deps][david-image]][david-url]
@@ -14,4 +14,4 @@ [![npm download][download-image]][download-url]
 [travis-url]: https://travis-ci.org/cojs/busboy
-[coveralls-image]: https://img.shields.io/coveralls/cojs/busboy.svg?style=flat-square
-[coveralls-url]: https://coveralls.io/r/cojs/busboy?branch=master
+[codecov-image]: https://codecov.io/github/cojs/busboy/coverage.svg?branch=master
+[codecov-url]: https://codecov.io/github/cojs/busboy?branch=master
 [david-image]: https://img.shields.io/david/cojs/busboy.svg?style=flat-square
@@ -18,0 +18,0 @@ [david-url]: https://david-dm.org/cojs/busboy

No alert changes

Improved metrics

Total package byte prevSize

10246

increased by5.05%

Lines of code

106

increased by8.16%

Worsened metrics

Dependency count

3

increased by50%

Dev dependency count

4

increased by33.33%

Dependency changes

• + Addedblack-hole-stream@~0.0.1

• + Addedblack-hole-stream@0.0.1(transitive)