comelon - npm Package Compare versions

Comparing version 0.3.0 to 0.3.1

package.json

 {
   "name": "comelon",
-  "version": "v0.3.0",
+  "version": "v0.3.1",
   "main": "main.js",
@@ -25,16 +25,15 @@ "license": "MIT",
   "scripts": {
-    "compile": "gulp js",
-    "cover": "nyc --reporter=lcov --reporter=text npm run test",
-    "dev": "gulp serve",
-    "e2e": " mocha -t 150000 --compilers js:espower-babel/guess --harmony e2e/nightmare.js",
-    "eslint": "eslint $(git ls-files | grep -e '.js$')",
+    "start": "abby compile lint",
+    "compile": "webpack",
+    "lint": "eslint $(git ls-files | grep -e '.js$')",
     "fix": "eslint --fix $(git ls-files | grep -e '.js$')",
-    "lint": "npm run stylint & npm run eslint ",
-    "postdev": "gulp watch",
-    "predev": "npm run style & npm run compile",
-    "style": "gulp css & npm run stylint",
-    "stylint": "stylint ./assets/styl/*.styl",
     "test": "mocha --timeout 150000 --compilers js:espower-babel/guess test/**/*.js",
-    "release": "electron-packager ./release --platform=linux,darwin,win32 --arch=x64 --version=0.36.8"
+    "cover": "nyc --reporter=lcov --reporter=text npm run test",
+    "e2e": " mocha -t 150000 --compilers js:espower-babel/guess --harmony e2e/nightmare.js"
   },
+  "abigail": {
+    "plugins": {
+      "watch": "*,app/**/*.js,test/**/*.js"
+    }
+  },
   "dependencies": {
@@ -45,5 +44,7 @@ "nicolive": "^0.0.4",
   "devDependencies": {
+    "abigail": "^1.1.6",
     "babel-core": "^6.7.4",
-    "babel-eslint": "^5.0.0",
+    "babel-eslint": "^6.0.0",
     "babel-loader": "^6.2.4",
+    "babel-plugin-add-module-exports": "^0.1.2",
     "babel-polyfill": "^6.7.4",
@@ -55,8 +56,7 @@ "babel-preset-es2015": "^6.6.0",
     "chai": "^3.5.0",
-    "electron-connect": "^0.3.7",
-    "electron-prebuilt": "^0.37.2",
+    "electron-prebuilt": "^0.37.3",
     "enzyme": "^2.2.0",
-    "eslint": "^2.4.0",
+    "eslint": "^2.5.3",
     "eslint-plugin-react": "^4.2.3",
-    "espower-babel": "^4.0.1",
+    "espower-babel": "^4.0.3",
     "estraverse": "^4.2.0",
@@ -66,17 +66,7 @@ "estraverse-fb": "^1.3.1",
     "flux": "^2.1.1",
-    "gulp": "^3.9.1",
-    "gulp-compass": "^2.1.0",
-    "gulp-concat-css": "^2.2.0",
-    "gulp-cssmin": "^0.1.7",
-    "gulp-eslint": "^2.0.0",
-    "gulp-load-plugins": "^1.2.0",
-    "gulp-rename": "^1.2.2",
-    "gulp-shell": "^0.5.2",
-    "gulp-stylint": "^3.0.0",
-    "gulp-stylus": "^2.3.1",
-    "gulp-uglify": "^1.5.3",
-    "gulp-webpack": "^1.5.0",
     "immutable": "^3.7.6",
-    "jsdom": "^8.1.0",
+    "jsdom": "^8.2.0",
     "json-loader": "^0.5.4",
+    "keyboardjs": "^2.2.0",
+    "lodash.isequal": "^4.1.2",
     "material-ui": "^0.14.4",
@@ -89,13 +79,10 @@ "mocha": "^2.4.5",
     "power-assert": "^1.3.1",
-    "ramda": "^0.19.1",
-    "react": "^0.14.7",
-    "react-addons-test-utils": "^0.14.7",
-    "react-dom": "^0.14.7",
+    "ramda": "^0.20.1",
+    "react": "^0.14.8",
+    "react-addons-test-utils": "^0.14.8",
+    "react-dom": "^0.14.8",
     "react-imageloader": "^2.1.0",
     "react-tap-event-plugin": "^0.2.2",
-    "run-sequence": "^1.1.5",
     "sinon": "^1.17.3",
     "sinon-chai": "^2.8.0",
-    "stylint": "^1.3.7",
-    "stylus": "^0.54.2",
     "webpack": "^1.12.14",
@@ -102,0 +89,0 @@ "webpack-strip": "^0.1.0"

README.md

@@ -8,11 +8,15 @@ <p align="center">
 [![npm](https://img.shields.io/npm/v/comelon.svg)](https://www.npmjs.com/package/comelon)
+[![npm](https://img.shields.io/npm/dt/comelon.svg)]()
 [![unit](https://img.shields.io/circleci/project/MaxMEllon/comelon.svg)](https://circleci.com/gh/MaxMEllon/comelon)
 [![e2e](https://travis-ci.org/MaxMEllon/comelon.svg?branch=master)](https://travis-ci.org/MaxMEllon/comelon)
-[![windows](https://ci.appveyor.com/api/projects/status/5i4gddsvsd1i2ba3?svg=true)](https://ci.appveyor.com/project/MaxMEllon/comelon)
 [![Test Coverage](https://codeclimate.com/github/MaxMEllon/comelon/badges/coverage.svg)](https://codeclimate.com/github/MaxMEllon/comelon/coverage)
 [![Code Climate](https://codeclimate.com/github/MaxMEllon/comelon/badges/gpa.svg)](https://codeclimate.com/github/MaxMEllon/comelon)
 [![Issue Count](https://codeclimate.com/github/MaxMEllon/comelon/badges/issue_count.svg)](https://codeclimate.com/github/MaxMEllon/comelon)
-[![Dependency Status](https://gemnasium.com/MaxMEllon/comelon.svg)](https://gemnasium.com/MaxMEllon/comelon)
+[![Dependency Status](https://david-dm.org/maxmellon/comelon.svg)](https://david-dm.org/maxmellon/comelon)
+[![devDependency Status](https://david-dm.org/maxmellon/comelon/dev-status.svg)](https://david-dm.org/maxmellon/comelon#info=devDependencies)
 [![npm](https://img.shields.io/npm/l/express.svg)](https://github.com/MaxMEllon/comelon/blob/master/LICENSE.txt)
+[![Stories in Ready](https://badge.waffle.io/MaxMEllon/comelon.svg?label=ready&title=Ready)](http://waffle.io/MaxMEllon/comelon)
 [![Gitter](https://badges.gitter.im/MaxMEllon/comelon.svg)](https://gitter.im/MaxMEllon/comelon?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
+<!-- [![Dependency Status](https://gemnasium.com/MaxMEllon/comelon.svg)](https://gemnasium.com/MaxMEllon/comelon) -->
+<!-- [![windows](https://ci.appveyor.com/api/projects/status/5i4gddsvsd1i2ba3?svg=true)](https://ci.appveyor.com/project/MaxMEllon/comelon) -->
 
@@ -24,3 +28,3 @@ - - -
 <p align="center">
-  <img src="./logs/screenshots/demo.png">
+  <img src="./logs/screenshots/demo.gif">
 </p>
@@ -30,2 +34,4 @@
 
+Quick start for developers.
+
   ```sh
@@ -38,2 +44,6 @@ $ npm install -g electron-prebuild
 
+If you cannot run `npm` command.
+Then, you are able to download `github release`
+[v0.2.3 binary](https://github.com/MaxMEllon/comelon/releases/tag/v0.2.3)
+
 ## For development
@@ -44,8 +54,23 @@
   $ npm i
-  $ npm run dev
+  $ npm run compile
+  $ node_modules/.bin/electron .
   ```
 
+If you would like to watching the source code, then You should execute `npm run start`.
+
+When you run unit test, you need to set enviorment value.
+For example as follows.
+
+  ```
+  $ export USER_EMAIL=[e-mail]
+  $ export PASSWORD=XXXXXXXXXXXX
+  $ npm run test
+  ```
+
+e2e test like when unit test to run, you need to set value.
+
 ## Contribute
 
 Everything okay.
+
 がんがんいこうぜ（小さなプルリクエストからなんでも待ってます）
@@ -52,0 +77,0 @@

scripts/main.js

 'use strict';
 
-const React = require('react');
-const ReactDOM = require('react-dom');
-const Main = require('../app/views/Main');
+import React from 'react';
+import ReactDOM from 'react-dom';
+import Main from '../app/views/Main';
 
@@ -7,0 +7,0 @@ window.onload = function() {

test/actions/CommentAction_spec.js

@@ -33,3 +33,3 @@ 'use strict';
 
-  it('try connect', done => {
+  xit('try connect', done => {
     let isWindows = (process.platform === 'win32');
@@ -36,0 +36,0 @@ if (isWindows) { done(); }

test/actions/NicoAction_spec.js

@@ -34,3 +34,3 @@ 'use strict';
 
-  it('try login', done => {
+  xit('try login', done => {
     let isWindows = (process.platform === 'win32');
@@ -37,0 +37,0 @@ if (isWindows) { done(); }

test/actions/SettingAction_spec.js

@@ -39,3 +39,3 @@ 'use strict';
         SettingAction.setSystemCommentViewOption(null);
-      }).to.throw('type error in SettingAction');
+      }).to.throw('Uncought TypeError in SettingAction');
       done();
@@ -45,2 +45,22 @@ }, 500);
 
+  it('should set to SettingStore of doTalking if call setDoTalkingOption of Action', done => {
+    let callback = () => {
+      let talkingOption = SettingStore.getOption().doTalking;
+      expect(talkingOption).to.be.equal(true);
+      SettingStore.removeChangeListener(callback);
+      done();
+    };
+    SettingStore.addChangeListener(callback);
+    SettingAction.setDoTalkingOption(true);
+  });
+
+  it('if option set null should be exception', done => {
+    setTimeout(() => {
+      expect(() => {
+        SettingAction.setDoTalkingOption(null);
+      }).to.throw('Uncought TypeError in SettingAction');
+      done();
+    }, 500);
+  });
+
   it('try open and close', done => {
@@ -47,0 +67,0 @@ let openCallback = () => {

test/actions/TalkAction_spec.js

@@ -26,8 +26,15 @@ 'use strict';
   it('should be set nowtalking in store if called talk action', () => {
-    TalkAction.talk('sample');
+    TalkAction.talk('samplesamplesamplesample');
     setTimeout(() => {
       expect(TalkStore.isTalkingNow()).to.be.equal(true);
-    }, 100);
+    }, 400);
   });
 
+  it('should dont to set nowtalking in store if called talk action', () => {
+    TalkAction.talk('/disconnect');
+    setTimeout(() => {
+      expect(TalkStore.isTalkingNow()).to.be.equal(false);
+    }, 400);
+  });
+
 });

test/setup.js

@@ -9,2 +9,3 @@ 'use strict';
   global.Image = global.window.Image;
+  global.addEventListener = global.window.addEventListener;
   global.navigator = { userAgent: 'Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2454.85 Safari/537.36' };
@@ -11,0 +12,0 @@ global.location = window.location;

test/stores/SettingStore_spec.js

@@ -18,2 +18,7 @@ 'use strict';
 
+  let actionSetDoTalkingOption = {
+    actionType: SettingActionType.SET_DO_TALKING_OPTION,
+    doTalking: true
+  };
+
   let actionOpen = {
@@ -45,2 +50,8 @@ actionType: SettingActionType.OPEN,
 
+  it('should be set doTalking option in SettingStore if call setDoTalkingOption method', () => {
+    callback(actionSetDoTalkingOption);
+    let option = SettingStore.getOption().doTalking;
+    assert(option === true);
+  });
+
   it('try open', () => {
@@ -47,0 +58,0 @@ callback(actionOpen);

test/stores/TalkStore_spec.js

@@ -15,3 +15,3 @@ 'use strict';
     actionType: TalkActionType.TALK,
-    message: 'sample'
+    message: 'execute to talk if SettingStore has taking option'
   };
@@ -38,3 +38,3 @@
       expect(TalkStore.isTalkingNow()).to.be.equal(true);
-    }, 100);
+    }, 300);
   });
@@ -41,0 +41,0 @@

test/views/Footer_spec.js

@@ -15,2 +15,3 @@ 'use strict';
     React = require('react');
+    require('../setup')();
     done();
@@ -30,3 +31,2 @@ });
   it('if toggled should be set mail option of state', () => {
-    require('../setup')();
     const Footer = require('../../app/views/component/Footer');
@@ -39,3 +39,2 @@ const wrapper = mount(<Footer />);
   it('if input text should be change text of state', () => {
-    require('../setup')();
     const Footer = require('../../app/views/component/Footer');
@@ -42,0 +41,0 @@ const wrapper = mount(<Footer />);

test/views/Header_spec.js

@@ -43,3 +43,3 @@ 'use strict';
 
-  xit('if clicked SettingButton should be set isOpen of SettingStore ', () => {
+  xit('if clicked SettingButton should be set isOpen of SettingStore ', done => {
     require('../setup')();
@@ -49,6 +49,9 @@ const Header = require('../../app/views/component/Header');
     const wrapper = mount(<Header />);
-    wrapper.component.getInstance().handleConfig();
-    setTimeout(() => {expect(SettingStore.isOpen()).to.be.true;}, 100);
+    wrapper.component.getInstance().handleClick('setting');
+    setTimeout(() => {
+      expect(SettingStore.isOpen()).to.be.true;
+      done();
+    }, 500);
   });
 
 });

test/views/Main_spec.js

@@ -11,2 +11,3 @@ 'use strict';
     React = require('react');
+    require('../setup')();
   });
@@ -22,3 +23,2 @@
   it('if MainView mounted should have child component', () => {
-    require('../setup')();
     const Main = require('../../app/views/Main');
@@ -25,0 +25,0 @@ const Header = require('../../app/views/component/Header');

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

4887939

increased by105.97%

Dev dependency count

42

decreased by-22.22%

Lines of code

63183

increased by34.77%

Number of lines in readme file

81

increased by44.64%

Worsened metrics

Number of package files

46

decreased by-16.36%

No dependency changes