commitplease - npm Package Compare versions

Comparing version 1.4.0 to 1.5.0

lib/validate.js

@@ -48,4 +48,5 @@ var merge = require( "mout/object/merge" ),
 		// ticket references
-		if ( /^(close[sd]?|fix(e(sd)?)?|resolve[sd]?)/i.test( line ) ) {
-			if ( !/(Fixes|Closes) (.*#|gh-)[0-9]+/.test( line )) {
+		if ( /^(clos|fix|resolv)(e[sd]|ing)/i.test( line ) ) {
+			if ( !/^(Fixes|Closes)\s+[^\s\d]+(\s|$)/.test( line ) &&
+					!/^(Fixes|Closes) (.*#|gh-)[0-9]+/.test( line ) ) {
 				errors.push( "Invalid ticket reference, must be " +
@@ -52,0 +53,0 @@ "/(Fixes|Closes) (.*#|gh-)[0-9]+/, was: " + line );

package.json

 {
   "name": "commitplease",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "description": "Validates strings as commit messages",
@@ -5,0 +5,0 @@ "main": "index.js",

test.js

@@ -52,2 +52,17 @@ var validate = require( "./lib/validate" );
 		msg: "Component: Message\n#comment"
+	},
+	{
+		msg: "Component: short message\n" +
+		"\n" +
+		"Fixes some bug.\n" +
+		"Fix some other bug.\n" +
+		"\n" +
+		"Fixes #123"
+	},
+	{
+		msg: "Component: short message\n" +
+		"\n" +
+		"Fix some bug.\n" +
+		"\n" +
+		"Fixes #123"
 	}
@@ -81,2 +96,14 @@ ];
 		expected: [ "Invalid ticket reference, must be /(Fixes|Closes) (.*#|gh-)[0-9]+/, was: Closes: gh-155" ]
+	},
+	{
+		msg: "Bla: blub\n\nClosing #1",
+		expected: [ "Invalid ticket reference, must be /(Fixes|Closes) (.*#|gh-)[0-9]+/, was: Closing #1" ]
+	},
+	{
+		msg: "Bla: blub\n\nFixing gh-1",
+		expected: [ "Invalid ticket reference, must be /(Fixes|Closes) (.*#|gh-)[0-9]+/, was: Fixing gh-1" ]
+	},
+	{
+		msg: "Bla: blub\n\nResolving xy-9991",
+		expected: [ "Invalid ticket reference, must be /(Fixes|Closes) (.*#|gh-)[0-9]+/, was: Resolving xy-9991" ]
 	}
@@ -83,0 +110,0 @@ ];

No alert changes

Improved metrics

Total package byte prevSize

9435

increased by8.31%

Lines of code

250

increased by12.61%

No dependency changes