component-builder-handlebars - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

lib/plugin.js

@@ -33,8 +33,8 @@ /*
   var isHandlebarsTemplate = function(file) {
-      return extname === path.extname(file);
-    };
+    return extname === path.extname(file);
+  };
 
   var removePartialPrefix = function(partial) {
-      return partial.replace(partialRegex, '');
-    };
+    return partial.replace(partialRegex, '');
+  };
 
@@ -58,3 +58,3 @@ return function(builder) {
         runtime = fs.readFileSync(runtimeFilepath);
-        builder.addFile('scripts', 'handlebars.runtime.js', runtime);
+        builder.addFile('scripts', 'handlebars.runtime.js', runtime + 'window.Handlebars = Handlebars;');
 
@@ -61,0 +61,0 @@ // auto-invoke the module

package.json

 {
   "name": "component-builder-handlebars",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Builder.js plugin to precompile Handlebars templates",
@@ -5,0 +5,0 @@ "author": "Antoine Lehurt <[e-mail]>",

README.md

@@ -48,3 +48,3 @@ # component-builder-handlebars
 ```html
-[_navPartial.hbs]
+[componentName/path/to/_navPartial.hbs]
 
@@ -60,10 +60,12 @@ <nav>
 ```html
-[myTemplate.hbs]
+[componentName/path/to/myTemplate.hbs]
 
 <h1>{{title}}</h1>
 <!-- When you include a partial don't use the prefix -->
-{{> navPartial}}
+{{> componentName/path/to/navPartial}}
 ```
 
 ```javascript
+[componentName/path/to/module.js]
+
 var myTpl = require('./myTemplate');
@@ -76,6 +78,2 @@
 
-## Release History
-
-- 09/02/2013 - 0.1.0 - Initial release
-
 ## Contributing
@@ -82,0 +80,0 @@

test/plugin_test.js

@@ -7,2 +7,6 @@ var Builder = require('component-builder');
 
+  var req = function(res, moduleName) {
+    return 'var window = "";' + res.require + res.js + '; require("' + moduleName + '")';
+  };
+
   it('should precompile templates and partials', function(done) {
@@ -15,9 +19,9 @@ var builder = new Builder('test/fixtures/tpl-and-partial');
 
-      var test1 = vm.runInNewContext(res.require + res.js + '; require("test-tpl-and-template/test1")');
+      var test1 = vm.runInNewContext(req(res, 'test-tpl-and-template/test1'));
       test1({}).should.equal('<h1>Hello</h1>');
 
-      var test2 = vm.runInNewContext(res.require + res.js + '; require("test-tpl-and-template/test2")');
+      var test2 = vm.runInNewContext(req(res, 'test-tpl-and-template/test2'));
       test2({ content: 'hi' }).should.equal('<h2>Say hi</h2>');
 
-      var test3 = vm.runInNewContext(res.require + res.js + '; require("test-tpl-and-template/test3")');
+      var test3 = vm.runInNewContext(req(res, 'test-tpl-and-template/test3'));
       test3({ content: 'World' }).should.equal('<p>Partial</p>\n<p>Hello</p>\n<p>World</p>');
@@ -37,6 +41,6 @@
 
-      var test1 = vm.runInNewContext(res.require + res.js + '; require("test-with-dependencies/test")');
+      var test1 = vm.runInNewContext(req(res, 'test-with-dependencies/test'));
       test1({ content: 'World' }).should.equal('<p>Hello</p>\n<p>World</p>');
 
-      var depTest = vm.runInNewContext(res.require + res.js + '; require("local-component-test/template")');
+      var depTest = vm.runInNewContext(req(res, 'local-component-test/template'));
       depTest({}).should.equal('<div>Local component template</div>\n<div>hey</div>');
@@ -55,3 +59,3 @@
 
-      var top = vm.runInNewContext(res.require + res.js + '; require("test-nested-partial/views/top")');
+      var top = vm.runInNewContext(req(res, 'test-nested-partial/views/top'));
       top({}).should.equal('<h1>Hello</h1>\n<nav></nav>\n<ul><li></li></ul>');
@@ -72,3 +76,3 @@
 
-      var tpl = vm.runInNewContext(res.require + res.js + '; require("local-component-test/template")');
+      var tpl = vm.runInNewContext(req(res, 'local-component-test/template'));
       tpl({}).should.equal('<div>Local component template</div>');
@@ -75,0 +79,0 @@

No alert changes

Improved metrics

Total package byte prevSize

17880

increased by1.71%

Number of package files

29

increased by3.57%

Lines of code

407

increased by0.74%

Worsened metrics

Number of lines in readme file

84

decreased by-2.33%

No dependency changes