continuation.js - npm Package Compare versions

Comparing version 0.0.3 to 0.0.4

package.json

 {
   "name": "continuation.js",
   "description": "Continuation support for Node.js",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "author": "Daishi Kato <[e-mail]>",
@@ -6,0 +6,0 @@ "dependencies": {

README.md

@@ -71,4 +71,3 @@ continuation.js
 
-* Work with increment expression ex. `i++`
-* Work with try...catch
+* Work with try...catch, throw.
 * Better documents.
@@ -75,0 +74,0 @@ * Transform non-tail calls into CPS.

src/continuation.js

@@ -219,6 +219,21 @@ /*
 root.convert_function_call_to_new_cps_call = function(exclude_ids, body) {
+  var has_side_effect = function(node) {
+    if (node && node.type === 'CallExpression') {
+      return true;
+    } else if (node && node.type === 'UpdateExpression') {
+      return true;
+    } else if (node && node.type === 'AssignmentExpression') {
+      return true;
+    } else if (node && node.type === 'NewExpression') {
+      return true;
+    } else if (node instanceof Object) {
+      return _.some(node, has_side_effect);
+    } else {
+      return false;
+    }
+  };
   var walk = function(node) {
     if (node && (node.type === 'FunctionDeclaration' || node.type === 'FunctionExpression')) {
       return;
-    } else if (node && node.type === 'CallExpression' && node.callee && !(node.callee.type === 'Identifier' && node.callee.name === 'CpsEnableWrapper')) {
+    } else if (node && node.type === 'CallExpression' && node.callee && !has_side_effect(node.callee) && !(node.callee.type === 'Identifier' && node.callee.name === 'CpsEnableWrapper')) {
       var kk_varname = root.generate_new_variable_name('kk', exclude_ids);
@@ -225,0 +240,0 @@ var cpsnode = root.deep_clone(node);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

114658

decreased by-5.95%

Lines of code

2446

decreased by-5.16%

Number of lines in readme file

78

decreased by-1.27%

No dependency changes