conveyor-slideshow - npm Package Compare versions

Comparing version 0.7.1 to 0.7.2

package.json

 {
   "name": "conveyor-slideshow",
-  "version": "0.7.1",
+  "version": "0.7.2",
   "author": "Gil McQuillan, Akhilesh Malla, Peace Chen",
@@ -5,0 +5,0 @@ "license": "MIT",

src/conveyor.js

@@ -109,6 +109,5 @@ /*
 			var current = items[currIndex];
-			if (!current) {
-				return;
+			if (current) {
+				current.classList.remove("conveyor-current");
 			}
-			current.classList.remove("conveyor-current");
 
@@ -121,4 +120,14 @@ // Handle positive & negative wrap-around
 			setCurrentDot(currIndex, items.length);
-			var current = items[currIndex];
+			current = items[currIndex];
+            if (!current) {
+                throw {error: "Conveyor: Unable to navigate to slide " + currIndex};
+			}
 			current.classList.add("conveyor-current");
+			// Show only current slide; hide all others.
+			current.style.visibility = "visible";
+			for (var i=0; i<items.length; i++) {
+				if (i !== currIndex) {
+					items[i].style.visibility = "hidden";
+				}
+			}
 		}
@@ -135,3 +144,2 @@
 			}
-
 			conveyorEl.innerHTML += "<div class='conveyor-ctrl-left'><a class='conveyor-prev'>" +
@@ -147,21 +155,17 @@ "<span class='icon icon-arrow-left'></span>" +
 
-			if (prevArrow) {
-				prevArrow.addEventListener("click", prevArrowClickHandler);
+			if (!prevArrow || !nextArrow) {
+                throw {error: "Conveyor: Unable to create arrows"};
 			}
-			if (nextArrow) {
-				nextArrow.addEventListener("click", nextArrowClickHandler);
-			}
+			prevArrow.addEventListener("click", prevArrowClickHandler);
+			nextArrow.addEventListener("click", nextArrowClickHandler);
 		}
 
 		function destroyArrows() {
-			if (prevArrow) {
-				prevArrow.removeEventListener("click", prevArrowClickHandler);
-				var prevArrowParent = prevArrow.parentNode; // aka conveyor-ctrl-left
-				prevArrowParent.parentNode.removeChild(prevArrowParent);
-			}
-			if (nextArrow) {
-				nextArrow.removeEventListener("click", nextArrowClickHandler);
-				var nextArrowParent = nextArrow.parentNode; // aka conveyor-ctrl-right
-				nextArrowParent.parentNode.removeChild(nextArrowParent);
-			}
+			prevArrow.removeEventListener("click", prevArrowClickHandler);
+			var prevArrowParent = prevArrow.parentNode; // aka conveyor-ctrl-left
+			prevArrowParent.parentNode.removeChild(prevArrowParent);
+
+			nextArrow.removeEventListener("click", nextArrowClickHandler);
+			var nextArrowParent = nextArrow.parentNode; // aka conveyor-ctrl-right
+			nextArrowParent.parentNode.removeChild(nextArrowParent);
 		}
@@ -168,0 +172,0 @@

No alert changes

Improved metrics

Total package byte prevSize

14690

increased by1.8%

Lines of code

294

increased by0.68%

No dependency changes