cordova-plugin-apprate - npm Package Compare versions

Comparing version 1.7.1 to 1.7.2

CHANGELOG.md

@@ -5,2 +5,7 @@ # Changelog
   - Nothing yet
+  
+- 1.7.2
+  - [PR #302](https://github.com/pushandplay/cordova-plugin-apprate/pull/301) - Fix bug in setPreferences
+  - [PR #301](https://github.com/pushandplay/cordova-plugin-apprate/pull/301) - Typescript fixes
+  - [PR #300](https://github.com/pushandplay/cordova-plugin-apprate/pull/300) - Fix iPad device recognition on iOS 13+
  
@@ -7,0 +12,0 @@ - 1.7.1

package.json

 {
   "name": "cordova-plugin-apprate",
-  "version": "1.7.1",
+  "version": "1.7.2",
   "repository": {
@@ -5,0 +5,0 @@ "type": "git",

README.md

@@ -319,3 +319,3 @@ # Cordova-Plugin-Apprate
 ### List of Translations
-https://github.com/pushandplay/cordova-plugin-apprate/blob/master/www/locales.js
+- [./www/locales.js](./www/locales.js)
 
@@ -322,0 +322,0 @@ # Credits

typings/declarations/interfaces/index.d.ts

 declare module 'cordova-plugin-apprate' {
-
   type ReviewTypeAppStore = 'AppStoreReview';
   type ReviewTypeInApp = 'InAppReview';
   type ReviewTypeBrowser = 'InAppBrowser';
+  type PromptType = 'AppRatingPrompt' | 'StoreRatingPrompt' | 'FeedbackPrompt';
 
@@ -33,3 +33,3 @@ interface AppRatePreferences {
   interface CallbackPreferences {
-    onButtonClicked?: (buttonIndex: number) => void;
+    onButtonClicked?: (buttonIndex: number, buttonLabel: string, promptType: PromptType) => void;
     onRateDialogShow?: (rateCallback: (buttonIndex: number) => void) => void;
@@ -63,5 +63,4 @@ handleNegativeFeedback?: () => void;
   interface LocaleOptions extends CustomLocale {
-    language: string
+    language: string;
   }
-
 }

www/AppRate.js

@@ -43,3 +43,3 @@ /*
 
-  var IS_IOS = /(iPhone|iPod|iPad)/i.test(navigator.userAgent.toLowerCase());
+  var IS_IOS = /(iPhone|iPod|iPad)/i.test(navigator.userAgent.toLowerCase()) || (/Macintosh/.test(navigator.userAgent) && window.matchMedia('(any-pointer:coarse)').matches);
   var IS_ANDROID = /Android/i.test(navigator.userAgent.toLowerCase());
@@ -227,3 +227,3 @@ var FLAG_NATIVE_CODE_SUPPORTED = IS_IOS || IS_ANDROID;
     if (pref && typeof pref === 'object') {
-      for (let key in pref) {
+      for (var key in pref) {
         if (pref.hasOwnProperty(key) && prefObj.hasOwnProperty(key)) {
@@ -230,0 +230,0 @@ if (typeof pref[key] === 'object' && key !== 'customLocale') {

No alert changes

Improved metrics

Total package byte prevSize

79253

increased by0.65%

Lines of code

965

increased by0.1%

No dependency changes