cordova-plugin-contacts - npm Package Compare versions

Comparing version 0.2.13 to 0.2.14

package.json

 {
     "name": "cordova-plugin-contacts",
-    "version": "0.2.13",
+    "version": "0.2.14",
     "description": "Cordova Contacts Plugin",
@@ -5,0 +5,0 @@ "cordova": {

RELEASENOTES.md

@@ -126,1 +126,6 @@ <!--
 * merged changes for test framework plugin
+
+### 0.2.14 (Oct 03, 2014)
+* CB-7373 Removes unnecessary Error object creation
+* CB-7373 Adds additional output if method is not supported.
+* CB-7357 Adds missing 'capability' element to phone's appxmanifest.

src/windows/ContactProxy.js

@@ -158,6 +158,6 @@ /*
                 }, function() {
-                    fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+                    fail(new ContactError(ContactError.UNKNOWN_ERROR));
                 });
             }, function () {
-                fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+                fail(new ContactError(ContactError.UNKNOWN_ERROR));
             });
@@ -172,3 +172,5 @@ });
         // http://msdn.microsoft.com/en-us/library/windows/apps/xaml/windows.phone.personalinformation.aspx
-        fail && fail(new ContactError(ContactError.NOT_SUPPORTED_ERROR));
+
+        //We don't need to create Error object here since it will be created at navigator.contacts.find() method
+        fail && fail(ContactError.NOT_SUPPORTED_ERROR);
     },
@@ -213,6 +215,6 @@
             }, function() {
-                fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+                fail(new ContactError(ContactError.UNKNOWN_ERROR));
             });
         }, function() {
-            fail(new ContactError(ContactError.PENDING_OPERATION_ERROR));
+            fail(new ContactError(ContactError.UNKNOWN_ERROR));
         });
@@ -219,0 +221,0 @@ }

tests/tests.js

@@ -456,8 +456,14 @@ /*
             function (e) {
-                results.innerHTML = "Error: " + e.code;
+                if (e.code === ContactError.NOT_SUPPORTED_ERROR) {
+                    results.innerHTML = "Searching for contacts is not supported.";
+                } else {
+                    results.innerHTML = "Search failed: error " + e.code;
+                }
             },
             obj);
-    };
+    }
 
     function addContact() {
+        var results = document.getElementById('contact_results');
+
         try {
@@ -479,4 +485,10 @@ var contact = navigator.contacts.create({ "displayName": "Dooney Evans" });
             contact.save(
-                function () { console.log("Contact saved."); },
-                function (e) { console.log("Contact save failed: " + e.code); }
+                function () { results.innerHTML = "Contact saved."; },
+                function (e) {
+                    if (e.code === ContactError.NOT_SUPPORTED_ERROR) {
+                        results.innerHTML = "Saving contacts not supported.";
+                    } else {
+                        results.innerHTML = "Contact save failed: error " + e.code;
+                    }
+                }
             );
@@ -487,3 +499,3 @@ }
         }
-    };
+    }
 
@@ -499,3 +511,3 @@ /******************************************************************************/
         '</p> <div id="add_contact"></div>' +
-        'Expected result: Will add a new contact. Log will say "Contact saved." Verify by running Get phone contacts again';
+        'Expected result: Will add a new contact. Log will say "Contact saved." or "Saving contacts not supported." if not supported on current platform. Verify by running Get phone contacts again';
 
@@ -502,0 +514,0 @@ createActionButton("Get phone's contacts", function () {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

746252

increased by0.14%

Lines of code

2876

increased by0.42%

No dependency changes