coveralls - npm Package Compare versions

Comparing version 2.11.15 to 2.11.16

lib/getOptions.js

@@ -23,2 +23,3 @@ var fs = require('fs');
     options.service_job_id = process.env.TRAVIS_JOB_ID;
+    options.service_pull_request = process.env.TRAVIS_PULL_REQUEST;
     git_commit = 'HEAD';
@@ -28,10 +29,13 @@ git_branch = process.env.TRAVIS_BRANCH;
 
-  /*
+
   if (process.env.DRONE){
     options.service_name = 'drone';
     options.service_job_id = process.env.DRONE_BUILD_NUMBER;
+    options.service_pull_request = process.env.DRONE_PULL_REQUEST;
+    git_committer_name = process.env.DRONE_COMMIT_AUTHOR;
+    git_committer_email = process.env.DRONE_COMMIT_AUTHOR_EMAIL;
     git_commit = process.env.DRONE_COMMIT;
     git_branch = process.env.DRONE_BRANCH;
+    git_message = process.env.DRONE_COMMIT_MESSAGE;
   }
-  */
 
@@ -38,0 +42,0 @@ if (process.env.JENKINS_URL){

package.json

@@ -8,3 +8,3 @@ {
   ],
-  "version": "2.11.15",
+  "version": "2.11.16",
   "bugs": {
@@ -38,12 +38,12 @@ "url": "https://github.com/nickmerwin/node-coveralls/issues"
     "minimist": "1.2.0",
-    "request": "2.75.0"
+    "request": "2.79.0"
   },
   "devDependencies": {
-    "istanbul": "0.4.4",
+    "istanbul": "0.4.5",
     "jshint": "2.9.3",
-    "mocha": "2.5.3",
+    "mocha": "3.2.0",
     "mocha-lcov-reporter": "1.2.0",
     "should": "9.0.2",
     "sinon-restore": "1.0.1",
-    "snyk": "1.17.0"
+    "snyk": "1.23.3"
   },
@@ -50,0 +50,0 @@ "engines": {

README.md

 #node-coveralls
 
-[![Build Status][travis-image]][travis-url] [![Coverage Status][coveralls-image]][coveralls-url] [![Codeship Build Status][codeship-image]][codeship-url]
+[![Build Status][travis-image]][travis-url] [![Coverage Status][coveralls-image]][coveralls-url]
 [![Known Vulnerabilities](https://snyk.io/test/github/nickmerwin/node-coveralls/badge.svg)](https://snyk.io/test/github/nickmerwin/node-coveralls)
@@ -146,5 +146,2 @@
 
-[codeship-image]: https://www.codeship.io/projects/de6fb440-dea9-0130-e7d9-122ca7ee39d3/status
-[codeship-url]: https://www.codeship.io/projects/5622
-
 [coveralls-image]: https://coveralls.io/repos/nickmerwin/node-coveralls/badge.svg?branch=master&service=github
@@ -151,0 +148,0 @@ [coveralls-url]: https://coveralls.io/github/nickmerwin/node-coveralls?branch=master

test/convertLcovToCoveralls.js

@@ -11,3 +11,3 @@ var convertLcovToCoveralls = require('../index').convertLcovToCoveralls;
   it ("should convert a simple lcov file", function(done){
-    process.env.TRAVIS_JOB_ID = -1;
+    delete process.env.TRAVIS;
     var lcovpath = __dirname + "/../fixtures/onefile.lcov";
@@ -27,3 +27,3 @@ var input = fs.readFileSync(lcovpath, "utf8");
   it ("should pass on all appropriate parameters from the environment", function(done){
-    process.env.TRAVIS_JOB_ID = -1;
+    delete process.env.TRAVIS;
     process.env.COVERALLS_GIT_COMMIT = "GIT_HASH";
@@ -52,3 +52,3 @@ process.env.COVERALLS_GIT_BRANCH = "master";
   it ("should work with a relative path as well", function(done){
-    process.env.TRAVIS_JOB_ID = -1;
+    delete process.env.TRAVIS;
     var lcovpath = __dirname + "/../fixtures/onefile.lcov";
@@ -66,3 +66,3 @@ var input = fs.readFileSync(lcovpath, "utf8");
   it ("should convert absolute input paths to relative", function(done){
-    process.env.TRAVIS_JOB_ID = -1;
+    delete process.env.TRAVIS;
     var lcovpath = __dirname + "/../fixtures/istanbul.lcov";
@@ -96,3 +96,3 @@ var input = fs.readFileSync(lcovpath, "utf8");
   it ("should ignore files that do not exists", function(done){
-    process.env.TRAVIS_JOB_ID = -1;
+    delete process.env.TRAVIS;
     var lcovpath = __dirname + "/../fixtures/istanbul.lcov";
@@ -99,0 +99,0 @@ var input = fs.readFileSync(lcovpath, "utf8");

test/getOptions.js

@@ -52,7 +52,5 @@ var should = require('should');
   });
-  /*
   it ("should set service_name and service_job_id if it's running on drone", function(done){
     testDrone(getBaseOptions, done);
   });
-  */
   it ("should set service_name and service_job_id if it's running on wercker", function(done){
@@ -137,7 +135,5 @@ testWercker(getBaseOptions, done);
   });
-  /*
   it ("should set service_name and service_job_id if it's running on drone", function(done){
     testDrone(getBaseOptions, done);
   });
-  */
   it ("should set service_name and service_job_id if it's running on wercker", function(done){
@@ -290,5 +286,7 @@ testWercker(getOptions, done);
   process.env.TRAVIS_JOB_ID = "1234";
+  process.env.TRAVIS_PULL_REQUEST = "123";
   sut(function(err, options){
     options.service_name.should.equal("travis-ci");
     options.service_job_id.should.equal("1234");
+    options.service_pull_request.should.equal("123");
     done();
@@ -371,2 +369,7 @@ });
   process.env.DRONE_BRANCH = "master";
+  process.env.DRONE_PULL_REQUEST = '3';
+  process.env.DRONE_COMMIT_AUTHOR = 'john doe';
+  process.env.DRONE_COMMIT_AUTHOR_EMAIL = '[e-mail]';
+  process.env.DRONE_COMMIT_MESSAGE = 'msgmsgmsg';
+
   sut(function(err, options){
@@ -379,5 +382,5 @@ options.service_name.should.equal("drone");
                                  author_email: '',
-                                 committer_name: 'Unknown Committer',
-                                 committer_email: '',
-                                 message: 'Unknown Commit Message' },
+                                 committer_name: 'john doe',
+                                 committer_email: '[e-mail]',
+                                 message: 'msgmsgmsg' },
                               branch: 'master',
@@ -384,0 +387,0 @@ remotes: [] });

New alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 5 instances in 1 package

Improved metrics

Total package byte prevSize

69089

increased by0.48%

Lines of code

1607

increased by0.31%

Worsened metrics

Number of lines in readme file

154

decreased by-1.91%

Number of low supply chain risk alerts

152

increased by10.14%

Dependency changes

• + Addedform-data@2.1.4(transitive)

• + Addedqs@6.3.3(transitive)

• + Addedrequest@2.79.0(transitive)

• + Addeduuid@3.4.0(transitive)

• - Removedbl@1.1.2(transitive)

• - Removedcore-util-is@1.0.3(transitive)

• - Removedform-data@2.0.0(transitive)

• - Removedinherits@2.0.4(transitive)

• - Removedisarray@1.0.0(transitive)

• - Removednode-uuid@1.4.8(transitive)

• - Removedprocess-nextick-args@1.0.7(transitive)

• - Removedqs@6.2.4(transitive)

• - Removedreadable-stream@2.0.6(transitive)

• - Removedrequest@2.75.0(transitive)

• - Removedstring_decoder@0.10.31(transitive)

• - Removedutil-deprecate@1.0.2(transitive)

• Updatedrequest@2.79.0