create-yoshi-app - npm Package Compare versions

Comparing version 4.17.3 to 4.18.0

build/getQuestions.js

@@ -59,3 +59,2 @@ "use strict";
                 title: project.name,
-                // https://github.com/DefinitelyTyped/DefinitelyTyped/pull/39269
                 value: project,
@@ -62,0 +61,0 @@ })),

package.json

 {
   "name": "create-yoshi-app",
-  "version": "4.17.3",
+  "version": "4.18.0",
   "description": "create yoshi powered apps",
@@ -52,3 +52,3 @@ "keywords": [
     "@types/parse-git-config": "^3.0.0",
-    "@types/prompts": "^2.0.1",
+    "@types/prompts": "^2.0.2",
     "@types/semver": "^6.0.2",
@@ -66,4 +66,5 @@ "@types/validate-npm-package-name": "^3.0.0",
     "tempy": "^0.3.0",
-    "ts-node": "^8.4.1"
+    "ts-node": "^8.4.1",
+    "type-fest": "^0.8.1"
   }
 }

scripts/dev.js

@@ -21,3 +21,8 @@ process.on('unhandledRejection', error => {
 const { clearConsole } = require('../src/utils');
-const symlinkModules = require('../../../scripts/utils/symlinkModules');
+const {
+  symlinkModules,
+  getYoshiModulesList,
+} = require('../../../scripts/utils/symlinkModules');
+const installExternalDependencies = require('../src/installExternalDependnecies')
+  .default;
 
@@ -175,2 +180,6 @@ function startWatcher(workingDir, templateModel) {
     });
+
+    const yoshiModulesList = getYoshiModulesList();
+
+    installExternalDependencies(workingDir, yoshiModulesList);
   }
@@ -177,0 +186,0 @@

scripts/e2e.js

@@ -87,10 +87,26 @@ const tempy = require('tempy');
       console.log('running npm test...');
-      const { stderr, all: testOutput } = execa.sync('npm test', {
-        shell: true,
-        cwd: testDirectory,
-      });
 
-      console.log(testOutput);
+      let result;
 
-      expect(stderr).not.toContain('Warning: Invalid configuration object');
+      try {
+        result = execa.sync('npm test', {
+          shell: true,
+          cwd: testDirectory,
+        });
+        console.log(result.all);
+      } catch (error) {
+        class NpmTestFailureError extends Error {
+          constructor(m) {
+            super(m);
+            this.message = `\n  ${error.message}\n\n  stdout: ${error.stdout}\n  stderr: ${error.stderr}`;
+            this.stack = '';
+          }
+        }
+
+        throw new NpmTestFailureError();
+      }
+
+      expect(result.stderr).not.toContain(
+        'Warning: Invalid configuration object',
+      );
     });
@@ -97,0 +113,0 @@ });

scripts/runE2E.js

@@ -28,2 +28,3 @@ #!/usr/bin/env node
   reporter: process.env.TEAMCITY_VERSION ? 'mocha-teamcity-reporter' : 'spec',
+  bail: true,
 });
@@ -30,0 +31,0 @@

src/getQuestions.ts

@@ -61,4 +61,3 @@ import getGitConfig from 'parse-git-config';
         title: project.name,
-        // https://github.com/DefinitelyTyped/DefinitelyTyped/pull/39269
-        value: project as any,
+        value: project,
       })),
@@ -65,0 +64,0 @@ },

templates/out-of-iframe/javascript/dev/wix-private.mock.js

 import * as fakeTpaResponse from './fake-tpa-response.json';
 
 if (window.Wix && window.Wix.Utils.getViewMode() === 'standalone') {
-  window.Wix = new class WixMock {
+  window.Wix = new (class WixMock {
     modelCache = {};
@@ -48,2 +48,8 @@ siteColors;
 
+    addEventListener = () => {};
+
+    Events = {
+      INSTANCE_CHANGED: 'INSTANCE_CHANGED',
+    };
+
     Styles = {
@@ -55,3 +61,3 @@ getSiteColors: cb => cb(this.siteColors),
     };
-  }();
+  })();
 }

templates/out-of-iframe/javascript/README.md

@@ -133,3 +133,3 @@ # Out of IFrame App
 ```
-https://localhost:3000/settingsPanel
+https://localhost:3000/editorApp
 ```
@@ -140,3 +140,3 @@
 ```
-https://localhost:3000/editorApp
+https://localhost:3000/settingsPanel
 ```
@@ -143,0 +143,0 @@

templates/out-of-iframe/typescript/dev/wix-private.mock.js

 import * as fakeTpaResponse from './fake-tpa-response.json';
 
 if (window.Wix && window.Wix.Utils.getViewMode() === 'standalone') {
-  window.Wix = new class WixMock {
+  window.Wix = new (class WixMock {
     modelCache = {};
@@ -48,2 +48,8 @@ siteColors;
 
+    addEventListener = () => {};
+
+    Events = {
+      INSTANCE_CHANGED: 'INSTANCE_CHANGED',
+    };
+
     Styles = {
@@ -55,3 +61,3 @@ getSiteColors: cb => cb(this.siteColors),
     };
-  }();
+  })();
 }

No alert changes

Improved metrics

Total package byte prevSize

705697

increased by7.41%

Number of package files

458

increased by1.1%

Lines of code

10164

increased by1.08%

Worsened metrics

Dev dependency count

17

increased by6.25%

Number of low supply chain risk alerts

33

increased by3.13%

No dependency changes