cytoscape-qtip - npm Package Compare versions

Comparing version 2.2.5 to 2.2.6

bower.json

 {
   "name": "cytoscape-qtip",
-  "version": "2.2.5",
+  "version": "2.2.6",
   "main": "cytoscape-qtip.js",
@@ -5,0 +5,0 @@ "repository": {

cytoscape-qtip.js

@@ -15,2 +15,20 @@ ;(function( $, $$ ){ 'use strict';
 
+  var isString = function(o){
+    return o != null && typeof o === 'string';
+  };
+
+  var isUndef = function(o){
+    return o === undefined;
+  };
+
+  var wrap = function(obj, target) {
+    if( isFunction(obj) ) {
+      return function(event, api){
+        return obj.apply( target, [event, api] );
+      };
+    } else {
+      return obj;
+    }
+  };
+
   var throttle = function(func, wait, options) {
@@ -166,3 +184,3 @@ var leading = true,
 
-      if( adjust.cyAdjustToEleBB === undefined ){
+      if( isUndef(adjust.cyAdjustToEleBB) ){
         adjust.cyAdjustToEleBB = true;
@@ -174,3 +192,3 @@ }
 
-      if( !opts.show.event ){
+      if( isUndef(opts.show.event) ){
         opts.show.event = 'tap';
@@ -183,3 +201,3 @@ }
 
-      if( !opts.hide.event ){
+      if( isUndef(opts.hide.event) ){
         opts.hide.event = 'unfocus';
@@ -191,13 +209,9 @@ }
 
-      var content;
       if( opts.content ){
-        if( isFunction(opts.content) ){
-          content = opts.content;
-        } else if( opts.content.text && isFunction(opts.content.text) ){
-          content = opts.content.text;
-        }
-
-        if( content ){
-          opts.content = function(event, api){
-            return content.apply( target, [event, api] );
+        if ( isFunction(opts.content) || isString(opts.content) ){
+          opts.content = wrap( opts.content, target );
+        } else {
+          opts.content = {
+            text: wrap( opts.content.text, target ),
+            title: wrap( opts.content.title, target )
           };
@@ -204,0 +218,0 @@ }

gulpfile.js

@@ -19,3 +19,3 @@ var gulp = require('gulp');
 gulp.task('publish', [], function( next ){
-  runSequence('confver', /*'lint',*/ 'pkgver', 'push', 'tag', 'npm', 'spm', 'meteor', next);
+  runSequence('confver', /*'lint',*/ 'pkgver', 'push', 'tag', 'npm', 'spm', next);
 });
@@ -48,3 +48,3 @@
   }
-  
+
 });
@@ -78,6 +78,2 @@
 
-gulp.task('meteor', shell.task([
-  'meteor publish'
-]));
-
 gulp.task('spm', shell.task([
@@ -84,0 +80,0 @@ 'spm publish'

package.json

 {
   "name": "cytoscape-qtip",
-  "version": "2.2.5",
+  "version": "2.2.6",
   "description": "A Cytoscape.js extension that wraps the qTip jQuery library",
@@ -5,0 +5,0 @@ "main": "cytoscape-qtip.js",

README.md

@@ -79,2 +79,7 @@ cytoscape-qtip
 
+## API restrictions
+
+You may not use `options.position.target`.  If you require a different value, like `'body'` or `'mouse'`, you don't need this extenstion -- you can simply use the qTip APIs directly on a DOM element.
+
+
 ## API additions
@@ -97,2 +102,2 @@
 1. Set the version number env var: `export VERSION=1.2.3`
-1. Publish: `gulp`
+1. Publish: `gulp`

No alert changes

Improved metrics

Number of lines in readme file

102

increased by6.25%

Worsened metrics

Total package byte prevSize

34677

decreased by-0.73%

Number of package files

8

decreased by-11.11%

Lines of code

414

decreased by-3.5%

No dependency changes