cytoscape - npm Package Compare versions

Comparing version 3.1.3 to 3.1.4

ISSUE_TEMPLATE.md

@@ -1,35 +0,70 @@
-## **I'm submitting a:**
-- [ ] Bug report
-- [ ] Feature request
-- [ ] *Requests for help should be directed to [Stack Overflow](http://stackoverflow.com/questions/tagged/cytoscape.js) or [Gitter](https://gitter.im/cytoscape/cytoscape.js)*
+**Issue type**
 
---------------------
+<!-- 
+Are you submitting a bug report or a feature request?
 
-## Bug reports
-
 When submitting a bug report, check the following:
-- [ ] Report has a descriptive title
-- [ ] Bug still exists in most recent Cy.js version
+- The report has a descriptive title.
+- The bug still exists in most recent version of the library.
 
-### Environment info
-- [ ] Browser and version:
-  - [ ] Node version (if running headless):
-- [ ] Cytoscape.js version:
+A request for help or a requests for a how-to should be directed to Stack Overflow:
+http://stackoverflow.com/questions/tagged/cytoscape.js 
+-->
 
-### Current behavior
+<!-- Delete one option -->
+Bug report
+Feature request 
+
+
+
+
+<!-- BUG REPORT : Delete if requesting a feature -->
+
+**Environment info**
+
+- Cytoscape.js version : 
+- Browser/Node.js & version : 
+
+**Current (buggy) behaviour**
+
 <!-- What does the bug do? -->
 
-### Desired behavior
+
+**Desired behaviour**
+
 <!-- What do you expect Cytoscape.js to do instead? -->
 
-### Minimum steps to reproduce
-<!-- Repos that can be cloned to reproduce bug or a link to a JSBin/ CodePen/ JSFiddle are appreciated!  It helps to address your issue faster. -->
 
---------------------
+**Minimum steps to reproduce**
 
-## Feature requests
+<!-- 
+Write out an overview of what you need to do to reproduce the issue.
 
-### Description of new feature
+Fork/clone this JSBin demo and reproduce your issue so that your issue can be addressed quickly:
+http://jsbin.com/teworah
 
-### Motivation for new feature
-<!-- Describe your use case for this new feature -->
+If your code to reproduce is only two or three lines, you can write it in the issue instead.  Format your code in backtick code blocks like this:
+
+```js
+my.code();
+```
+-->
+
+<!-- END BUG REPORT -->
+
+
+
+
+<!-- FEATURE REQUEST : Delete if reporting a bug -->
+
+**Description of new feature**
+
+<!-- What should the new feature do?  For visual features, include an image/mockup of the expected output. -->
+
+
+**Motivation for new feature**
+
+<!-- Describe your use case for this new feature. -->
+
+
+<!-- END FEATURE REQUEST -->

package.json

 {
   "name": "cytoscape",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "license": "MIT",
@@ -5,0 +5,0 @@ "description": "Graph theory (a.k.a. network) library for analysis and visualisation",

src/extensions/renderer/base/coord-ele-math/edge-control-points.js

@@ -26,2 +26,3 @@ 'use strict';
     var edgeIsUnbundled = curveStyle === 'unbundled-bezier' || curveStyle === 'segments';
+    var edgeIsBezier = curveStyle === 'unbundled-bezier' || curveStyle === 'bezier';
 
@@ -50,12 +51,18 @@ // ignore edges who are not to be displayed
 
-    if( hashTable[ pairId ] == null ){
-      hashTable[ pairId ] = [];
+    var tableEntry = hashTable[ pairId ];
+
+    if( tableEntry == null ){
+      tableEntry = hashTable[ pairId ] = [];
       pairIds.push( pairId );
     }
 
-    hashTable[ pairId ].push( edge );
+    tableEntry.push( edge );
 
     if( edgeIsUnbundled ){
-      hashTable[ pairId ].hasUnbundled = true;
+      tableEntry.hasUnbundled = true;
     }
+
+    if( edgeIsBezier ){
+      tableEntry.hasBezier = true;
+    }
   }
@@ -249,3 +256,3 @@
 
-      if( !pairEdges.calculatedIntersection && ( (pairEdges.length > 1 && src !== tgt) || pairEdges.hasUnbundled ) ){
+      if( !pairEdges.calculatedIntersection && src !== tgt && ( pairEdges.hasBezier || pairEdges.hasUnbundled ) ){
 
@@ -265,2 +272,4 @@ pairEdges.calculatedIntersection = true;
 
+        pairEdges.srcIntn = srcOutside;
+
         // pt outside tgt shape to calc distance/displacement from src to tgt
@@ -277,2 +286,4 @@ var tgtOutside = tgtShape.intersectLine(
 
+        pairEdges.tgtIntn = tgtOutside;
+
         var midptSrcPts = {
@@ -322,4 +333,4 @@ x1: srcOutside[0],
 
-      rs.srcIntn = srcOutside;
-      rs.tgtIntn = tgtOutside;
+      rs.srcIntn = pairEdges.srcIntn;
+      rs.tgtIntn = pairEdges.tgtIntn;
 
@@ -326,0 +337,0 @@ if( src === tgt ){

src/extensions/renderer/base/coord-ele-math/edge-endpoints.js

@@ -79,3 +79,5 @@ 'use strict';
   var srcManEndpt = edge.pstyle('source-endpoint');
+  var srcManEndptVal = self ? 'outside-to-node' : srcManEndpt.value;
   var tgtManEndpt = edge.pstyle('target-endpoint');
+  var tgtManEndptVal = self ? 'outside-to-node' : tgtManEndpt.value;
 
@@ -105,12 +107,12 @@ rs.srcManEndpt = srcManEndpt;
 
-  if( tgtManEndpt.value === 'inside-to-node' ){
+  if( tgtManEndptVal === 'inside-to-node' ){
     intersect = [ tgtPos.x, tgtPos.y ];
   } else if( tgtManEndpt.units ){
     intersect = this.manualEndptToPx( target, tgtManEndpt );
-  } else if( tgtManEndpt.value === 'outside-to-line' ){
+  } else if( tgtManEndptVal === 'outside-to-line' ){
     intersect = rs.tgtIntn; // use cached value from ctrlpt calc
   } else {
-    if( tgtManEndpt.value === 'outside-to-node' ){
+    if( tgtManEndptVal === 'outside-to-node' ){
       p1_i = p1;
-    } else if( tgtManEndpt.value === 'outside-to-line' ){
+    } else if( tgtManEndptVal === 'outside-to-line' ){
       p1_i = [ srcPos.x, srcPos.y ];
@@ -147,12 +149,12 @@ }
 
-  if( srcManEndpt.value === 'inside-to-node' ){
+  if( srcManEndptVal === 'inside-to-node' ){
     intersect = [ srcPos.x, srcPos.y ];
   } else if( srcManEndpt.units ){
     intersect = this.manualEndptToPx( source, srcManEndpt );
-  } else if( srcManEndpt.value === 'outside-to-line' ){
+  } else if( srcManEndptVal === 'outside-to-line' ){
     intersect = rs.srcIntn; // use cached value from ctrlpt calc
   } else {
-    if( srcManEndpt.value === 'outside-to-node' ){
+    if( srcManEndptVal === 'outside-to-node' ){
       p2_i = p2;
-    } else if( srcManEndpt.value === 'outside-to-line' ){
+    } else if( srcManEndptVal === 'outside-to-line' ){
       p2_i = [ tgtPos.x, tgtPos.y ];
@@ -159,0 +161,0 @@ }

src/version.js

@@ -1,1 +0,1 @@
-module.exports = "3.1.3";
+module.exports = "3.1.4";

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3000218

increased by0.07%

Lines of code

48870

increased by0.04%

No dependency changes