cytoscape - npm Package Compare versions

Comparing version 3.8.1 to 3.8.2

.size-snapshot.json

 {
   "build/cytoscape.umd.js": {
-    "bundled": 901792,
-    "minified": 334905,
-    "gzipped": 104028
+    "bundled": 902391,
+    "minified": 334968,
+    "gzipped": 104063
   },
   "build/cytoscape.cjs.js": {
-    "bundled": 830385,
-    "minified": 352681,
-    "gzipped": 106212
+    "bundled": 830960,
+    "minified": 352744,
+    "gzipped": 106264
   },
   "build/cytoscape.esm.js": {
-    "bundled": 830212,
-    "minified": 352538,
-    "gzipped": 106182,
+    "bundled": 830787,
+    "minified": 352601,
+    "gzipped": 106222,
     "treeshaked": {
       "rollup": {
-        "code": 329558,
+        "code": 329621,
         "import_statements": 51
       },
       "webpack": {
-        "code": 331425
+        "code": 331488
       }
@@ -24,0 +24,0 @@ }

package.json

 {
   "name": "cytoscape",
-  "version": "3.8.1",
+  "version": "3.8.2",
   "license": "MIT",
@@ -5,0 +5,0 @@ "description": "Graph theory (a.k.a. network) library for analysis and visualisation",

src/collection/dimensions/bounds.js

@@ -58,4 +58,2 @@ import * as is from '../../is';
 
-  let updated = [];
-
   function update( parent ){
@@ -81,5 +79,3 @@ if( !parent.isParent() ){ return; }
 
-    let takesUpSpace = ele => ele.pstyle('display').value === 'element';
-
-    let bb = children.filter(takesUpSpace).boundingBox( {
+    let bb = children.boundingBox( {
       includeLabels: includeLabels,
@@ -180,4 +176,2 @@ includeOverlays: false,
     pos.y = (- diffTop + bb.y1 + bb.y2 + diffBottom) / 2;
-
-    updated.push( parent );
   }
@@ -438,3 +432,2 @@
   let _p = ele._private;
-  let display = styleEnabled ? ele.pstyle( 'display' ).value : 'element';
   let isNode = ele.isNode();
@@ -444,7 +437,20 @@ let isEdge = ele.isEdge();
   let x, y; // node pos
-  let displayed = display !== 'none';
   let rstyle = _p.rstyle;
   let manualExpansion = isNode && styleEnabled ? ele.pstyle('bounds-expansion').pfValue : 0;
 
-  if( displayed ){
+  // must use `display` prop only, as reading `compound.width()` causes recursion
+  // (other factors like width values will be considered later in this function anyway)
+  let isDisplayed = ele => ele.pstyle('display').value !== 'none';
+
+  let displayed = (
+    !styleEnabled
+    || (
+      isDisplayed(ele)
+
+      // must take into account connected nodes b/c of implicit edge hiding on display:none node
+      && ( !isEdge || ( isDisplayed(ele.source()) && isDisplayed(ele.target()) ) )
+    )
+  );
+
+  if( displayed ){ // displayed suffices, since we will find zero area eles anyway
     let overlayOpacity = 0;
@@ -451,0 +457,0 @@ let overlayPadding = 0;

src/collection/layout.js

@@ -14,11 +14,15 @@ import * as util from '../util';
 
-    if( options.nodeDimensionsIncludeLabels ){
+    let dims;
+
+    if( !this.takesUpSpace() ){
+      dims = { w: 0, h: 0 };
+    } else if( options.nodeDimensionsIncludeLabels ){
       let bbDim = this.boundingBox();
-      return {
+
+      dims = {
         w: bbDim.w,
         h: bbDim.h
       };
-    }
-    else {
-      return {
+    } else {
+      dims = {
         w: this.outerWidth(),
@@ -28,2 +32,9 @@ h: this.outerHeight()
     }
+
+    // sanitise the dimensions for external layouts (avoid division by zero)
+    if( dims.w === 0 || dims.h === 0 ){
+      dims.w = dims.h = 1;
+    }
+
+    return dims;
   },
@@ -30,0 +41,0 @@

src/extensions/layout/breadthfirst.js

@@ -261,3 +261,3 @@ import * as util from '../../util';
       if( depth < eleDepth ){ // only get influenced by elements above
-        percent += index / ( nDepth - 1 );
+        percent += index / nDepth;
         samples++;
@@ -264,0 +264,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3763800

increased by0.06%

Lines of code

102365

increased by0.05%

No dependency changes