d2-analysis - npm Package Compare versions

Comparing version 33.1.0 to 33.1.1

lib/api/OrganisationUnit.js

@@ -188,29 +188,27 @@ 'use strict';
     if (sublevels.length > 0) {
-        (function () {
-            var root = _this3.getRootAncestor();
+        var root = this.getRootAncestor();
 
+        items.push({
+            isSubtitle: true,
+            style: 'padding: 5px 5px 5px 5px; font-size: 120%; font-weight:bold',
+            html: this.i18n.drill_down
+        });
+
+        sublevels.forEach(function (ou) {
             items.push({
-                isSubtitle: true,
-                style: 'padding: 5px 5px 5px 5px; font-size: 120%; font-weight:bold',
-                html: _this3.i18n.drill_down
+                items: [{ id: ou.id + ';' + 'LEVEL-' + ou.level }],
+                text: 'Show all <span class="name">' + ou.name.toLowerCase() + ' units in ' + _this3.getName() + '</span>',
+                iconCls: 'ns-menu-item-float'
             });
+        });
 
-            sublevels.forEach(function (ou) {
+        sublevels.forEach(function (ou) {
+            if (root.level !== _this3.getLevel()) {
                 items.push({
-                    items: [{ id: ou.id + ';' + 'LEVEL-' + ou.level }],
-                    text: 'Show all <span class="name">' + ou.name.toLowerCase() + ' units in ' + _this3.getName() + '</span>',
+                    items: [{ id: root.id + ';' + 'LEVEL-' + ou.level }],
+                    text: 'Show all <span class="name">' + ou.name + ' units</span>',
                     iconCls: 'ns-menu-item-float'
                 });
-            });
-
-            sublevels.forEach(function (ou) {
-                if (root.level !== _this3.getLevel()) {
-                    items.push({
-                        items: [{ id: root.id + ';' + 'LEVEL-' + ou.level }],
-                        text: 'Show all <span class="name">' + ou.name + ' units</span>',
-                        iconCls: 'ns-menu-item-float'
-                    });
-                }
-            });
-        })();
+            }
+        });
     }
@@ -217,0 +215,0 @@

lib/manager/TableManager.js

@@ -264,50 +264,48 @@ 'use strict';
         if (ouId) {
-            (function () {
-                menu.add({
-                    uid: 'OU_MENU',
-                    text: i18n.organisation_units_drill_down || 'Org unit drill down/up',
-                    iconCls: 'ns-menu-item-datasource',
-                    menu: {
-                        items: [{ html: '<div class="spinner"></div>' }]
-                    }
-                });
+            menu.add({
+                uid: 'OU_MENU',
+                text: i18n.organisation_units_drill_down || 'Org unit drill down/up',
+                iconCls: 'ns-menu-item-datasource',
+                menu: {
+                    items: [{ html: '<div class="spinner"></div>' }]
+                }
+            });
 
-                var ouMenu = menu.items.findBy(function (submenu) {
-                    return submenu.uid === 'OU_MENU';
-                });
-                var organisationUnit = new _OrganisationUnit.OrganisationUnit(layout.getRefs(), { id: ouId });
+            var ouMenu = menu.items.findBy(function (submenu) {
+                return submenu.uid === 'OU_MENU';
+            });
+            var organisationUnit = new _OrganisationUnit.OrganisationUnit(layout.getRefs(), { id: ouId });
 
-                uiManager.mask();
+            uiManager.mask();
 
-                organisationUnit.getAncestorsRequest(true).done(function (data) {
-                    organisationUnit.setAncestors(data.ancestors);
-                    organisationUnit.setLevel(data.level);
+            organisationUnit.getAncestorsRequest(true).done(function (data) {
+                organisationUnit.setAncestors(data.ancestors);
+                organisationUnit.setLevel(data.level);
 
-                    var organisationUnitMenuItems = organisationUnit.getContextMenuItemsConfig();
+                var organisationUnitMenuItems = organisationUnit.getContextMenuItemsConfig();
 
-                    // setting click handler
-                    for (var i = 0; i < organisationUnitMenuItems.length; ++i) {
-                        var ou = organisationUnitMenuItems[i];
+                // setting click handler
+                for (var i = 0; i < organisationUnitMenuItems.length; ++i) {
+                    var ou = organisationUnitMenuItems[i];
 
-                        if (ou.isSubtitle) {
-                            continue;
-                        }
+                    if (ou.isSubtitle) {
+                        continue;
+                    }
 
-                        ou.handler = function () {
-                            var layout = instanceManager.getStateCurrent();
-                            var ouDimension = new _Dimension.Dimension(layout.getRefs(), { dimension: 'ou', items: this.items });
+                    ou.handler = function () {
+                        var layout = instanceManager.getStateCurrent();
+                        var ouDimension = new _Dimension.Dimension(layout.getRefs(), { dimension: 'ou', items: this.items });
 
-                            layout.replaceDimensionByName(ouDimension);
+                        layout.replaceDimensionByName(ouDimension);
 
-                            layout.setResponse(null);
+                        layout.setResponse(null);
 
-                            instanceManager.getReport(layout, false, false, true);
-                        };
-                    }
+                        instanceManager.getReport(layout, false, false, true);
+                    };
+                }
 
-                    ouMenu.menu.removeAll();
-                    ouMenu.menu.add(organisationUnitMenuItems);
-                    uiManager.unmask();
-                });
-            })();
+                ouMenu.menu.removeAll();
+                ouMenu.menu.add(organisationUnitMenuItems);
+                uiManager.unmask();
+            });
         }
@@ -385,25 +383,23 @@
             if (item && (0, _arrayContains2.default)(METADATA_DETAILED_TYPES, item.dimensionItemType)) {
-                (function () {
-                    var html = '<p>Type: ' + item.dimensionItemType + '</p>';
+                var html = '<p>Type: ' + item.dimensionItemType + '</p>';
 
-                    if (item.description) {
-                        html += '<p>Description: ' + item.description + '</p>';
-                    }
+                if (item.description) {
+                    html += '<p>Description: ' + item.description + '</p>';
+                }
 
-                    if (item.code) {
-                        html += '<p>Code: ' + item.code + '</p>';
-                    }
+                if (item.code) {
+                    html += '<p>Code: ' + item.code + '</p>';
+                }
 
-                    var tip = Ext.create('Ext.tip.ToolTip', {
-                        target: Ext.get(obj.uuid),
-                        bodyStyle: 'font-size: 110%',
-                        html: html
-                    });
+                var tip = Ext.create('Ext.tip.ToolTip', {
+                    target: Ext.get(obj.uuid),
+                    bodyStyle: 'font-size: 110%',
+                    html: html
+                });
 
-                    Ext.get(obj.uuid).on({
-                        mouseover: function mouseover() {
-                            Ext.Function.createBuffered(tip.show, 1000, tip);
-                        }
-                    });
-                })();
+                Ext.get(obj.uuid).on({
+                    mouseover: function mouseover() {
+                        Ext.Function.createBuffered(tip.show, 1000, tip);
+                    }
+                });
             }
@@ -410,0 +406,0 @@ };

lib/util/permissions.js

@@ -52,48 +52,46 @@ "use strict";
 
-    (function () {
-        switch (modelKey + "-" + field) {
-            /* Interpretations validations: check that its sharing is a subset of the favorite sharing */
-            case "interpretation-publicAccess":
-                predicate = function predicate(value) {
-                    return isObjectAccessible(favorite[field], value);
-                };
-                break;
-            case "interpretation-userAccesses":
-            case "interpretation-userGroupAccesses":
-                var favoritePermissionIds = new Set(toArray(favorite[field]).map(function (p) {
+    switch (modelKey + "-" + field) {
+        /* Interpretations validations: check that its sharing is a subset of the favorite sharing */
+        case "interpretation-publicAccess":
+            predicate = function predicate(value) {
+                return isObjectAccessible(favorite[field], value);
+            };
+            break;
+        case "interpretation-userAccesses":
+        case "interpretation-userGroupAccesses":
+            var favoritePermissionIds = new Set(toArray(favorite[field]).map(function (p) {
+                return p.id;
+            }));
+            predicate = function predicate(permissions) {
+                return toArray(permissions).every(function (permission) {
+                    return favoritePermissionIds.has(permission.id);
+                });
+            };
+            break;
+
+        /* Favorite validations: check that all its interpretation sharings are a subset of this favorite sharing */
+        case "favorite-publicAccess":
+            predicate = function predicate(value) {
+                return interpretations.every(function (interpretation) {
+                    return isObjectAccessible(value, interpretation[field]);
+                });
+            };
+            break;
+        case "favorite-userAccesses":
+        case "favorite-userGroupAccesses":
+            predicate = function predicate(favoritePermissions) {
+                var favoritePermissionIds = new Set(toArray(favoritePermissions).map(function (p) {
                     return p.id;
                 }));
-                predicate = function predicate(permissions) {
-                    return toArray(permissions).every(function (permission) {
-                        return favoritePermissionIds.has(permission.id);
+                return interpretations.every(function (interpretation) {
+                    return toArray(interpretation[field]).every(function (interpretationPermission) {
+                        return favoritePermissionIds.has(interpretationPermission.id);
                     });
-                };
-                break;
+                });
+            };
+            break;
+        default:
+            throw new Error("[validateFieldAccess] unknown field key: " + modelKey);
+    }
 
-            /* Favorite validations: check that all its interpretation sharings are a subset of this favorite sharing */
-            case "favorite-publicAccess":
-                predicate = function predicate(value) {
-                    return interpretations.every(function (interpretation) {
-                        return isObjectAccessible(value, interpretation[field]);
-                    });
-                };
-                break;
-            case "favorite-userAccesses":
-            case "favorite-userGroupAccesses":
-                predicate = function predicate(favoritePermissions) {
-                    var favoritePermissionIds = new Set(toArray(favoritePermissions).map(function (p) {
-                        return p.id;
-                    }));
-                    return interpretations.every(function (interpretation) {
-                        return toArray(interpretation[field]).every(function (interpretationPermission) {
-                            return favoritePermissionIds.has(interpretationPermission.id);
-                        });
-                    });
-                };
-                break;
-            default:
-                throw new Error("[validateFieldAccess] unknown field key: " + modelKey);
-        }
-    })();
-
     return checkValidationCondition(predicate, oldValue, newValue, showError);
@@ -100,0 +98,0 @@ };

package.json

 {
   "name": "d2-analysis",
-  "version": "33.1.0",
+  "version": "33.1.1",
   "description": "",
@@ -5,0 +5,0 @@ "main": "index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3841410

increased by0.08%

Worsened metrics

Lines of code

50750

decreased by-0.01%

No dependency changes