dash-shaka-playback - npm Package Compare versions

Comparing version 2.3.6 to 3.0.0

.eslintrc.js

@@ -5,3 +5,4 @@ module.exports = {
         "commonjs": true,
-        "es6": true
+        "es6": true,
+        "node": true,
     },
@@ -8,0 +9,0 @@ "extends": "eslint:recommended",

package.json

 {
   "name": "dash-shaka-playback",
-  "version": "2.3.6",
+  "version": "3.0.0",
   "description": "clappr dash playback based on shaka player",
@@ -15,3 +15,3 @@ "main": "./dist/dash-shaka-playback.js",
     "release": "webpack",
-    "lint": "eslint index.js"
+    "lint": "eslint src/"
   },
@@ -21,21 +21,21 @@ "author": "Clappr team",
   "peerDependencies": {
-    "clappr": "^0.3.4"
+    "@clappr/core": "^0.4.17"
   },
   "devDependencies": {
-    "babel-core": "^6.26.0",
-    "babel-loader": "^7.1.4",
-    "babel-plugin-add-module-exports": "^0.2.1",
-    "babel-preset-env": "^1.6.1",
-    "eslint": "^4.19.1",
-    "eslint-config-standard": "^11.0.0",
-    "eslint-plugin-import": "^2.10.0",
-    "eslint-plugin-node": "^6.0.1",
-    "eslint-plugin-promise": "^3.7.0",
-    "eslint-plugin-standard": "^3.0.1",
-    "shaka-player": "^2.5.5",
-    "uglifyjs-webpack-plugin": "^2.1.2",
-    "webpack": "^4.31.0",
-    "webpack-cli": "^3.3.2",
-    "webpack-dev-server": "^3.3.1"
+    "@babel/core": "^7.12.10",
+    "@babel/preset-env": "^7.12.11",
+    "babel-loader": "^8.2.2",
+    "babel-plugin-add-module-exports": "^1.0.4",
+    "eslint": "^7.18.0",
+    "eslint-config-standard": "^16.0.2",
+    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-promise": "^4.2.1",
+    "eslint-plugin-standard": "^4.1.0",
+    "shaka-player": "^3.0.7",
+    "uglifyjs-webpack-plugin": "^2.2.0",
+    "webpack": "^4.46.0",
+    "webpack-cli": "^3.3.12",
+    "webpack-dev-server": "^3.11.2"
   }
 }

src/clappr-dash-shaka-playback.js

@@ -90,3 +90,3 @@ import {HTML5Video, Log, Events, PlayerError} from 'clappr'
   get presentationTimeline() {
-    if (!this.shakaPlayerInstance) return
+    if (!this.shakaPlayerInstance || !this.shakaPlayerInstance.getManifest()) return null
 
@@ -97,3 +97,3 @@ return this.shakaPlayerInstance.getManifest().presentationTimeline
   get bandwidthEstimate() {
-    if (!this.shakaPlayerInstance) return
+    if (!this.shakaPlayerInstance) return null
     return this.shakaPlayerInstance.getStats().estimatedBandwidth
@@ -112,3 +112,3 @@ }
   getProgramDateTime() {
-    if (!this.shakaPlayerInstance) return 0
+    if (!this.shakaPlayerInstance || !this.presentationTimeline) return 0
 
@@ -373,15 +373,18 @@ return new Date((this.presentationTimeline.getPresentationStartTime() + this.seekRange.start) * 1000)
 
-  _setup () {
+  _setup() {
     this._isShakaReadyState = false
     this._ccIsSetup = false
-    this._player = this._createPlayer()
-    this._options.shakaConfiguration && this._player.configure(this._options.shakaConfiguration)
-    this._options.shakaOnBeforeLoad && this._options.shakaOnBeforeLoad(this._player)
 
-    let playerLoaded = this._player.load(this._options.src)
-    playerLoaded.then(() => this._loaded())
-      .catch((e) => this._setupError(e))
+    let runAllSteps = () => {
+      this._player = this._createPlayer()
+      this._setInitialConfig()
+      this._loadSource()
+    }
+
+    this._player
+      ? this._player.destroy().then(() => runAllSteps())
+      : runAllSteps()
   }
 
-  _createPlayer () {
+  _createPlayer() {
     let player = new shaka.Player(this.el)
@@ -394,2 +397,13 @@ player.addEventListener('error', this._onError.bind(this))
 
+  _setInitialConfig() {
+    this._options.shakaConfiguration && this._player.configure(this._options.shakaConfiguration)
+    this._options.shakaOnBeforeLoad && this._options.shakaOnBeforeLoad(this._player)
+  }
+
+  _loadSource() {
+    this._player.load(this._options.src)
+      .then(() => this._loaded())
+      .catch((e) => this._setupError(e))
+  }
+
   _onTimeUpdate() {
@@ -396,0 +410,0 @@ if (!this.shakaPlayerInstance) return

webpack.config.js

 const path = require('path')
-const webpack = require('webpack')
-const UglifyJsPlugin = require("uglifyjs-webpack-plugin")
+const UglifyJsPlugin = require('uglifyjs-webpack-plugin')
 
@@ -5,0 +4,0 @@ var NPM_RUN = process.env.npm_lifecycle_event

New alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Fixed alerts

Uses eval

Supply chain risk

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 1 instance in 1 package

Minified code

Quality

This package contains minified code. This may be harmless in some cases where minified code is included in packaged libraries, however packages on npm should not minify code.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

1

decreased by-75%

Number of medium supply chain risk alerts

1

decreased by-50%

Worsened metrics

Total package byte prevSize

171401

decreased by-91.33%

Number of package files

11

decreased by-38.89%

Lines of code

565

decreased by-87.39%

No dependency changes