date-holidays-parser - npm Package Compare versions

Comparing version 1.2.2 to 1.2.3

CHANGELOG.md

 # CHANGELOG
 
+v1.2.3
+- fix: holidays types not correctly filtered (date-holidays#56) 
+
+v1.2.2
+- refactor: keep bundle sizes small
+
 v1.2.1
@@ -4,0 +10,0 @@ - remove es5 `module`, `jsnext:main` from package.json to ease integration with

lib/Holidays.js

 /**
- * @copyright 2016 (c) commenthol
+ * @copyright 2016- (c) commenthol
  * @license ISC
@@ -452,13 +452,9 @@ */
   _setTypes: function _setTypes(t) {
-    t = t || [];
-    var types = {};
-    TYPES.map(function (type) {
-      for (var i in t) {
-        if (type !== t[i]) {
-          return;
-        }
+    t = t || TYPES;
+    this.__types = TYPES.reduce(function (types, type) {
+      if (t.indexOf(type) !== -1) {
+        types[type] = 1;
       }
-      types[type] = 1;
-    });
-    this.__types = types;
+      return types;
+    }, {});
   },
@@ -465,0 +461,0 @@

package.json

 {
   "name": "date-holidays-parser",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "parser for worldwide holidays",
@@ -14,2 +14,6 @@ "keywords": [
   },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/commenthol/date-holidays-parser.git"
+  },
   "license": "ISC",
@@ -24,6 +28,2 @@ "author": "commenthol <[e-mail]>",
   },
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/commenthol/date-holidays-parser.git"
-  },
   "scripts": {
@@ -37,3 +37,3 @@ "all": "npm run clean && npm run lint && npm run build && npm test",
     "doc": "jsdox -o docs src/Holidays.js",
-    "lint": "eslint '**/*.js'",
+    "lint": "eslint --fix '**/*.js'",
     "prepublishOnly": "npm run all",
@@ -40,0 +40,0 @@ "test": "mocha",

src/Holidays.js

 /**
- * @copyright 2016 (c) commenthol
+ * @copyright 2016- (c) commenthol
  * @license ISC
@@ -408,13 +408,9 @@ */
   _setTypes (t) {
-    t = t || []
-    const types = {}
-    TYPES.map(function (type) {
-      for (const i in t) {
-        if (type !== t[i]) {
-          return
-        }
+    t = t || TYPES
+    this.__types = TYPES.reduce((types, type) => {
+      if (t.indexOf(type) !== -1) {
+        types[type] = 1
       }
-      types[type] = 1
-    })
-    this.__types = types
+      return types
+    }, {})
   },
@@ -421,0 +417,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

212029

increased by0.02%

Worsened metrics

Lines of code

4153

decreased by-0.19%

No dependency changes