deadunit-core - npm Package Compare versions

Comparing version 5.0.2 to 5.0.3

npm-shrinkwrap.json

 {
   "name": "deadunit-core",
-  "version": "5.0.0",
+  "version": "5.0.2",
   "dependencies": {
@@ -8,8 +8,22 @@ "ajax": {
       "from": "https://github.com/fresheneesz/ajax/archive/c0f12d10544a247bfa58b15e9535ee2ffd5787d1.tar.gz",
-      "resolved": "https://github.com/fresheneesz/ajax/archive/c0f12d10544a247bfa58b15e9535ee2ffd5787d1.tar.gz"
+      "resolved": "https://github.com/fresheneesz/ajax/archive/c0f12d10544a247bfa58b15e9535ee2ffd5787d1.tar.gz",
+      "dependencies": {
+        "async-future": {
+          "version": "0.1.18",
+          "from": "async-future@0.1.18",
+          "resolved": "https://registry.npmjs.org/async-future/-/async-future-0.1.18.tgz",
+          "dependencies": {
+            "trimArguments": {
+              "version": "1.0.0",
+              "from": "https://github.com/fresheneesz/trimArguments/archive/e69ed3ebdfe6cf055916ba6e3a1e4b28f696da6f.tar.gz",
+              "resolved": "https://github.com/fresheneesz/trimArguments/archive/e69ed3ebdfe6cf055916ba6e3a1e4b28f696da6f.tar.gz"
+            }
+          }
+        }
+      }
     },
     "async-future": {
-      "version": "0.1.18",
-      "from": "async-future@0.1.18",
-      "resolved": "https://registry.npmjs.org/async-future/-/async-future-0.1.18.tgz",
+      "version": "1.0.0",
+      "from": "async-future@1.0.0",
+      "resolved": "https://registry.npmjs.org/async-future/-/async-future-1.0.0.tgz",
       "dependencies": {
@@ -53,4 +67,5 @@ "trimArguments": {
         "atob": {
-          "version": "1.1.0",
-          "from": "atob@~1.1.0"
+          "version": "1.1.2",
+          "from": "atob@~1.1.0",
+          "resolved": "https://registry.npmjs.org/atob/-/atob-1.1.2.tgz"
         },
@@ -57,0 +72,0 @@ "urix": {

package.json

 {"name":"deadunit-core",
  "description": "The core for deadunit - a dead-simple nestable unit testing library for javascript in node.js and the browser.",
  "keywords": ["unit", "test", "testing", "javascript", "node", "deadunit", "asynchronous"],
- "version":"5.0.2",
+ "version":"5.0.3",
  "dependencies":{
-	 "async-future":"0.1.18",
+	 "async-future":"1.0.0",
      "stack-trace":"0.0.7",
@@ -8,0 +8,0 @@ "stackinfo":"1.1.2",

processResults.js

@@ -73,2 +73,3 @@ module.exports = function returnResults(unitTestObject) {
             primaryGroup.timeout = e.type === 'timeout'
+            setGroupDuration(primaryGroup.id, e.time)
 
@@ -86,3 +87,3 @@ // make the count assertions
 
-                    subtest.results.push({
+                    subtest.results.splice(0,0,{
                         parent: subtest.id,
@@ -107,3 +108,7 @@ type: 'assert',
     function setGroupDuration(groupid, time) {
-        groups[groupid].duration = time - groups[groupid].time
+        var newDuration = time - groups[groupid].time
+        if(newDuration > groups[groupid].duration) {
+            groups[groupid].duration = newDuration
+        }
+
         if(groups[groupid].parent) {
@@ -110,0 +115,0 @@ setGroupDuration(groups[groupid].parent, time)

README.md

@@ -305,2 +305,6 @@ `deadunitCore`
 
+* 5.0.3
+    * fixing time calculating issue
+    * moving counts to the top of the results for each group
+    * pulling in new version of futures for a major performance improvement
 * 5.0.2 - fixing annoying bug where eq's expected and got are backwards
@@ -307,0 +311,0 @@ * 5.0.1

test/deadunitTests.js

@@ -235,3 +235,6 @@ "use strict";
 
-                                var subtest2 = subtest1.results[0]
+                                var subtest2 = subtest1.results[0]     // count
+                                this.ok(subtest2.success === false, subtest2.success)
+
+                                subtest2 = subtest1.results[1]
                                 this.ok(subtest2.type === "group")
@@ -252,3 +255,3 @@ this.ok(subtest2.name === "assertSomething")
                                     } else {
-                                        var subtest3line = 1193
+                                        var subtest3line = 1194
                                         this.ok(subtest3.line === subtest3line, subtest3.line) // browserify bug causes sourcemap to not be found
@@ -259,3 +262,3 @@ }
 
-                                subtest2 = subtest1.results[1]
+                                subtest2 = subtest1.results[2]
                                 this.ok(subtest2.name === "'shouldFail' fails correctly", subtest2.name)
@@ -265,3 +268,7 @@ this.ok(subtest2.exceptions.length === 0)
 
-                                    subtest3 = subtest2.results[0]
+                                    subtest3 = subtest2.results[0]      // count
+                                    this.ok(subtest3.type === "assert", subtest3.type)
+                                    this.ok(subtest3.success === true, subtest3.success)
+
+                                    subtest3 = subtest2.results[1]
                                     this.ok(subtest3.success === false)
@@ -272,3 +279,3 @@ this.ok(subtest3.sourceLines.indexOf("5 === 3") !== -1)
 
-                                    subtest3 = subtest2.results[1]
+                                    subtest3 = subtest2.results[2]
                                     this.ok(subtest3.success === false)
@@ -280,3 +287,3 @@ this.ok(subtest3.sourceLines.indexOf("true, false") !== -1)
 
-                                    subtest3 = subtest2.results[2]
+                                    subtest3 = subtest2.results[3]
                                     this.ok(subtest3.type === "log")
@@ -286,7 +293,3 @@ this.ok(subtest3.values.length === 1)
 
-                                    subtest3 = subtest2.results[3]      // count
-                                    this.ok(subtest3.type === "assert", subtest3.type)
-                                    this.ok(subtest3.success === true, subtest3.success)
-
-                                subtest2 = subtest1.results[2]
+                                subtest2 = subtest1.results[3]
                                 this.ok(subtest2.name === "shouldThrowException")
@@ -298,9 +301,9 @@ this.ok(subtest2.exceptions.length === 1)
 
-                                    subtest3 = subtest2.results[0]
+                                    subtest3 = subtest2.results[0]     // count
                                     this.ok(subtest3.success === true)
 
-                                    subtest3 = subtest2.results[1]     // count
+                                    subtest3 = subtest2.results[1]
                                     this.ok(subtest3.success === true)
 
-                                subtest2 = subtest1.results[3]
+                                subtest2 = subtest1.results[4]
                                 this.ok(subtest2.name === "should throw an asynchronous exception")
@@ -318,6 +321,7 @@ if(testEnvironment === 'node') {
 
-                                this.ok(subtest1.results[4].type === 'log', subtest1.results[4].type) // log
-                                this.ok(subtest1.results[4].values[0] === 'subtest without a name')
+                                subtest2 = subtest1.results[5]
+                                this.ok(subtest2.type === 'log', subtest2.type) // log
+                                this.ok(subtest2.values[0] === 'subtest without a name')
 
-                                subtest2 = subtest1.results[5]
+                                subtest2 = subtest1.results[6]
                                 this.ok(subtest2.name === undefined)
@@ -327,5 +331,2 @@ this.ok(subtest2.exceptions.length === 0)
                                 this.ok(subtest2.results[0].success === true)
-
-                                subtest2 = subtest1.results[6]     // count
-                                this.ok(subtest2.success === false, subtest2.success)
                         })
@@ -445,6 +446,6 @@
                         t.ok(results.results.length === 3, results.results.length)
-                        t.ok(results.results[0].results.length === 2)
-                        t.ok(results.results[0].results[0].success === true)
-                        t.ok(results.results[0].duration >= 200, require('util').inspect(results.results[0]))
-                        t.ok(results.results[1].success === true)
+                        t.ok(results.results[0].success === true)  // count
+                        t.ok(results.results[1].results.length === 2)
+                        t.ok(results.results[1].results[0].success === true)
+                        t.ok(results.results[1].duration >= 200, require('util').inspect(results.results[0]))
 
@@ -463,10 +464,12 @@ }).catch(function(e) {
                 t.ok(results.results.length === 3, results.results.length)
-                t.ok(results.results[2].actual === 2 && results.results[2].success === true, require('util').inspect(results.results[2]))
-                var subtest1 = results.results[0]
-                t.ok(subtest1.results[2].actual === 2 && subtest1.results[2].success === true, require('util').inspect(subtest1.results[2]))
-                t.ok(subtest1.results.length === 3, subtest1.results.length)
-                var subtest2 = subtest1.results[0]
-                t.ok(subtest2.results.length === 2, subtest2.results.length)
-                t.ok(subtest2.results[1].actual === 1
-                    && subtest2.results[1].success === true, require('util').inspect(subtest2.results[1]))
+                t.ok(results.results[0].actual === 2 && results.results[2].success === true, require('util').inspect(results.results[2]))
+                var subtest1 = results.results[1]
+                    var subtest1Count = subtest1.results[0]
+                    t.ok(subtest1Count.actual === 2 && subtest1Count.success === true, require('util').inspect(subtest1Count))
+                    t.ok(subtest1.results.length === 3, subtest1.results.length)
+                    var subtest2 = subtest1.results[1]
+                        var subtest2Count = subtest2.results[0]
+                        t.ok(subtest2.results.length === 2, subtest2.results.length)
+                        t.ok(subtest2Count.actual === 1
+                            && subtest2Count.success === true, require('util').inspect(subtest2Count))
             }
@@ -473,0 +476,0 @@

test/testDeadunit.node.js

@@ -70,12 +70,14 @@ "use strict";
 
-                    t.ok(results.results[0].exceptions.length === 0, require('util').inspect(results.results[0].exceptions))
-                    t.ok(results.results[0].results.length === 1, results.results[0].results.length)
-                    t.ok(results.results[0].results[0].success === true)
-                    t.ok(results.results[0].duration !== undefined, results.results[0].duration)
-                    t.ok(results.results[0].duration >= 0, results.results[0].duration)
+                    var subtest1 = results.results[1]
+                    t.ok(subtest1.exceptions.length === 0, require('util').inspect(subtest1.exceptions))
+                    t.ok(subtest1.results.length === 1, subtest1.results.length)
+                    t.ok(subtest1.results[0].success === true)
+                    t.ok(subtest1.duration !== undefined, subtest1.duration)
+                    t.ok(subtest1.duration >= 0, results.results[0].duration)
 
-                    t.ok(results.results[1].exceptions.length === 0, require('util').inspect(results.results[0].exceptions))
-                    t.ok(results.results[1].results.length === 0)
-                    t.ok(results.results[1].duration !== undefined, results.results[1].duration)
-                    t.ok(results.results[1].duration >= 0, results.results[1].duration)
+                    subtest1 = results.results[2]
+                    t.ok(subtest1.exceptions.length === 0, require('util').inspect(results.results[0].exceptions))
+                    t.ok(subtest1.results.length === 0)
+                    t.ok(subtest1.duration !== undefined, subtest1.duration)
+                    t.ok(subtest1.duration >= 0, subtest1.duration)
                 }).done()
@@ -82,0 +84,0 @@ }})

No alert changes

Improved metrics

Total package byte prevSize

1302572

increased by1.81%

Lines of code

16866

increased by2.08%

Number of lines in readme file

362

increased by1.12%

Dependency changes

• + Addedasync-future@1.0.0(transitive)

• - Removedasync-future@0.1.18(transitive)

• Updatedasync-future@1.0.0