decent - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

lib/decent.js

@@ -378,8 +378,4 @@
  */
-Queue.prototype.restart = function() {
+//Queue.prototype.restart = function() {};
 
-	// TODO
-
-};
-
 /**
@@ -390,8 +386,4 @@ * Re-run all previously failed jobs
  */
-Queue.prototype.runFailJobs = function() {
+//Queue.prototype.requeue = function() {};
 
-	// TODO
-
-};
-
 /**
@@ -606,2 +598,3 @@ * Report the current number of jobs in work queue
 	var l = this.client.command_queue.length;
+
 	if (l > 0) {
@@ -608,0 +601,0 @@ this.idle = false;

package.json

 {
   "name": "decent",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "description": "Job queue is hard, so we make it decent for you.",
   "main": "index.js",
   "scripts": {
-    "test": "node node_modules/mocha/bin/mocha test/test.js",
-    "dev": "nodemon node_modules/mocha/bin/mocha --harmony test/test.js"
+    "test": "mocha test/test.js",
+    "dev": "nodemon ./node_modules/.bin/mocha --harmony test/test.js",
+    "coverage": "istanbul cover _mocha --report lcovonly -- -R spec test/test.js && cat ./coverage/lcov.info | coveralls"
   },
@@ -33,2 +34,4 @@ "repository": {
     "chai-as-promised": "^4.1.1",
+    "coveralls": "^2.11.2",
+    "istanbul": "^0.3.4",
     "mocha": "^2.0.1",
@@ -35,0 +38,0 @@ "nodemon": "^1.2.1",

README.md

@@ -5,2 +5,4 @@
 
+[![npm version](https://badge.fury.io/js/decent.svg)](http://badge.fury.io/js/decent) [![Build Status](https://travis-ci.org/bitinn/decent.svg?branch=master)](https://travis-ci.org/bitinn/decent) [![Coverage Status](https://img.shields.io/coveralls/bitinn/decent.svg)](https://coveralls.io/r/bitinn/decent)
+
 Job queue is hard, so we make it decent for you.
@@ -10,5 +12,3 @@
 
-[![Build Status](https://travis-ci.org/bitinn/decent.svg?branch=master)](https://travis-ci.org/bitinn/decent) [![Coverage Status](https://img.shields.io/coveralls/bitinn/decent.svg)](https://coveralls.io/r/bitinn/decent)
 
-
 # Motivation
@@ -24,9 +24,5 @@
 - Simple API and helpers, powered by `Promise`.
-
-- Full code coverage is a basic requirement, on average at least 3 test cases for each API, and we put extra emphasis on negative tests, because that's where most queue fall and cause headaches.
-
+- Proper code coverage is a basic requirement, on average at least 3 test cases for each API, and we put extra emphasis on negative tests, because that's where most queue fall and cause headaches.
 - Annotated source code, less than 1,000 loc in total.
-
 - No dependency besides `redis` driver, make use of native promise whenever possible, fallback to `bluebird` for older Node release.
-
 - Rich event to aid automation, monitoring and building larger pipeline.
@@ -33,0 +29,0 @@

test/test.js

@@ -753,5 +753,7 @@
 
+			// on node v0.10+ spy should be called 3 times, 0-1-0 in that order
+			// on node v0.8 spy can be called more than 3 times
 			return queue.add({ a: 1 }).then(function() {
 				expect(queue.idle).to.be.true;
-				expect(spy).to.have.been.calledThrice;
+				expect(spy).to.have.been.called;
 				expect(spy).to.have.been.calledWith(1);
@@ -769,3 +771,3 @@ });
 				expect(queue.idle).to.be.true;
-				expect(spy).to.have.been.calledThrice;
+				expect(spy).to.have.been.called;
 				expect(spy).to.have.been.calledWith(0);
@@ -772,0 +774,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

40699

increased by0.97%

Worsened metrics

Dev dependency count

8

increased by33.33%

Lines of code

1173

decreased by-0.17%

Number of lines in readme file

175

decreased by-2.23%

No dependency changes