denim-api-auth-middleware - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

api-auth-middleware.js

 const makeApiKeyAuthMiddleware = apiKeys => (req, res, next) => {
-	const authHeader = req.get('Authorization')
-	if(typeof authHeader === 'undefined') {
-		res.status(403).send('Forbidden')
-	}else{
-		const authHeaderParts = req.get('Authorization').split(':')
-		const reqKey = authHeaderParts[0]
-		const reqPass = authHeaderParts[authHeaderParts.length - 1]
-
-		if (apiKeys[reqKey] !== reqPass) {
-			res.status(403).send('Forbidden')
-		}
-	}
-
-  next()
+  const forbiddenHandler = () => res.status(403).send('Forbidden')
+  const authHeader = req.get('Authorization')
+  if (typeof authHeader === 'undefined') {
+    forbiddenHandler()
+  } else {
+    const authHeaderParts = authHeader.split(':')
+    const reqKey = authHeaderParts[0]
+    const reqPass = authHeaderParts[authHeaderParts.length - 1]
+    const apiPass = apiKeys[reqKey]
+    console.log(apiPass, reqPass, apiPass === reqPass)
+    if (apiPass !== reqPass) {
+      console.log('FORBIDDEN NEWB')
+      forbiddenHandler()
+    } else {
+      next()
+    }
+  }
 }
 
 export default makeApiKeyAuthMiddleware

dist/api-auth-middleware.js

 'use strict';
 
 Object.defineProperty(exports, "__esModule", {
-	value: true
+  value: true
 });
 var makeApiKeyAuthMiddleware = function makeApiKeyAuthMiddleware(apiKeys) {
-	return function (req, res, next) {
-		var authHeader = req.get('Authorization');
-		if (typeof authHeader === 'undefined') {
-			res.status(403).send('Forbidden');
-		} else {
-			var authHeaderParts = req.get('Authorization').split(':');
-			var reqKey = authHeaderParts[0];
-			var reqPass = authHeaderParts[authHeaderParts.length - 1];
-
-			if (apiKeys[reqKey] !== reqPass) {
-				res.status(403).send('Forbidden');
-			}
-		}
-
-		next();
-	};
+  return function (req, res, next) {
+    var forbiddenHandler = function forbiddenHandler() {
+      return res.status(403).send('Forbidden');
+    };
+    var authHeader = req.get('Authorization');
+    if (typeof authHeader === 'undefined') {
+      forbiddenHandler();
+    } else {
+      var authHeaderParts = authHeader.split(':');
+      var reqKey = authHeaderParts[0];
+      var reqPass = authHeaderParts[authHeaderParts.length - 1];
+      var apiPass = apiKeys[reqKey];
+      console.log(apiPass, reqPass, apiPass === reqPass);
+      if (apiPass !== reqPass) {
+        console.log('FORBIDDEN NEWB');
+        forbiddenHandler();
+      } else {
+        next();
+      }
+    }
+  };
 };
 
-exports.default = makeApiKeyAuthMiddleware;
-//# sourceMappingURL=api-auth-middleware.js.map
+exports.default = makeApiKeyAuthMiddleware;

dist/index.js

@@ -13,3 +13,2 @@ 'use strict';
 
-exports.default = _apiAuthMiddleware2.default;
-//# sourceMappingURL=index.js.map
+exports.default = _apiAuthMiddleware2.default;

index.js

@@ -1,3 +0,3 @@
-import  makeApiKeyAuthMiddleware  from './api-auth-middleware'
+import makeApiKeyAuthMiddleware from './api-auth-middleware'
 
 export default makeApiKeyAuthMiddleware

package.json

 {
   "name": "denim-api-auth-middleware",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Express API Key Auth Middleware",
@@ -35,3 +35,6 @@ "main": "dist/index.js",
   },
-  "pre-commit": ["precommit"]
+  "pre-commit": ["precommit"],
+  "dependencies": {
+    "chai": "^4.1.2"
+  }
 }

README.md

@@ -41,8 +41,12 @@ # denim-api-auth-middleware
 ## Running the tests
+run tests once:
+`yarn test`
 
-Not yet implemented.
+watch tests:
+`yarn test --watch`
 
 ## Deployment
 
-`npm version NEWVER`
+`npm version NEWVER` or manually update `package.json`
+
 `npm publish`
@@ -54,4 +58,5 @@
 * [babel-cli](https://www.npmjs.com/package/babel-cli) - Used for transpiling and running es6
-** [babel-preset-env](https://www.npmjs.com/package/babel-preset-env) - Used for transpiling and running es6
+* [babel-preset-env](https://www.npmjs.com/package/babel-preset-env) - Used for transpiling and running es6
 * [jest](https://www.npmjs.com/package/jest) - Testing framework
+* [chai](http://chaijs.com/) - Assertion Library
 * [husky](https://www.npmjs.com/package/husky) - Pre-commit hooks
@@ -58,0 +63,0 @@ * [lint-staged](https://www.npmjs.com/package/lint-staged) - Linting for changed files

No alert changes

Improved metrics

Lines of code

157

increased by241.3%

Number of lines in readme file

76

increased by7.04%

Worsened metrics

Total package byte prevSize

9401

decreased by-96.42%

Dependency count

1

increased byInfinity%

Number of package files

10

decreased by-23.08%

Dependency changes

• + Addedchai@^4.1.2

• + Addedassertion-error@1.1.0(transitive)

• + Addedchai@4.5.0(transitive)

• + Addedcheck-error@1.0.3(transitive)

• + Addeddeep-eql@4.1.4(transitive)

• + Addedget-func-name@2.0.2(transitive)

• + Addedloupe@2.3.7(transitive)

• + Addedpathval@1.1.1(transitive)

• + Addedtype-detect@4.1.0(transitive)