devtools-local-toolbox - npm Package Compare versions

Comparing version 0.0.5 to 0.0.6

bin/development-server.js

@@ -27,6 +27,8 @@ #!/usr/bin/env node
 
-const { getValue, isDevelopment } = require("devtools-config");
-const {registerConfig} = require("../../devtools-config/registerConfig");
-registerConfig();
+const getConfig = require("../../devtools-config/src/config").getConfig;
+const getValue = require("devtools-config").getValue;
+const setConfig = require("devtools-config").setConfig;
+const isDevelopment = require("devtools-config").isDevelopment;
 
+setConfig(getConfig());
 
@@ -33,0 +35,0 @@ if (!getValue("firefox.webSocketConnection")) {

package.json

 {
   "name": "devtools-local-toolbox",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "license": "MPL-2.0",
@@ -28,3 +28,3 @@ "repository": {
     "check-node-version": "^1.1.2",
-    "chrome-remote-debug-protocol": "^0.0.3",
+    "chrome-remote-debugging-protocol": "^0.0.3",
     "co": "=4.6.0",
@@ -31,0 +31,0 @@ "css-loader": "^0.25.0",

public/js/clients/chrome.js

 /* eslint-disable */
 
-const { connect } = require("chrome-remote-debug-protocol");
+const { connect } = require("chrome-remote-debugging-protocol");
 const defer = require("../utils/defer");
@@ -5,0 +5,0 @@ const { Tab } = require("../types");

public/js/clients/firefox/commands.js

@@ -57,18 +57,22 @@ const { BreakpointResult, Location } = require("../../types");
     noSliding
-  }).then(([res, bpClient]) => {
-    bpClients[bpClient.actor] = bpClient;
+  }).then((res) => onNewBreakpoint(location, res));
+}
 
-    // Firefox only returns `actualLocation` if it actually changed,
-    // but we want it always to exist. Format `actualLocation` if it
-    // exists, otherwise use `location`.
-    const actualLocation = res.actualLocation ? {
-      sourceId: res.actualLocation.source.actor,
-      line: res.actualLocation.line,
-      column: res.actualLocation.column
-    } : location;
+function onNewBreakpoint(location, res) {
+  const bpClient = res[1];
+  let actualLocation = res[0].actualLocation;
+  bpClients[bpClient.actor] = bpClient;
 
-    return BreakpointResult({
-      id: bpClient.actor,
-      actualLocation: Location(actualLocation)
-    });
+  // Firefox only returns `actualLocation` if it actually changed,
+  // but we want it always to exist. Format `actualLocation` if it
+  // exists, otherwise use `location`.
+  actualLocation = actualLocation ? {
+    sourceId: actualLocation.source.actor,
+    line: actualLocation.line,
+    column: actualLocation.column
+  } : location;
+
+  return BreakpointResult({
+    id: bpClient.actor,
+    actualLocation: Location(actualLocation)
   });
@@ -118,2 +122,10 @@ }
 
+function setBreakpointCondition(breakpointId, location, condition, noSliding) {
+  let bpClient = bpClients[breakpointId];
+  bpClients[breakpointId] = null;
+
+  return bpClient.setCondition(threadClient, condition, noSliding)
+    .then(_bpClient => onNewBreakpoint(location, [{}, _bpClient]));
+}
+
 function evaluate(script) {
@@ -180,2 +192,3 @@ const deferred = defer();
   toggleAllBreakpoints,
+  setBreakpointCondition,
   evaluate,
@@ -182,0 +195,0 @@ debuggeeCommand,

README.md

@@ -25,3 +25,3 @@ # Local Toolbox
 
-* *chrome-remote-debug-protocol*
+* *chrome-remote-debugging-protocol*
 
@@ -28,0 +28,0 @@ ## Getting Started

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

126469

increased by0.42%

Lines of code

4063

increased by0.3%

No dependency changes