dock-spawn-ts - npm Package Compare versions

Comparing version 2.509.0 to 2.510.0

lib/js/DockLayoutEngine.js

@@ -83,3 +83,3 @@ import { DockNode } from "./DockNode.js";
     close(node) {
-        let parentNode = node.parent;
+        let parentNode = node === null || node === void 0 ? void 0 : node.parent;
         if (!parentNode)
@@ -86,0 +86,0 @@ throw new Error('Cannot undock.  panel is not a leaf node');

lib/js/PanelContainer.d.ts

@@ -77,3 +77,3 @@ import { DockManager } from "./DockManager.js";
     */
-    performClose(): void;
+    private performClose;
     /**
@@ -80,0 +80,0 @@ * Undocks the container and from the layout hierarchy

lib/js/PanelContainer.js

@@ -355,18 +355,20 @@ import { Utils } from "./Utils.js";
         let close = true;
-        this.dockManager.config.dialogRootElement.removeChild(this.elementContentContainer);
-        if (this.closePanelContainerCallback)
-            close = await this.closePanelContainerCallback(this);
-        else if (this.dockManager.closePanelContainerCallback)
-            close = await this.dockManager.closePanelContainerCallback(this);
-        if (close) {
-            if (this.isDialog) {
-                if (this.floatingDialog) {
-                    //this.floatingDialog.hide();
-                    this.floatingDialog.close(); // fires onClose notification
+        if (this.elementContentContainer.parentElement === this.dockManager.config.dialogRootElement) {
+            this.dockManager.config.dialogRootElement.removeChild(this.elementContentContainer);
+            if (this.closePanelContainerCallback)
+                close = await this.closePanelContainerCallback(this);
+            else if (this.dockManager.closePanelContainerCallback)
+                close = await this.dockManager.closePanelContainerCallback(this);
+            if (close) {
+                if (this.isDialog) {
+                    if (this.floatingDialog) {
+                        //this.floatingDialog.hide();
+                        this.floatingDialog.close(); // fires onClose notification
+                    }
                 }
+                else {
+                    this.performClose();
+                    this.dockManager.notifyOnClosePanel(this);
+                }
             }
-            else {
-                this.performClose();
-                this.dockManager.notifyOnClosePanel(this);
-            }
         }
@@ -373,0 +375,0 @@ }

lib/js/TabHandle.js

@@ -189,6 +189,10 @@ import { PanelContainer } from "./PanelContainer.js";
         }
-        Utils.removeNode(this.elementBase);
-        Utils.removeNode(this.elementCloseButton);
-        delete this.elementBase;
-        delete this.elementCloseButton;
+        if (this.elementBase) {
+            Utils.removeNode(this.elementBase);
+            delete this.elementBase;
+        }
+        if (this.elementCloseButton) {
+            Utils.removeNode(this.elementCloseButton);
+            delete this.elementCloseButton;
+        }
     }
@@ -195,0 +199,0 @@ _performUndock(e, dragOffset) {

lib/js/TabHost.js

@@ -146,4 +146,6 @@ import { TabPage } from "./TabPage.js";
             let handle = page.handle;
-            handle.elementBase.style.width = ''; //clear
-            tabListWidth += handle.elementBase.clientWidth;
+            if (handle.elementBase != null) {
+                handle.elementBase.style.width = ''; //clear
+                tabListWidth += handle.elementBase.clientWidth;
+            }
         });
@@ -150,0 +152,0 @@ let scaleMultiplier = width / tabListWidth;

package.json

 {
   "name": "dock-spawn-ts",
-  "version": "2.509.0",
+  "version": "2.510.0",
   "description": "DockSpawn Typescript Version",
@@ -5,0 +5,0 @@ "license": "MIT",

src/DockLayoutEngine.ts

@@ -99,3 +99,3 @@ import { DockManager } from "./DockManager.js";
     close(node: DockNode) {
-        let parentNode = node.parent;
+        let parentNode = node?.parent;
         if (!parentNode)
@@ -102,0 +102,0 @@ throw new Error('Cannot undock.  panel is not a leaf node');

src/PanelContainer.ts

@@ -298,3 +298,3 @@ import { DockManager } from "./DockManager.js";
     */
-    performClose() {
+    private performClose() {
         this.isDialog = true;
@@ -449,22 +449,24 @@ this.undockInitiator.enabled = false;
 
-        this.dockManager.config.dialogRootElement.removeChild(this.elementContentContainer);
+        if (this.elementContentContainer.parentElement === this.dockManager.config.dialogRootElement) {
+            this.dockManager.config.dialogRootElement.removeChild(this.elementContentContainer);
 
-        if (this.closePanelContainerCallback)
-            close = await this.closePanelContainerCallback(this);
-        else if (this.dockManager.closePanelContainerCallback)
-            close = await this.dockManager.closePanelContainerCallback(this);
+            if (this.closePanelContainerCallback)
+                close = await this.closePanelContainerCallback(this);
+            else if (this.dockManager.closePanelContainerCallback)
+                close = await this.dockManager.closePanelContainerCallback(this);
 
-        if (close) {
-            if (this.isDialog) {
-                if (this.floatingDialog) {
-                    //this.floatingDialog.hide();
-                    this.floatingDialog.close(); // fires onClose notification
+            if (close) {
+                if (this.isDialog) {
+                    if (this.floatingDialog) {
+                        //this.floatingDialog.hide();
+                        this.floatingDialog.close(); // fires onClose notification
+                    }
                 }
+                else {
+                    this.performClose();
+                    this.dockManager.notifyOnClosePanel(this);
+                }
             }
-            else {
-                this.performClose();
-                this.dockManager.notifyOnClosePanel(this);
-            }
         }
     }
 }

src/TabHandle.ts

@@ -274,6 +274,11 @@ import { TabPage } from "./TabPage.js";
 
-        Utils.removeNode(this.elementBase);
-        Utils.removeNode(this.elementCloseButton);
-        delete this.elementBase;
-        delete this.elementCloseButton;
+        if(this.elementBase){
+            Utils.removeNode(this.elementBase);
+            delete this.elementBase;
+        }
+        
+        if(this.elementCloseButton){
+            Utils.removeNode(this.elementCloseButton);
+            delete this.elementCloseButton;
+        }
     }
@@ -280,0 +285,0 @@

src/TabHost.ts

@@ -184,4 +184,6 @@ import { TabPage } from "./TabPage.js";
             let handle = page.handle;
-            handle.elementBase.style.width = ''; //clear
-            tabListWidth += handle.elementBase.clientWidth;
+            if (handle.elementBase != null){
+                handle.elementBase.style.width = ''; //clear
+                tabListWidth += handle.elementBase.clientWidth;
+            }
         });
@@ -188,0 +190,0 @@ let scaleMultiplier = width / tabListWidth;

No alert changes

Improved metrics

Total package byte prevSize

754440

increased by0.17%

Lines of code

10445

increased by0.16%

No dependency changes