dockerode - npm Package Compare versions

Comparing version 0.1.3 to 0.1.4

lib/modem.js

@@ -16,3 +16,3 @@ var querystring = require('querystring'),
 Modem.prototype.dial = function(options, callback) {
-  var opts, url, data;
+  var opts, address, data;
   var self = this;
@@ -25,5 +25,5 @@
   if(this.host) {
-    url = url.resolve(this.host, options.path);
+    address = url.resolve(this.host, options.path);
   } else {
-    url = options.path;
+    address = options.path;
   }
@@ -34,5 +34,5 @@
     if (opts && Object.keys(opts).length > 0) {
-      url += querystring.stringify(opts);
+      address += querystring.stringify(opts);
     } else {
-      url = url.substring(0, url.length - 1);
+      address = address.substring(0, address.length - 1);
     }
@@ -42,12 +42,10 @@ }
   var optionsf = {
-    path: url,
+    path: address,
     method: options.method
   };
 
+  optionsf.headers = {};
   if(options.file) {
     data = fs.readFileSync(p.resolve(options.file));
-    optionsf.headers = {
-      'Content-Type': 'application/tar',
-      'Content-Length': data.length
-    };
+    optionsf.headers['Content-Type'] = 'application/tar';
   } else if(opts && options.method === 'POST') {
@@ -57,2 +55,6 @@ data = JSON.stringify(opts);
 
+  if(data) {
+    optionsf.headers['Content-Length'] = data.length;
+  }
+
   if(this.socketPath) {
@@ -59,0 +61,0 @@ optionsf.socketPath = this.socketPath;

package.json

 {
   "name": "dockerode",
   "description": "Docker.io Remote API implementation. All features implemented.",
-  "version": "0.1.3",
+  "version": "0.1.4",
   "author": "Pedro Dias <[e-mail]>",
@@ -6,0 +6,0 @@ "maintainers": [

README.md

@@ -10,3 +10,3 @@ # dockerode
 * **run** - `dockerode` allow you to seamless run commands in a container ala `docker run`.
-* **tests** - `dockerode` really aims to have a good test set, allowing to follow `Docker` changes easily, quickly and painfully.
+* **tests** - `dockerode` really aims to have a good test set, allowing to follow `Docker` changes easily, quickly and painlessly.
 * **ws** - New websocket endpoints introduced in 0.6 are supported. (beta, do not use in production yet)
@@ -112,2 +112,2 @@ * **features** - ALL `Docker` Remote API features implemented.
 see the license for the specific language governing permissions and
-limitations under the license.
+limitations under the license.

No alert changes

Improved metrics

Total package byte prevSize

29879

increased by0.27%

Lines of code

889

increased by0.11%

Number of lines in readme file

112

increased by0.9%

No dependency changes